Skip to contentSkip to conversation

ARM: ux500: enable the crypto and hash on all dbx500

PATCH New Linus Walleij 3 participants 4 messages May 24, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ux500: enable the crypto and hash on all dbx500

From: Linus Walleij <[email protected]>

Commits:
"ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" "ARM: ux500: Add Device Tree nodes for the ux500 Hash device"

Added the crypto and hash devices conditionally, i.e. so as to be turned on per-board by setting an "status" property on the device from "disabled" to "okay" on each device.

This is wrong since this is an SoC feature, it is not board dependent. It is the same ASIC under all circumstances and functionality does not vary with board family.

This moves the enablement into the SoC file.

---
 arch/arm/boot/dts/dbx5x0.dtsi  | 4 ----
 arch/arm/boot/dts/snowball.dts | 8 --------
 2 files changed, 12 deletions(-)
arch/arm/boot/dts/dbx5x0.dtsi +0 -4
index f051963..cd5cd09 100644
@@ -760,17 +760,13 @@
 			compatible = "stericsson,ux500-cryp";
 			reg = <0xa03cb000 0x1000>;
 			interrupts = <0 15 0x4>;
-
 			v-ape-supply = <&db8500_vape_reg>;
-			status = "disabled";
 		};
 
 		hash at a03c2000 {
 			compatible = "stericsson,ux500-hash";
 			reg = <0xa03c2000 0x1000>;
-
 			v-ape-supply = <&db8500_vape_reg>;
-			status = "disabled";
 		};
 	};
 };
arch/arm/boot/dts/snowball.dts +0 -8
index bda002f..e8219cc7 100644
@@ -356,13 +356,5 @@
 				};
 			};
 		};
-
-		cryp at a03cb000 {
-			status = "okay";
-		};
-
-		hash at a03c2000 {
-			status = "okay";
-		};
 	};
 };
Signature · 1 line
1.7.11.3
#1 lore raw

PATCH 1/1 ARM: ux500: enable the crypto and hash on all dbx500

Quoted 28 lines · Linus Walleij

From: Linus Walleij <[email protected]>

Commits:
"ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" "ARM: ux500: Add Device Tree nodes for the ux500 Hash device"

Added the crypto and hash devices conditionally, i.e. so as to be turned on per-board by setting an "status" property on the device from "disabled" to "okay" on each device.

This is wrong since this is an SoC feature, it is not board dependent. It is the same ASIC under all circumstances and functionality does not vary with board family.

This moves the enablement into the SoC file.

---
 arch/arm/boot/dts/dbx5x0.dtsi  | 4 ----
 arch/arm/boot/dts/snowball.dts | 8 --------
 2 files changed, 12 deletions(-)
arch/arm/boot/dts/dbx5x0.dtsi +0 -0
index f051963..cd5cd09 100644

arch/arm/boot/dts/dbx5x0.dtsi line 763

Quoted 4 lines
arch/arm/boot/dts/dbx5x0.dtsi +0 -1
@@ -760,17 +760,13 @@
 			compatible = "stericsson,ux500-cryp";
 			reg = <0xa03cb000 0x1000>;
 			interrupts = <0 15 0x4>;
-

Why do you insist on removing all line spacings from the DTS file?

I saw you removing them in between nodes too.

Quoted 31 lines
arch/arm/boot/dts/dbx5x0.dtsi +0 -3
 			v-ape-supply = <&db8500_vape_reg>;
-			status = "disabled";
 		};
 
 		hash at a03c2000 {
 			compatible = "stericsson,ux500-hash";
 			reg = <0xa03c2000 0x1000>;
-
 			v-ape-supply = <&db8500_vape_reg>;
-			status = "disabled";
 		};
 	};
 };
arch/arm/boot/dts/snowball.dts +0 -8
index bda002f..e8219cc7 100644
@@ -356,13 +356,5 @@
 				};
 			};
 		};
-
-		cryp at a03cb000 {
-			status = "okay";
-		};
-
-		hash at a03c2000 {
-			status = "okay";
-		};
 	};
 };
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw

PATCH 1/1 ARM: ux500: enable the crypto and hash on all dbx500

Quoted 36 lines · Lee Jones
Quoted 28 lines · Linus Walleij

From: Linus Walleij <[email protected]>

Commits:
"ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" "ARM: ux500: Add Device Tree nodes for the ux500 Hash device"

Added the crypto and hash devices conditionally, i.e. so as to be turned on per-board by setting an "status" property on the device from "disabled" to "okay" on each device.

This is wrong since this is an SoC feature, it is not board dependent. It is the same ASIC under all circumstances and functionality does not vary with board family.

This moves the enablement into the SoC file.

---
 arch/arm/boot/dts/dbx5x0.dtsi  | 4 ----
 arch/arm/boot/dts/snowball.dts | 8 --------
 2 files changed, 12 deletions(-)
arch/arm/boot/dts/dbx5x0.dtsi +0 -0
index f051963..cd5cd09 100644

arch/arm/boot/dts/dbx5x0.dtsi line 763

Quoted 4 lines
arch/arm/boot/dts/dbx5x0.dtsi +0 -1
@@ -760,17 +760,13 @@
                      compatible = "stericsson,ux500-cryp";
                      reg = <0xa03cb000 0x1000>;
                      interrupts = <0 15 0x4>;
-

Why do you insist on removing all line spacings from the DTS file?

Quoted 1 line

I saw you removing them in between nodes too.

I was hit by a linespace when I was a child, since then I take every opportunity for revenge.

If I keep the spacing, can I have your ACK?

Yours,
Linus Walleij

#3 lore raw

PATCH 1/1 ARM: ux500: enable the crypto and hash on all dbx500

Quoted 37 lines · Linus Walleij
Quoted 36 lines · Lee Jones
Quoted 28 lines · Linus Walleij

From: Linus Walleij <[email protected]>

Commits:
"ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" "ARM: ux500: Add Device Tree nodes for the ux500 Hash device"

Added the crypto and hash devices conditionally, i.e. so as to be turned on per-board by setting an "status" property on the device from "disabled" to "okay" on each device.

This is wrong since this is an SoC feature, it is not board dependent. It is the same ASIC under all circumstances and functionality does not vary with board family.

This moves the enablement into the SoC file.

---
 arch/arm/boot/dts/dbx5x0.dtsi  | 4 ----
 arch/arm/boot/dts/snowball.dts | 8 --------
 2 files changed, 12 deletions(-)
arch/arm/boot/dts/dbx5x0.dtsi +0 -0
index f051963..cd5cd09 100644

arch/arm/boot/dts/dbx5x0.dtsi line 763

Quoted 4 lines
arch/arm/boot/dts/dbx5x0.dtsi +0 -1
@@ -760,17 +760,13 @@
                      compatible = "stericsson,ux500-cryp";
                      reg = <0xa03cb000 0x1000>;
                      interrupts = <0 15 0x4>;
-

Why do you insist on removing all line spacings from the DTS file?

Quoted 4 lines
Quoted 1 line

I saw you removing them in between nodes too.

I was hit by a linespace when I was a child, since then I take every opportunity for revenge.

:)

Quoted 1 line

If I keep the spacing, can I have your ACK?

You can.

For reference, I like a space separating all nodes too. :)

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog