watchdog: riowd: use platform_{get,set}_drvdata()
PATCH 4/5 watchdog: riowd: use platform_{get,set}_drvdata()
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/watchdog/riowd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/watchdog/riowd.c +2 -2
@@ -206,7 +206,7 @@ static int riowd_probe(struct platform_device *op)pr_info ("Hardware watchdog [%i minutes], regs at %p\n" , riowd_timeout, p->regs); -dev_set_drvdata (&op->dev, p); +platform_set_drvdata (op, p);return 0 ; out_iounmap:
@@ -222,7 +222,7 @@ out:static int riowd_remove (struct platform_device *op) { -struct riowd *p =dev_get_drvdata (&op->dev); +struct riowd *p =platform_get_drvdata (op);misc_deregister (&riowd_miscdev);of_iounmap (&op->resource[0 ], p->regs,2 );
Signature · 1 line
1.7.10.4
Quoted 5 lines · Jingoo Han
Use the wrapper functions for getting and setting the driver data using
platform_deviceinstead of using dev_{get,set}_drvdata() with&pdev->dev, so we can directly pass a structplatform_device.Signed-off-by Jingoo Han <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 31 lines
--- drivers/watchdog/riowd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/watchdog/riowd.c +2
-2@@ -206,7 +206,7 @@ static int riowd_probe(struct platform_device *op)pr_info ("Hardware watchdog [%i minutes], regs at %p\n" , riowd_timeout, p->regs); -dev_set_drvdata (&op->dev, p); +platform_set_drvdata (op, p);return 0 ; out_iounmap:@@ -222,7 +222,7 @@ out:static int riowd_remove (struct platform_device *op) { -struct riowd *p =dev_get_drvdata (&op->dev); +struct riowd *p =platform_get_drvdata (op);misc_deregister (&riowd_miscdev);of_iounmap (&op->resource[0 ], p->regs,2 );Signature · 1 line
1.7.10.4
Hi Jingoo,
Quoted 9 lines
Use the wrapper functions for getting and setting the driver data using
platform_deviceinstead of using dev_{get,set}_drvdata() with&pdev->dev, so we can directly pass a structplatform_device.Signed-off-by Jingoo Han <[email protected]>--- drivers/watchdog/riowd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch added to linux-watchdog-next.
Kind regards,
Wim.