misc/ep93xx_pwm: cleanup driver for conversion to PWM framework
cover misc/ep93xx_pwm: cleanup driver for conversion to PWM framework
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions misc/ep93xx_pwm: remove ep93xx_pwm_write_tc() inline function misc/ep93xx_pwm: remove ep93xx_pwm_write_dc() inline function misc/ep93xx_pwm: remove ep93xx_pwm_enable() inline function misc/ep93xx_pwm: remove ep93xx_pwm_disable() inline function misc/ep93xx_pwm: remove ep93xx_pwm_invert() inline function misc/ep93xx_pwm: remove ep93xx_pwm_normal() inline function misc/ep93xx_pwm: remove ep93xx_pwm_read_tc() inline function misc/ep93xx_pwm: remove ep93xx_pwm_is_enabled() inline function misc/ep93xx_pwm: remove ep93xx_pwm_is_inverted() inline function misc/ep93xx_pwm: use module_platform_driver() misc/ep93xx_pwm: use kstrtol instead of strict_strtol
drivers/misc/ep93xx_pwm.c | 187 +++++++++++++--------------------------------- 1 file changed, 50 insertions(+), 137 deletions(-)
Signature · 1 line
1.8.1.4
Quoted 20 lines · H Hartley Sweeten
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions misc/ep93xx_pwm: removeep93xx_pwm_write_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_write_dc()inline function misc/ep93xx_pwm: removeep93xx_pwm_enable()inline function misc/ep93xx_pwm: removeep93xx_pwm_disable()inline function misc/ep93xx_pwm: removeep93xx_pwm_invert()inline function misc/ep93xx_pwm: removeep93xx_pwm_normal()inline function misc/ep93xx_pwm: removeep93xx_pwm_read_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_enabled()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_inverted()inline function misc/ep93xx_pwm: usemodule_platform_driver()misc/ep93xx_pwm: use kstrtol instead ofstrict_strtol
Quoted 3 lines
drivers/misc/ep93xx_pwm.c | 187 +++++++++++++--------------------------------- 1 file changed, 50 insertions(+), 137 deletions(-)
Series looks fine to me.
~Ryan
Quoted 4 lines · H Hartley Sweeten
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
Quoted 15 lines
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions misc/ep93xx_pwm: removeep93xx_pwm_write_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_write_dc()inline function misc/ep93xx_pwm: removeep93xx_pwm_enable()inline function misc/ep93xx_pwm: removeep93xx_pwm_disable()inline function misc/ep93xx_pwm: removeep93xx_pwm_invert()inline function misc/ep93xx_pwm: removeep93xx_pwm_normal()inline function misc/ep93xx_pwm: removeep93xx_pwm_read_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_enabled()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_inverted()inline function misc/ep93xx_pwm: usemodule_platform_driver()misc/ep93xx_pwm: use kstrtol instead ofstrict_strtol
Whole series:
with or without my suggested change, your choice.
Quoted 21 lines · Arnd Bergmann
Quoted 4 lines · H Hartley Sweeten
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
Quoted 15 lines
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions misc/ep93xx_pwm: removeep93xx_pwm_write_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_write_dc()inline function misc/ep93xx_pwm: removeep93xx_pwm_enable()inline function misc/ep93xx_pwm: removeep93xx_pwm_disable()inline function misc/ep93xx_pwm: removeep93xx_pwm_invert()inline function misc/ep93xx_pwm: removeep93xx_pwm_normal()inline function misc/ep93xx_pwm: removeep93xx_pwm_read_tc()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_enabled()inline function misc/ep93xx_pwm: removeep93xx_pwm_is_inverted()inline function misc/ep93xx_pwm: usemodule_platform_driver()misc/ep93xx_pwm: use kstrtol instead ofstrict_strtol
Quoted 3 lines
Whole series:
Acked-by Arnd Bergmann [email protected]
Arnd,
Ryan Mallon has also provided a Reviewed-by for this series.
Will you be the one that merges this? I would like it to be in linux-next before I convert it to the PWM framework.
Also, I have a question about the conversion.
If I strip the sysfs support out of this driver the conversion is quite simple. But, my use for this driver requires user space control of the PWM.
Should I:
1) convert the driver to the PWM framework and leave the sysfs stuff in it
2) work out a generic sysfs support for the PWM framework and then convert the driver
3) other...
I've been looking at 2) by doing something like how gpiolib does it. Do you think that would be acceptable?
Thanks,
Hartley
Quoted 4 lines · H Hartley Sweeten
Ryan Mallon has also provided a Reviewed-by for this series.
Will you be the one that merges this? I would like it to be in linux-next before I convert it to the PWM framework.
While Greg and I are both maintainers for drivers/misc, he is the one who actually has a git tree for it, so he would merge it.
However, I think it would be better to just merge it all through the pwm tree. Your current series is good, and with my Ack I see no problem to just do the conversion to pwm on top and send a pull request for all of it to Thierry.
Quoted 5 lines
Also, I have a question about the conversion.
If I strip the sysfs support out of this driver the conversion is quite simple. But, my use for this driver requires user space control of the PWM.
Quoted 8 lines
Should I:
1) convert the driver to the PWM framework and leave the sysfs stuff in it
2) work out a generic sysfs support for the PWM framework and then convert the driver
3) other...I've been looking at 2) by doing something like how gpiolib does it. Do you think that would be acceptable?
That would be for Thierry to decide. It does sound better to me than the 1) and I don't have a better idea for 3).
I wonder how the arbitration between in-kernel and user-space consumers of the pwm lines would work though.
Arnd
Quoted 6 lines · Arnd Bergmann
Quoted 4 lines · H Hartley Sweeten
Ryan Mallon has also provided a Reviewed-by for this series.
Will you be the one that merges this? I would like it to be in linux-next before I convert it to the PWM framework.
Quoted 7 lines
While Greg and I are both maintainers for
drivers/misc, he is the one who actually has a git tree for it, so he would merge it.However, I think it would be better to just merge it all through the pwm tree. Your current series is good, and with my Ack I see no problem to just do the conversion to pwm on top and send a pull request for all of it to Thierry.
While I have no objection to taking the patches through the PWM tree, I prefer to pick up patches from my inbox. I should probably get used to taking pull requests to make my life easier, but there was never a need so far. So if you'll be pushing the series to a tree anyway I can take a look at it and see if I feel comfortable pulling, but I'd still want to see the full series as patches for easier review.
Quoted 11 lines
Quoted 11 lines
Also, I have a question about the conversion.
If I strip the sysfs support out of this driver the conversion is quite simple. But, my use for this driver requires user space control of the PWM.
Should I:
1) convert the driver to the PWM framework and leave the sysfs stuff in it
2) work out a generic sysfs support for the PWM framework and then convert the driver
3) other...
Quoted 8 lines
Quoted 2 lines
I've been looking at 2) by doing something like how gpiolib does it. Do you think that would be acceptable?
That would be for Thierry to decide. It does sound better to me than the 1) and I don't have a better idea for 3).
I wonder how the arbitration between in-kernel and user-space consumers of the pwm lines would work though.
I've added Lars Poeschel on Cc, who's done some work on a sysfs interface for the PWM subsystem already. It's undergone some review already[0] and I think he's working on a v2 now.
Thierry
Quoted 26 lines · Thierry Reding
Quoted 16 lines · Arnd Bergmann
Quoted 15 lines · H Hartley Sweeten
Also, I have a question about the conversion.
If I strip the sysfs support out of this driver the conversion is quite simple. But, my use for this driver requires user space control of the PWM.
Should I:
1) convert the driver to the PWM framework and leave the sysfs stuff in it 2) work out a generic sysfs support for the PWM framework and thenconvert the driver
3) other...
Quoted 8 lines
Quoted 2 lines
I've been looking at 2) by doing something like how gpiolib does it. Do you think that would be acceptable?
That would be for Thierry to decide. It does sound better to me than the 1) and I don't have a better idea for 3).
I wonder how the arbitration between in-kernel and user-space consumers of the pwm lines would work though.
Quoted 7 lines
I've added Lars Poeschel on Cc, who's done some work on a sysfs interface for the PWM subsystem already. It's undergone some review already[0] and I think he's working on a v2 now.
Thierry
I currently do not have the time to work on a v2 of the pwm sysfs patch but I will do it as soon as possible - if not someone else will do. Unfortunately my current involvements in other project will not allow me to do so for at least next two months.
I received some off-list reactions to my patches from users asking for pwm sysfs, so there is definitely a need for it!
If you decide to take attempt 2) (which is preferable) I recommend you to take a look at what I have done and Thierrys review comments. I took the gpiolib way and the result got rejected for very good reasons.
Regards,
Lars
Quoted 9 lines · Lars Poeschel
Quoted 7 lines · Thierry Reding
I've added Lars Poeschel on Cc, who's done some work on a sysfs interface for the PWM subsystem already. It's undergone some review already[0] and I think he's working on a v2 now.
Thierry
Quoted 9 lines
I currently do not have the time to work on a v2 of the pwm sysfs patch but I will do it as soon as possible - if not someone else will do. Unfortunately my current involvements in other project will not allow me to do so for at least next two months.
I received some off-list reactions to my patches from users asking for pwm sysfs, so there is definitely a need for it!
If you decide to take attempt 2) (which is preferable) I recommend you to take a look at what I have done and Thierrys review comments. I took the gpiolib way and the result got rejected for very good reasons.
I just posted a PWM sysfs interface patch based on the previous work by Lars. Hopefully I addressed all of Thierrys review comments.
I still need to add the Documentation and the ABI doc for the sysfs but I want to make sure the interface looks acceptable.
I also spotted a couple checkpatch.pl issues after I posted the patch. These are already fixed for v2.
Thanks,
Hartley
Quoted 20 lines · H Hartley Sweeten
Quoted 9 lines · Lars Poeschel
Quoted 7 lines · Thierry Reding
I've added Lars Poeschel on Cc, who's done some work on a sysfs interface for the PWM subsystem already. It's undergone some review already[0] and I think he's working on a v2 now.
Thierry
Quoted 9 lines
I currently do not have the time to work on a v2 of the pwm sysfs patch but I will do it as soon as possible - if not someone else will do. Unfortunately my current involvements in other project will not allow me to do so for at least next two months.
I received some off-list reactions to my patches from users asking for pwm sysfs, so there is definitely a need for it!
If you decide to take attempt 2) (which is preferable) I recommend you to take a look at what I have done and Thierrys review comments. I took the gpiolib way and the result got rejected for very good reasons.
Quoted 2 lines
I just posted a PWM sysfs interface patch based on the previous work by Lars. Hopefully I addressed all of Thierrys review comments.
I can't find it anywhere. Maybe you used my @avionic-design.de email address? Could you please repost using the @gmail.com address, as I have only unreliable access to the other one ATM. And please also Cc the all new [email protected] mailing list.
Thanks,
Thierry