Skip to contentSkip to conversation

ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

PATCH New Kevin Hilman 4 participants 18 messages May 24, 2013 – May 29, 2013 1 message not in the archive Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +8 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&mcbsp1_pins
@@ -66,6 +67,13 @@
 			&tpd12s015_pins
 	>;
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
arch/arm/boot/dts/omap4-sdp.dts +8 -0
index a35d9cd..5ad0c10 100644
@@ -145,6 +145,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&dmic_pins
@@ -179,6 +180,13 @@
 		>;
 	};
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
Signature · 1 line
1.8.2
#1 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
 			&tpd12s015_pins
 	>;
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Why are we setting mode 0(clk out) here?

Quoted 39 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
arch/arm/boot/dts/omap4-sdp.dts +8 -0
index a35d9cd..5ad0c10 100644
@@ -145,6 +145,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&dmic_pins
@@ -179,6 +180,13 @@
 		>;
 	};
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
Signature · 6 lines
1.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 59 lines · Nishanth Menon
Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
 			&tpd12s015_pins
 	>;
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Quoted 1 line

Why are we setting mode 0(clk out) here?

I did a bit more research into this:
MSECURE line needs to be set for us to set anything with TWL6030 RTC. PandaBoard ES(4460) = this is on OMAP PIN AD4
PandaBoard (4430) = this is on OMAP PIN AD2

translating this back,
PandaBoard ES OMAp4460 pin AD4:
FREF_CLK3_OUT/FREF_CLK2_REQ/SYS_SECURE_INDICATOR/GPIO_WK31/C2C_WAKEREQOUT/SDMMC2_DAT5/ATTILA_HW_DBG8/SAFE_MODE This is at register 0x4A31E054(higher 16 bits) - however since we are GP device, SYS_SECURE_INDICATOR(mode 2) is reserved.
PandaBoard OMAP4430 pin AD2:
FREF_CLK0_OUT/FREF_CLK1_REQ/SYS_DRM_MSECURE/GPIO_WK6/SDMMC2_DAT7/ATTILA_HW_DBG6/SAFE_MOD This is at register 0x4A31E054(lower 16 bits) - however since we are GP device, SYS_DRM_MSECURE(mode 2) is reserved.

To use RTC, we will have to use GPIO.
on pandaboard ES, we need GPIO31 and PandaBoard, 6.

Further the pinctrl offsets will vary as well between the same.

IMHO, we need GPIO support and pinmux appropritate to the same to allow RTC to work.

Quoted 47 lines
Quoted 39 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
arch/arm/boot/dts/omap4-sdp.dts +8 -0
index a35d9cd..5ad0c10 100644
@@ -145,6 +145,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&dmic_pins
@@ -179,6 +180,13 @@
 		>;
 	};
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */
+		>;
+	};
+
 	twl6040_pins: pinmux_twl6040_pins {
 		pinctrl-single,pins = <
 			0xe0 0x3	/* hdq_sio.gpio_127 OUTPUT | MODE3 */
Signature · 6 lines
1.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 6 lines
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Regards,
Nishanth Menon
#3 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 60 lines · Nishanth Menon
Quoted 59 lines · Nishanth Menon
Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
 	pinctrl-names = "default";
 	pinctrl-0 = <
+			&twl6030_pins
 			&twl6040_pins
 			&mcpdm_pins
 			&mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
 			&tpd12s015_pins
 	>;
 
+	twl6030_pins: pinmux_twl6030_pins {
+		pinctrl-single,pins = <
+			0x15e 0x4118	/* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+			0x14 0x0	/* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Quoted 4 lines
Quoted 1 line

Why are we setting mode 0(clk out) here?

I did a bit more research into this:
MSECURE line needs to be set for us to set anything with TWL6030 RTC.

Yes, the commit referenced in the changelog described that in detail.

Quoted 13 lines

PandaBoard ES(4460) = this is on OMAP PIN AD4
PandaBoard (4430) = this is on OMAP PIN AD2

translating this back,
PandaBoard ES OMAp4460 pin AD4:
FREF_CLK3_OUT/FREF_CLK2_REQ/SYS_SECURE_INDICATOR/GPIO_WK31/C2C_WAKEREQOUT/SDMMC2_DAT5/ATTILA_HW_DBG8/SAFE_MODE This is at register 0x4A31E054(higher 16 bits) - however since we are GP device, SYS_SECURE_INDICATOR(mode 2) is reserved.
PandaBoard OMAP4430 pin AD2:
FREF_CLK0_OUT/FREF_CLK1_REQ/SYS_DRM_MSECURE/GPIO_WK6/SDMMC2_DAT7/ATTILA_HW_DBG6/SAFE_MOD This is at register 0x4A31E054(lower 16 bits) - however since we are GP device, SYS_DRM_MSECURE(mode 2) is reserved.

Quoted 7 lines

To use RTC, we will have to use GPIO.
on pandaboard ES, we need GPIO31 and PandaBoard, 6.

Further the pinctrl offsets will vary as well between the same.

IMHO, we need GPIO support and pinmux appropritate to the same to allow RTC to work.

I don't follow at all what you're trying to say. The current settings are working fine and have been tested on both 4430/Panda and 4460/Panda-ES.

The goal of this patch is to make default mux settings for twl6030 for DT boot match current legacy boot in mainline.

The commits referenced in the changelog setup some default muxing for twl6030 (see changelogs referenced and mux calls in twl-common.c:omap4_pmic_init())

Without those mux settings, RTC wakeup on legacy boot does not work (tested on 4430/panda, 4460/Panda with recent u-boot v2013.04 where most of the old mux setup is gone.) With those settings, RTC wakeup works.

Yes, the TRM has some mode bits marked as reserved, but that doesn't mean they don't work. It just means the documentation is squirreled away in the secure TRM addendum.

Kevin

#4 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 100 lines · Kevin Hilman
Quoted 60 lines · Nishanth Menon
Quoted 59 lines · Nishanth Menon
Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
   pinctrl-names = "default";
   pinctrl-0 = <
+                  &twl6030_pins
                   &twl6040_pins
                   &mcpdm_pins
                   &mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
                   &tpd12s015_pins
   >;
 
+  twl6030_pins: pinmux_twl6030_pins {
+          pinctrl-single,pins = <
+                  0x15e 0x4118    /* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+                  0x14 0x0        /* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Quoted 4 lines
Quoted 1 line

Why are we setting mode 0(clk out) here?

I did a bit more research into this:
MSECURE line needs to be set for us to set anything with TWL6030 RTC.

Yes, the commit referenced in the changelog described that in detail.

Quoted 13 lines

PandaBoard ES(4460) = this is on OMAP PIN AD4
PandaBoard (4430) = this is on OMAP PIN AD2

translating this back,
PandaBoard ES OMAp4460 pin AD4:
FREF_CLK3_OUT/FREF_CLK2_REQ/SYS_SECURE_INDICATOR/GPIO_WK31/C2C_WAKEREQOUT/SDMMC2_DAT5/ATTILA_HW_DBG8/SAFE_MODE This is at register 0x4A31E054(higher 16 bits) - however since we are GP device, SYS_SECURE_INDICATOR(mode 2) is reserved.
PandaBoard OMAP4430 pin AD2:
FREF_CLK0_OUT/FREF_CLK1_REQ/SYS_DRM_MSECURE/GPIO_WK6/SDMMC2_DAT7/ATTILA_HW_DBG6/SAFE_MOD This is at register 0x4A31E054(lower 16 bits) - however since we are GP device, SYS_DRM_MSECURE(mode 2) is reserved.

Quoted 7 lines

To use RTC, we will have to use GPIO.
on pandaboard ES, we need GPIO31 and PandaBoard, 6.

Further the pinctrl offsets will vary as well between the same.

IMHO, we need GPIO support and pinmux appropritate to the same to allow RTC to work.

I don't follow at all what you're trying to say. The current settings are working fine and have been tested on both 4430/Panda and 4460/Panda-ES.

The goal of this patch is to make default mux settings for twl6030 for DT boot match current legacy boot in mainline.

The commits referenced in the changelog setup some default muxing for twl6030 (see changelogs referenced and mux calls in twl-common.c:omap4_pmic_init())

Quoted 8 lines

Without those mux settings, RTC wakeup on legacy boot does not work (tested on 4430/panda, 4460/Panda with recent u-boot v2013.04 where most of the old mux setup is gone.) With those settings, RTC wakeup works.

Yes, the TRM has some mode bits marked as reserved, but that doesn't mean they don't work. It just means the documentation is squirreled away in the secure TRM addendum.

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?
b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Regards,
Nishanth Menon

#5 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 105 lines · Nishanth Menon
Quoted 104 lines · Kevin Hilman
Quoted 60 lines · Nishanth Menon
Quoted 59 lines · Nishanth Menon
Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

 arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
 arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
 2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
 &omap4_pmx_core {
   pinctrl-names = "default";
   pinctrl-0 = <
+                  &twl6030_pins
                   &twl6040_pins
                   &mcpdm_pins
                   &mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
                   &tpd12s015_pins
   >;
 
+  twl6030_pins: pinmux_twl6030_pins {
+          pinctrl-single,pins = <
+                  0x15e 0x4118    /* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+                  0x14 0x0        /* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Quoted 4 lines
Quoted 1 line

Why are we setting mode 0(clk out) here?

I did a bit more research into this:
MSECURE line needs to be set for us to set anything with TWL6030 RTC.

Yes, the commit referenced in the changelog described that in detail.

Quoted 13 lines

PandaBoard ES(4460) = this is on OMAP PIN AD4
PandaBoard (4430) = this is on OMAP PIN AD2

translating this back,
PandaBoard ES OMAp4460 pin AD4:
FREF_CLK3_OUT/FREF_CLK2_REQ/SYS_SECURE_INDICATOR/GPIO_WK31/C2C_WAKEREQOUT/SDMMC2_DAT5/ATTILA_HW_DBG8/SAFE_MODE This is at register 0x4A31E054(higher 16 bits) - however since we are GP device, SYS_SECURE_INDICATOR(mode 2) is reserved.
PandaBoard OMAP4430 pin AD2:
FREF_CLK0_OUT/FREF_CLK1_REQ/SYS_DRM_MSECURE/GPIO_WK6/SDMMC2_DAT7/ATTILA_HW_DBG6/SAFE_MOD This is at register 0x4A31E054(lower 16 bits) - however since we are GP device, SYS_DRM_MSECURE(mode 2) is reserved.

Quoted 7 lines

To use RTC, we will have to use GPIO.
on pandaboard ES, we need GPIO31 and PandaBoard, 6.

Further the pinctrl offsets will vary as well between the same.

IMHO, we need GPIO support and pinmux appropritate to the same to allow RTC to work.

I don't follow at all what you're trying to say. The current settings are working fine and have been tested on both 4430/Panda and 4460/Panda-ES.

The goal of this patch is to make default mux settings for twl6030 for DT boot match current legacy boot in mainline.

The commits referenced in the changelog setup some default muxing for twl6030 (see changelogs referenced and mux calls in twl-common.c:omap4_pmic_init())

Without those mux settings, RTC wakeup on legacy boot does not work (tested on 4430/panda, 4460/Panda with recent u-boot v2013.04 where most of the old mux setup is gone.) With those settings, RTC wakeup works.

Quoted 8 lines
Quoted 4 lines

Yes, the TRM has some mode bits marked as reserved, but that doesn't mean they don't work. It just means the documentation is squirreled away in the secure TRM addendum.

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Yet another thing wrong with my patch: the fref_clk0 pad is in the WKUP padconf section, and I put it at offset 0x14 in the CORE section, which is yet another wrong place.

Let me respin this after some more doc reading.

Thanks for the detailed review,

Kevin

#6 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 14 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

	omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Kevin

#7 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 32 lines · Kevin Hilman
Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 14 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

        omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Quoted 8 lines

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Schematics are public for PandaBoard ES and PandaBoard - as you can see from that the registers connected are definitely different.

The control pad information should be present in public TRM as well - the "secure" angle was public, but in this case, it does not really matter.

Regards,
Nishanth Menon

#8 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 37 lines · Nishanth Menon
Quoted 36 lines · Kevin Hilman
Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 14 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

        omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

Quoted 6 lines
Quoted 4 lines

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Schematics are public for PandaBoard ES and PandaBoard - as you can see from that the registers connected are definitely different.

What I see from both schematics is that SYS_DRM_MSECURE is available on a few different pads, but on both 4430 and 4460, one of the places is in mode 2 of FREF_CLK0_OUT, which is at offset 0x54 on both SoCs.

Based on that reading, and the fact that not correctly muxing that pad to mode 2 on *both* 4430 and 4460 makes the RTC work, I'm rather convinced that the offset should be the same for 4430 and 4460.

What am I missing?

Kevin

#9 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 45 lines · Kevin Hilman
Quoted 33 lines · Nishanth Menon
Quoted 32 lines · Kevin Hilman
Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 12 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

         omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

Quoted 6 lines
Quoted 4 lines

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Schematics are public for PandaBoard ES and PandaBoard - as you can see from that the registers connected are definitely different.

What I see from both schematics is that SYS_DRM_MSECURE is available on a few different pads, but on both 4430 and 4460, one of the places is in mode 2 of FREF_CLK0_OUT, which is at offset 0x54 on both SoCs.

Quoted 5 lines

Based on that reading, and the fact that not correctly muxing that pad to mode 2 on *both* 4430 and 4460 makes the RTC work, I'm rather convinced that the offset should be the same for 4430 and 4460.

What am I missing?

Hi Kevin,

I've rechecked it too.

According to:
Panda ES:
http://pandaboard.org/sites/default/files/board_reference/ES/750-2170-002-sch_revb.pdf
Panda:
http://pandaboard.org/sites/default/files/board_reference/pandaboard-a/panda-a-schematic.pdf

AD2 (FREF_CLK0_OUT) is used for on both boards as H_SYS_DRM_MSEC - so, valid offset is 0x14 CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ lowest 16 bit

FYI: in Android K3.0 and K3.4 this pin configured to "gpio_wk6" as following

     omap_mux_init_signal("fref_clk0_out.gpio_wk6", OMAP_PIN_OUTPUT);
     gpio_request(6, "msecure");
     gpio_direction_output(6, 1);

http://git.omapzoom.org/?p=kernel/omap.git;a=commit;h=262669aebf4af4044a25e8292f0e27986e18445a

Regards,
Grygorii

Quoted 6 lines

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#10 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 46 lines · Grygorii Strashko
Quoted 45 lines · Kevin Hilman
Quoted 33 lines · Nishanth Menon
Quoted 32 lines · Kevin Hilman
Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 12 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

         omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

Quoted 6 lines
Quoted 4 lines

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Schematics are public for PandaBoard ES and PandaBoard - as you can see from that the registers connected are definitely different.

What I see from both schematics is that SYS_DRM_MSECURE is available on a few different pads, but on both 4430 and 4460, one of the places is in mode 2 of FREF_CLK0_OUT, which is at offset 0x54 on both SoCs.

Quoted 8 lines
Quoted 5 lines

Based on that reading, and the fact that not correctly muxing that pad to mode 2 on *both* 4430 and 4460 makes the RTC work, I'm rather convinced that the offset should be the same for 4430 and 4460.

What am I missing?

Hi Kevin,

I've rechecked it too.

Thanks for checking, I'll take this as an Acked-by.

Kevin

#11 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

In reply to Kevin Hilman

Salut Kevin,

Quoted 50 lines · Kevin Hilman
Quoted 37 lines · Nishanth Menon
Quoted 36 lines · Kevin Hilman
Quoted 1 line · Kevin Hilman

Nishanth Menon <[email protected]> writes:

[...]

Quoted 14 lines
Quoted 4 lines

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Quoted 3 lines

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Actually, for legacy mode, it's set correctly in mode 2. This line:

         omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT);

does the right thing based on the signal name. But for DT boot, I
defintely screwed it up by setting it to mode (and putting it in the wrong padconf section.)

Also, are you *really* sure about the offset difference between 4430 and 4460 here? I don't have access to NDA docs anymore, so I cannot double check this.

Quoted 6 lines
Quoted 4 lines

What I do know is that the legacy code is using 0x54 for both, and if I simply comment out that 'sys_drm_msecure' line above, RTC wake stops working (legacy boot) on both 4430 and 4460, so that seems like pretty stront evidence that it's the same offset on both.

Schematics are public for PandaBoard ES and PandaBoard - as you can see from that the registers connected are definitely different.

What I see from both schematics is that SYS_DRM_MSECURE is available on a few different pads, but on both 4430 and 4460, one of the places is in mode 2 of FREF_CLK0_OUT, which is at offset 0x54 on both SoCs.

Quoted 5 lines

Based on that reading, and the fact that not correctly muxing that pad to mode 2 on *both* 4430 and 4460 makes the RTC work, I'm rather convinced that the offset should be the same for 4430 and 4460.

What am I missing?

I've just checked both specs and schematics and in the two cases the exact same ball (AD2) is connected to the exact same signal (mod2=sys_drm_msecure) and the registers offset inside the control_module are the same as well.

Nishanth,
AD4 ball in both cases is used for USBB1_PHY_REFCLK signal.

Thanks,
Benoit

#12 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

In reply to Kevin Hilman
Quoted 129 lines · Kevin Hilman
Quoted 105 lines · Nishanth Menon
Quoted 104 lines · Kevin Hilman
Quoted 60 lines · Nishanth Menon
Quoted 59 lines · Nishanth Menon
Quoted 30 lines · Kevin Hilman

Earlier commits ensured proper muxing of pins related to proper TWL6030 behavior: see commit 265a2bc8 (ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled) and commit 1ef43369 (ARM:
OMAP4: TWL: mux sys_drm_msecure as output for PMIC).

However these only fixed legacy boot and not DT boot. For DT boot, the default mux values need to be set properly in DT.

---
Applies on v3.10-rc2

  arch/arm/boot/dts/omap4-panda-common.dtsi | 8 ++++++++
  arch/arm/boot/dts/omap4-sdp.dts           | 8 ++++++++
  2 files changed, 16 insertions(+)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
index 03bd60d..a7a9bc0 100644
@@ -59,6 +59,7 @@
  &omap4_pmx_core {
    pinctrl-names = "default";
    pinctrl-0 = <
+                  &twl6030_pins
                    &twl6040_pins
                    &mcpdm_pins
                    &mcbsp1_pins

arch/arm/boot/dts/omap4-panda-common.dtsi line 72

Quoted 6 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +3 -0
@@ -66,6 +67,13 @@
                    &tpd12s015_pins
    >;
 
+  twl6030_pins: pinmux_twl6030_pins {
+          pinctrl-single,pins = <
+                  0x15e 0x4118    /* sys_nirq1.sys_nirq1 OMAP_WAKEUP_EN | INPUT_PULLUP | MODE0 */

I can understand this - IRQ request comes here.
verified on OMAP4460 Panda-ES.

# omapconf read 0x4A10019C
4118011B

arch/arm/boot/dts/omap4-panda-common.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -0
+                  0x14 0x0        /* fref_clk0_out.sys_drm_msecure OUTPUT */

I do not understand this.
OMAP4460 TRM:
Register: CONTROL_WKUP_PAD0_FREF_CLK0_OUT_PAD1_FREF_CLK3_REQ omapconf read 0x4A31E054
010F010F

I do not understand this configuration. mux modes for FREF_CLK0_OUT_MUXMODE:
0x0: Select fref_clk0_out
0x1: Select fref_clk1_req
0x2: Reserved
0x3: Select gpio_wk6
0x5: Select sdmmc2_dat7
0x6: Select hw_dbg6
0x7: Select safe_mode

Quoted 4 lines
Quoted 1 line

Why are we setting mode 0(clk out) here?

I did a bit more research into this:
MSECURE line needs to be set for us to set anything with TWL6030 RTC.

Yes, the commit referenced in the changelog described that in detail.

Quoted 13 lines

PandaBoard ES(4460) = this is on OMAP PIN AD4
PandaBoard (4430) = this is on OMAP PIN AD2

translating this back,
PandaBoard ES OMAp4460 pin AD4:
FREF_CLK3_OUT/FREF_CLK2_REQ/SYS_SECURE_INDICATOR/GPIO_WK31/C2C_WAKEREQOUT/SDMMC2_DAT5/ATTILA_HW_DBG8/SAFE_MODE This is at register 0x4A31E054(higher 16 bits) - however since we are GP device, SYS_SECURE_INDICATOR(mode 2) is reserved.
PandaBoard OMAP4430 pin AD2:
FREF_CLK0_OUT/FREF_CLK1_REQ/SYS_DRM_MSECURE/GPIO_WK6/SDMMC2_DAT7/ATTILA_HW_DBG6/SAFE_MOD This is at register 0x4A31E054(lower 16 bits) - however since we are GP device, SYS_DRM_MSECURE(mode 2) is reserved.

Quoted 7 lines

To use RTC, we will have to use GPIO.
on pandaboard ES, we need GPIO31 and PandaBoard, 6.

Further the pinctrl offsets will vary as well between the same.

IMHO, we need GPIO support and pinmux appropritate to the same to allow RTC to work.

I don't follow at all what you're trying to say. The current settings are working fine and have been tested on both 4430/Panda and 4460/Panda-ES.

The goal of this patch is to make default mux settings for twl6030 for DT boot match current legacy boot in mainline.

The commits referenced in the changelog setup some default muxing for twl6030 (see changelogs referenced and mux calls in twl-common.c:omap4_pmic_init())

Without those mux settings, RTC wakeup on legacy boot does not work (tested on 4430/panda, 4460/Panda with recent u-boot v2013.04 where most of the old mux setup is gone.) With those settings, RTC wakeup works.

Quoted 8 lines
Quoted 4 lines

Yes, the TRM has some mode bits marked as reserved, but that doesn't mean they don't work. It just means the documentation is squirreled away in the secure TRM addendum.

Actually 2 things:

a) patch seems to do the wrong thing for 4460 - 0x18 offset should have been used instead of 0x14 which is correct for 4430?

I see, thanks. I'll double check the TRMs.

Quoted 6 lines

b) yes, I understand, the current settings we did worked, but the mode(0) we are setting to is real weird - we are setting it up for clk0 out - I cant even think why it is even working in the first place :( - is it because we are pumping out sysclkout and as a result we are lucky that msecure is being sampled at the right point by twl6030 allowing rtc access? either way, IMHO, the configuration is wrong.

Ah, yes. Mode zero is definitely wrong. When I did the original patch
for legacy mode, I just duplicated the settings u-boot was using. Guess it's a fluke that it works.

Quoted 5 lines

Yet another thing wrong with my patch: the fref_clk0 pad is in the WKUP padconf section, and I put it at offset 0x14 in the CORE section, which is yet another wrong place.

Let me respin this after some more doc reading.

Did you re-spin it already?

Beside that mode0 typo, it looks good to me.

Thanks,
Benoit

#13 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

"Cousson, Benoit" <[email protected]> writes:

[...]

Quoted 4 lines
Quoted 2 lines

Let me respin this after some more doc reading.

Did you re-spin it already?

Yes, v2 is here.

http://marc.info/?l=linux-omap&m=136944147521955&w=2

It also needed a rework because the fref_clk0_out pin is also in the wkup section of the padconf, not core.

Kevin

#14 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 7 lines · Kevin Hilman

"Cousson, Benoit" <[email protected]> writes:

[...]

Quoted 3 lines
Quoted 2 lines

Let me respin this after some more doc reading.

Quoted 8 lines
Quoted 1 line

Did you re-spin it already?

Yes, v2 is here.

http://marc.info/?l=linux-omap&m=136944147521955&w=2

It also needed a rework because the fref_clk0_out pin is also in the wkup section of the padconf, not core.

OK, I'll wait for the v3 then :-)

Benoit

A message that is not in the archive (sent off-list or not yet received): CAGa+x85ZzfX400eEGmTGPzRiC21S83VRiHYj38cqsJLjDF3L7g@mail.gmail.com

#16 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 21 lines · Kevin Hilman
Quoted 18 lines · On May 29, 2013 8:06 AM, "Cousson, Benoit" <[email protected]…
Quoted 16 lines · Kevin Hilman

"Cousson, Benoit" <b-cousson at ti.com <mailto:[email protected]>> writes:

[...]

Quoted 5 lines
Quoted 2 lines

Let me respin this after some more doc reading.

Did you re-spin it already?

Yes, v2 is here.

http://marc.info/?l=linux-omap&m=136944147521955&w=2

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

It also needed a rework because the fref_clk0_out pin is also in the wkup section of the padconf, not core.

OK, I'll wait for the v3 then :-)

Hmm, why? v2 has the wkup changes included.

Why? Because of my bad understanding of English :-) I understood: It also needs a rework...

Sorry, I'll merge it.

Thanks,
Benoit

#17 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 26 lines · Benoit
Quoted 25 lines · Kevin Hilman
Quoted 22 lines · On May 29, 2013 8:06 AM, "Cousson, Benoit" <[email protected]…
Quoted 18 lines · Kevin Hilman

"Cousson, Benoit" <b-cousson at ti.com <mailto:[email protected]>> writes:

[...]

Quoted 5 lines
Quoted 2 lines

Let me respin this after some more doc reading.

Did you re-spin it already?

Yes, v2 is here.

http://marc.info/?l=linux-omap&m=136944147521955&w=2

It also needed a rework because the fref_clk0_out pin is also in the wkup section of the padconf, not core.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

OK, I'll wait for the v3 then :-)

Hmm, why? v2 has the wkup changes included.

Why? Because of my bad understanding of English :-) I understood: It also needs a rework...

Re-reading, I wasn't terribly clear. Sorry for the confusion.

Quoted 1 line

Sorry, I'll merge it.

I was hoping for an Ack from Nishanth since he had some questions about it, but with the double checking from you and Grygorii, I think it should go in for the -rc cycle. (also, please add an Ack from Grygorii.)

Thanks,

Kevin

#18 lore raw

PATCH 1/1 ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and msecure line

Quoted 36 lines · Kevin Hilman
Quoted 26 lines · Benoit
Quoted 25 lines · Kevin Hilman
Quoted 22 lines · On May 29, 2013 8:06 AM, "Cousson, Benoit" <[email protected]…
Quoted 18 lines · Kevin Hilman

"Cousson, Benoit" <b-cousson at ti.com <mailto:[email protected]>> writes:

[...]

Quoted 5 lines
Quoted 2 lines

Let me respin this after some more doc reading.

Did you re-spin it already?

Yes, v2 is here.

http://marc.info/?l=linux-omap&m=136944147521955&w=2

It also needed a rework because the fref_clk0_out pin is also in the wkup section of the padconf, not core.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

OK, I'll wait for the v3 then :-)

Hmm, why? v2 has the wkup changes included.

Why? Because of my bad understanding of English :-) I understood: It also needs a rework...

Quoted 7 lines

Re-reading, I wasn't terribly clear. Sorry for the confusion.

Quoted 1 line

Sorry, I'll merge it.

I was hoping for an Ack from Nishanth since he had some questions about it, but with the double checking from you and Grygorii, I think it should go in for the -rc cycle. (also, please add an Ack from Grygorii.)

OK, I'll push the fix to Tony ASAP.

Thanks,
Benoit