Skip to contentSkip to conversation

Revert "dependencies: check that SSL certificates are installed"

PATCH New Baruch Siach 4 participants 7 messages May 20, 2013 – May 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

SSL certificates are no always installed in /etc/ssl/certs. For example, on CentOS 5.6 the default OpenSSL certificates directory is /etc/pki/tls/certs, and wget can download using https without any problem.

Moreover, the existence of /etc/ssl/certs does not guarantee the presence of a CA certificates bundle even on Debian. On my current Debian testing installation the openssl package itself creates an empty /etc/ssl/certs directory.

---
 support/dependencies/dependencies.sh |    9 ---------
 1 file changed, 9 deletions(-)
support/dependencies/dependencies.sh +0 -9
index ce4d9e1..0b44c5a 100755
@@ -200,12 +200,3 @@ if ! perl  -e "require Data::Dumper" > /dev/null 2>&1 ; then
     /bin/echo -e "On Debian/Ubuntu distributions, install the 'perl' package."
     exit 1
 fi
-
-# Check that we have the SSL certificates to make https:// downloads
-# work.
-if ! test -d /etc/ssl/certs; then
-    /bin/echo -e "Your system lacks Common CA certificates for SSL."
-    /bin/echo -e "This prevents https:// downloads from succeeding."
-    /bin/echo -e "On Debian/Ubuntu distributions, install 'ca-certificates' package."
-    exit 1
-fi
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

Hi Thomas,

Quoted 6 lines · Baruch Siach

This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

SSL certificates are no always installed in /etc/ssl/certs. For example, on CentOS 5.6 the default OpenSSL certificates directory is /etc/pki/tls/certs, and wget can download using https without any problem.

Quoted 7 lines

Moreover, the existence of /etc/ssl/certs does not guarantee the presence of a CA certificates bundle even on Debian. On my current Debian testing installation the openssl package itself creates an empty /etc/ssl/certs directory.

---

As the author of d66cd067f3, what do you think?

baruch

Quoted 23 lines
 support/dependencies/dependencies.sh |    9 ---------
 1 file changed, 9 deletions(-)
support/dependencies/dependencies.sh +0 -9
index ce4d9e1..0b44c5a 100755
@@ -200,12 +200,3 @@ if ! perl  -e "require Data::Dumper" > /dev/null 2>&1 ; then
     /bin/echo -e "On Debian/Ubuntu distributions, install the 'perl' package."
     exit 1
 fi
-
-# Check that we have the SSL certificates to make https:// downloads
-# work.
-if ! test -d /etc/ssl/certs; then
-    /bin/echo -e "Your system lacks Common CA certificates for SSL."
-    /bin/echo -e "This prevents https:// downloads from succeeding."
-    /bin/echo -e "On Debian/Ubuntu distributions, install 'ca-certificates' package."
-    exit 1
-fi
Signature · 1 line
1.7.10.4
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

Just wanted to chime in say that I can confirm this is a bug on CentOS/RHEL 5 systems.

Spenser

Quoted 53 lines · Baruch Siach

Hi Thomas,

Quoted 6 lines · Baruch Siach

This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

SSL certificates are no always installed in /etc/ssl/certs. For example, on CentOS 5.6 the default OpenSSL certificates directory is /etc/pki/tls/certs, and wget can download using https without any problem.

Quoted 7 lines

Moreover, the existence of /etc/ssl/certs does not guarantee the presence of a CA certificates bundle even on Debian. On my current Debian testing installation the openssl package itself creates an empty /etc/ssl/certs directory.

---

As the author of d66cd067f3, what do you think?

baruch

Quoted 21 lines
 support/dependencies/dependencies.sh |    9 ---------
 1 file changed, 9 deletions(-)
support/dependencies/dependencies.sh +0 -10
index ce4d9e1..0b44c5a 100755
@@ -200,12 +200,3 @@ if ! perl  -e "require Data::Dumper" > /dev/null 2>&1 ; then
     /bin/echo -e "On Debian/Ubuntu distributions, install the 'perl' package."
     exit 1
 fi
-
-# Check that we have the SSL certificates to make https:// downloads
-# work.
-if ! test -d /etc/ssl/certs; then
-    /bin/echo -e "Your system lacks Common CA certificates for SSL."
-    /bin/echo -e "This prevents https:// downloads from succeeding."
-    /bin/echo -e "On Debian/Ubuntu distributions, install 'ca-certificates' package."
-    exit 1
-fi
--
Quoted 2 lines

1.7.10.4

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 3 lines
Spenser Gilliland
Computer Engineer
Doctoral Candidate
#3 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 14 lines · Baruch Siach

Hi Thomas,

Quoted 11 lines · Baruch Siach

This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

SSL certificates are no always installed in /etc/ssl/certs. For example, on CentOS 5.6 the default OpenSSL certificates directory is /etc/pki/tls/certs, and wget can download using https without any problem.

Moreover, the existence of /etc/ssl/certs does not guarantee the presence of a CA certificates bundle even on Debian. On my current Debian testing installation the openssl package itself creates an empty /etc/ssl/certs directory.

Quoted 4 lines
Quoted 2 lines

---

As the author of d66cd067f3, what do you think?

Well, d66cd067f3 was written because if you install a very minimal system, you may not have the SSL certificates installed, which prevents any download from https:// website. So I added a quick check for that.

However, apparently, the location of such certificates is not fixed between various systems, so clearly my patch doesn't work properly.

I see two options here:

(1) Apply your patch, and assume that in most systems, SSL certificates are always installed. The case I had what when you create a very minimal Debian system, but most people probably use a more full-featured system, and it's pretty likely that SSL certificates are already installed.

(2) Replace the test by a test that wget some well-known https:// URL, and if it doesn't work, say that SSL certificates are not available. But I don't like this too much, because this means that at every invocation of 'make', Buildroot will try to download something from the network.

So, for now, I believe option (1) is the only viable one, unless there is some local command that allows to check whether SSL certificates are installed or not.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

Hi Thomas,

Quoted 13 lines · Thomas Petazzoni
Quoted 12 lines · Baruch Siach
Quoted 11 lines · Baruch Siach

This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

SSL certificates are no always installed in /etc/ssl/certs. For example, on CentOS 5.6 the default OpenSSL certificates directory is /etc/pki/tls/certs, and wget can download using https without any problem.

Moreover, the existence of /etc/ssl/certs does not guarantee the presence of a CA certificates bundle even on Debian. On my current Debian testing installation the openssl package itself creates an empty /etc/ssl/certs directory.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

---

As the author of d66cd067f3, what do you think?

Well, d66cd067f3 was written because if you install a very minimal system, you may not have the SSL certificates installed, which prevents any download from https:// website. So I added a quick check for that.

How about adding a config option (disabled by default) that adds --no-check-certificate to the wget command? We may event monitor the wget exit status and advice the user to enable this options when we see the status = 5 (SSL verification failure).

Quoted 2 lines

However, apparently, the location of such certificates is not fixed between various systems, so clearly my patch doesn't work properly.

Well, 'openssl version -d' does give you the default location where OpenSSL expects certificates to be. However, as I said in the commit log, the presence of this directory doesn't necessarily mean that you actually have any certificate in this location. On Debian if you uninstall ca-certificates you'll still have /etc/ssh/certs.

Quoted 14 lines

I see two options here:

(1) Apply your patch, and assume that in most systems, SSL certificates are always installed. The case I had what when you create a very minimal Debian system, but most people probably use a more full-featured system, and it's pretty likely that SSL certificates are already installed.

(2) Replace the test by a test that wget some well-known https:// URL, and if it doesn't work, say that SSL certificates are not available. But I don't like this too much, because this means that at every invocation of 'make', Buildroot will try to download something from the network.

Quoted 3 lines

So, for now, I believe option (1) is the only viable one, unless there is some local command that allows to check whether SSL certificates are installed or not.

So is this an Acked-by from you?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#5 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

Dear Baruch Siach,

Quoted 8 lines · Baruch Siach
Quoted 3 lines

Well, d66cd067f3 was written because if you install a very minimal system, you may not have the SSL certificates installed, which prevents any download from https:// website. So I added a quick check for that.

How about adding a config option (disabled by default) that adds --no-check-certificate to the wget command? We may event monitor the wget exit status and advice the user to enable this options when we see the status = 5 (SSL verification failure).

Hum, I believe it's not very wise to encourage users to use --no-check-certificate.

Quoted 8 lines
Quoted 2 lines

However, apparently, the location of such certificates is not fixed between various systems, so clearly my patch doesn't work properly.

Well, 'openssl version -d' does give you the default location where OpenSSL expects certificates to be. However, as I said in the commit log, the presence of this directory doesn't necessarily mean that you actually have any certificate in this location. On Debian if you uninstall ca-certificates you'll still have /etc/ssh/certs.

Ok.

Quoted 5 lines
Quoted 3 lines

So, for now, I believe option (1) is the only viable one, unless there is some local command that allows to check whether SSL certificates are installed or not.

So is this an Acked-by from you?

Yes:

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 Revert "dependencies: check that SSL certificates are installed"

In reply to Baruch Siach
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Baruch> This reverts commit d66cd067f3dc3d5e2479e1e8c05f24fd82329f7a.

Baruch> SSL certificates are no always installed in /etc/ssl/certs. For Baruch> example, on CentOS 5.6 the default OpenSSL certificates Baruch> directory is /etc/pki/tls/certs, and wget can download using Baruch> https without any problem.

Baruch> Moreover, the existence of /etc/ssl/certs does not guarantee Baruch> the presence of a CA certificates bundle even on Debian. On my Baruch> current Debian testing installation the openssl package itself Baruch> creates an empty /etc/ssl/certs directory.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard