Skip to contentSkip to conversation

ptp_pch: depends on PCI

PATCH In review Kyle McMartin 4 participants 4 messages May 25, 2013 – May 27, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptp_pch: depends on PCI

It's only accessible via PCI, but has no dependencies, so it ends up being selected on s390 where a bunch of primitives only exist if CONFIG_PCI=y (such as {request,free}_irq)

drivers/ptp/Kconfig +1 -0
@@ -72,6 +72,7 @@ config DP83640_PHY
 
 config PTP_1588_CLOCK_PCH
 	tristate "Intel PCH EG20T as PTP clock"
+	depends on PCI
 	select PTP_1588_CLOCK
 	help
 	  This driver adds support for using the PCH EG20T as a PTP
maintainer
#1 lore raw

From: Kyle McMartin <[email protected]>
Date: Sat, 25 May 2013 12:55:07 -0400

Quoted 5 lines

It's only accessible via PCI, but has no dependencies, so it ends up being selected on s390 where a bunch of primitives only exist if CONFIG_PCI=y (such as {request,free}_irq)

I've already told the s390 people they have to fix this properly.

They have to provide stubs for request_irq() et al. when CONFIG_PCI is not enabled.

This Kconfig change is therefore not appropriate.

#2 lore raw
Quoted 6 lines · David Miller

I've already told the s390 people they have to fix this properly.

They have to provide stubs for request_irq() et al. when CONFIG_PCI is not enabled.

This Kconfig change is therefore not appropriate.

OK. Thanks Dave.

regards, Kyle

#3 lore raw
In reply to David Miller
Quoted 7 lines · David Miller

From: Kyle McMartin <[email protected]>
Date: Sat, 25 May 2013 12:55:07 -0400

Quoted 4 lines

It's only accessible via PCI, but has no dependencies, so it ends up being selected on s390 where a bunch of primitives only exist if CONFIG_PCI=y (such as {request,free}_irq)

Quoted 8 lines
Quoted 1 line

I've already told the s390 people they have to fix this properly.

They have to provide stubs for request_irq() et al. when CONFIG_PCI is not enabled.

This Kconfig change is therefore not appropriate.

You are quite right about request_irq(), but this is a PCI driver.

Ben.

Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.