Skip to contentSkip to conversation

ARM: dts: imx28-evk: Enable touchscreen support

PATCH New Fabio Estevam 4 participants 27 messages Feb 8, 2013 – May 29, 2013

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

---
 arch/arm/boot/dts/imx28-evk.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx28-evk.dts +1 -0
index 2da316e..5960578 100644
@@ -155,6 +155,7 @@
 			};
 
 			lradc at 80050000 {
+				fsl,lradc-touchscreen-wires = <4>;
 				status = "okay";
 			};
 
Signature · 1 line
1.7.9.5
author reviewer
#1 lore raw

PATCH 2/3 ARM: dts: imx28-apx4devkit: Enable touchscreen support

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

---
 arch/arm/boot/dts/imx28-apx4devkit.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/imx28-apx4devkit.dts +5 -0
index 5171667..bb615d5 100644
@@ -131,6 +131,11 @@
 				};
 			};
 
+			lradc at 80050000 {
+				fsl,lradc-touchscreen-wires = <4>;
+				status = "okay";
+			};
+
 			duart: serial at 80074000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&duart_pins_a>;
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/3 ARM: dts: imx28-apx4devkit: Enable touchscreen support

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

Best regards,
Lauri Hintsala

Quoted 21 lines
---
  arch/arm/boot/dts/imx28-apx4devkit.dts |    5 +++++
  1 file changed, 5 insertions(+)
arch/arm/boot/dts/imx28-apx4devkit.dts +5 -0
index 5171667..bb615d5 100644
@@ -131,6 +131,11 @@
  				};
  			};
 
+			lradc at 80050000 {
+				fsl,lradc-touchscreen-wires = <4>;
+				status = "okay";
+			};
+
  			duart: serial at 80074000 {
  				pinctrl-names = "default";
  				pinctrl-0 = <&duart_pins_a>;
author reviewer
#3 lore raw

PATCH 3/3 ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Build CONFIG_INPUT_EVDEV as a built-in driver, as it makes easier to test the LRADC touchscreen driver, for example, by using the 'evtest' tool.

---
 arch/arm/configs/mxs_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/mxs_defconfig +1 -1
index 7bf5351..2c1329d 100644
@@ -67,7 +67,7 @@ CONFIG_USB_NET_SMSC95XX=y
 # CONFIG_NETDEV_10000 is not set
 # CONFIG_WLAN is not set
 # CONFIG_INPUT_MOUSEDEV_PSAUX is not set
-CONFIG_INPUT_EVDEV=m
+CONFIG_INPUT_EVDEV=y
 # CONFIG_INPUT_KEYBOARD is not set
 # CONFIG_INPUT_MOUSE is not set
 CONFIG_INPUT_TOUCHSCREEN=y
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

Queued all 3 for 3.10.

Shawn

Quoted 19 lines
---
 arch/arm/boot/dts/imx28-evk.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx28-evk.dts +1 -0
index 2da316e..5960578 100644
@@ -155,6 +155,7 @@
 			};
 
 			lradc at 80050000 {
+				fsl,lradc-touchscreen-wires = <4>;
 				status = "okay";
 			};
 
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Dear Shawn Guo,

Quoted 9 lines · Fabio Estevam
Quoted 6 lines

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

Queued all 3 for 3.10.

I dont intend to ramble or annoy you (I already did that plenty ;-) ), but can we not speed this up and push these simple stuffs for 3.9?

Best regards,
Marek Vasut

#6 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 8 lines · Marek Vasut

Dear Shawn Guo,

Quoted 6 lines · Fabio Estevam
Quoted 5 lines

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Queued all 3 for 3.10.

I dont intend to ramble or annoy you (I already did that plenty ;-) ), but can we not speed this up and push these simple stuffs for 3.9?

No. arm-soc folks require that material for each merge window should be reaching them around -rc6 time (2 weeks to opening of the merge window). So it's simply late for 3.9.

Shawn

#7 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Dear Shawn Guo,

Quoted 11 lines · Marek Vasut
Quoted 10 lines

Dear Shawn Guo,

Quoted 8 lines · Fabio Estevam
Quoted 6 lines

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Queued all 3 for 3.10.

I dont intend to ramble or annoy you (I already did that plenty ;-) ), but can we not speed this up and push these simple stuffs for 3.9?

No. arm-soc folks require that material for each merge window should be reaching them around -rc6 time (2 weeks to opening of the merge window). So it's simply late for 3.9.

Ah I see, thanks for clearing this up.

Best regards,
Marek Vasut

#8 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

In reply to Fabio Estevam
Quoted 15 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that touchscreen can be functional.

---
 arch/arm/boot/dts/imx28-evk.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx28-evk.dts +0 -0
index 2da316e..5960578 100644

arch/arm/boot/dts/imx28-evk.dts line 158

Quoted 4 lines
arch/arm/boot/dts/imx28-evk.dts +1 -0
@@ -155,6 +155,7 @@
 			};
 
 			lradc at 80050000 {
+				fsl,lradc-touchscreen-wires = <4>;

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Shawn

Quoted 6 lines
arch/arm/boot/dts/imx28-evk.dts +0 -0
 				status = "okay";
 			};
 
Signature · 1 line
1.7.9.5
author reviewer
#9 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Just tested and I confirm I see the same issue here on 3.9-rc1.

However, when applying the touchscreen support on top of 3.8 (from this tree https://github.com/Freescale/linux-mainline/commits/patches-3.8
) both touch and audio work as expected.

#10 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 8 lines · Fabio Estevam
Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Just tested and I confirm I see the same issue here on 3.9-rc1.

Ok, I drop both patches for now.

Shawn

author reviewer
#11 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 10 lines · Shawn Guo
Quoted 8 lines · Fabio Estevam
Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Just tested and I confirm I see the same issue here on 3.9-rc1.

Ok, I drop both patches for now.

Reverting ad76fda7 fixes the issue. Will send a patch shortly.

author reviewer
#12 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 1 line · Fabio Estevam

Reverting ad76fda7 fixes the issue. Will send a patch shortly.

Sorry, this is not true. Will investigate more.

author reviewer
#13 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 5 lines · Fabio Estevam
Quoted 1 line · Fabio Estevam

Reverting ad76fda7 fixes the issue. Will send a patch shortly.

Sorry, this is not true. Will investigate more.

Interesting that when I run 3.9.0-rc1-next-20130305 from my home network and I don't get any issues with
audio playback + touchscreen.

author reviewer
#14 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

In reply to Shawn Guo

Shawn,

Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Can you please re-try against linux-next 20130322?

I tried it here and audio playback is normal with touchscreen enabled.

#15 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 10 lines · Fabio Estevam

Shawn,

Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Can you please re-try against linux-next 20130322?

Does it even boot for you? On my side, it stops at the point below.

[    1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget
[    1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller
[    1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1
Quoted 1 line

I tried it here and audio playback is normal with touchscreen enabled.

You must have both patches below applied.

1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in
2) ARM: dts: imx28-evk: Enable touchscreen support

I found that applying either one of the two without applying the other will result in a broken audio playback.

That said, my mxs/soc branch gets a broken audio playback, and next-20130322 should be the same case, because both have the second patch not applied.

I'm going to drop CONFIG_INPUT_EVDEV patch from my mxs/soc branch, and will not apply either of the two until the root cause of the broken audio playback gets identified.

Shawn

author reviewer
#16 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 9 lines · Shawn Guo
Quoted 8 lines · Fabio Estevam

Shawn,

Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Quoted 7 lines
Quoted 2 lines

Can you please re-try against linux-next 20130322?

Does it even boot for you? On my side, it stops at the point below.

[    1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget
[    1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller
[    1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1

Same here. I forgot to mention I had to disable USB in order to complete the boot. This USB issue should be addressed separately though.

Quoted 10 lines
Quoted 2 lines

I tried it here and audio playback is normal with touchscreen enabled.

You must have both patches below applied.

1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in
2) ARM: dts: imx28-evk: Enable touchscreen support

I found that applying either one of the two without applying the other will result in a broken audio playback.

With the USB support disabled, I don't see audio playback failure.

#17 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 14 lines · Fabio Estevam
Quoted 13 lines · Shawn Guo
Quoted 10 lines · Fabio Estevam

Shawn,

Quoted 3 lines · Shawn Guo

I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side?

Can you please re-try against linux-next 20130322?

Does it even boot for you? On my side, it stops at the point below.

Quoted 8 lines
Quoted 3 lines
[    1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget
[    1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller
[    1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1

Same here. I forgot to mention I had to disable USB in order to complete the boot. This USB issue should be addressed separately though.

Just figured it out that the problem is caused by usb phy Kconfig symbol shuffling. Just posted fixes.

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

I tried it here and audio playback is normal with touchscreen enabled.

You must have both patches below applied.

Quoted 7 lines
Quoted 5 lines

1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in
2) ARM: dts: imx28-evk: Enable touchscreen support

I found that applying either one of the two without applying the other will result in a broken audio playback.

With the USB support disabled, I don't see audio playback failure.

Yes, when testing on next-20130322, it seems audio playback works. But since when the patch gets applied on my mxs/dt branch, it breaks audio there, I still can not apply it.

Shawn

author reviewer
#18 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Hi Shawn,

Quoted 3 lines · Shawn Guo

Yes, when testing on next-20130322, it seems audio playback works. But since when the patch gets applied on my mxs/dt branch, it breaks audio there, I still can not apply it.

Could you please apply the touchscreen patch now?

#19 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 9 lines · Fabio Estevam

Hi Shawn,

Quoted 3 lines · Shawn Guo

Yes, when testing on next-20130322, it seems audio playback works. But since when the patch gets applied on my mxs/dt branch, it breaks audio there, I still can not apply it.

Could you please apply the touchscreen patch now?

Have you tested it against v3.10-rc1? The issue is still there in my testing.

Shawn

#20 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Dear Shawn Guo,

Quoted 12 lines · Fabio Estevam
Quoted 8 lines

Hi Shawn,

Quoted 3 lines · Shawn Guo

Yes, when testing on next-20130322, it seems audio playback works. But since when the patch gets applied on my mxs/dt branch, it breaks audio there, I still can not apply it.

Could you please apply the touchscreen patch now?

Have you tested it against v3.10-rc1? The issue is still there in my testing.

Are the block handling touchscreen (lradc) and the block handling audio (sgtl5000+ssi) not two completely separate blocks? How can one influence the other?

There is a possibility that there's some problem with broken clock bindings or clock structure maybe? That's the only thing that comes to mind that might cause it.

Best regards,
Marek Vasut

author reviewer
#21 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

In reply to Shawn Guo

Hi Shawn,

Quoted 2 lines · Shawn Guo

Have you tested it against v3.10-rc1? The issue is still there in my testing.

I am not able to see the issue on 3.10-rc2.

What are the exact steps to trigger the problem? Do you see it consistently?

#22 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 9 lines · Fabio Estevam

Hi Shawn,

Quoted 2 lines · Shawn Guo

Have you tested it against v3.10-rc1? The issue is still there in my testing.

I am not able to see the issue on 3.10-rc2.

My imx/dt branch is currently basing on v3.10-rc1, and I do not care if it works on v3.10-rc2. I have tested this patch enough on different bases, and I'm not going to test it again and again to find a base which happens to work. I do not feel comfortable to merge this patch if it only works on particular base. Who knows if it will break again with another random patches merged in. There is some issue, and we need to find the root cause of it instead of ignoring it by finding some random base which hides it.

Quoted 1 line

What are the exact steps to trigger the problem? Do you see it consistently?

Before I answer your questions, can I ask if you have tried to reproduce it on v3.10-rc1?

Shawn

#23 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Dear Shawn Guo,

Quoted 18 lines · Fabio Estevam
Quoted 7 lines

Hi Shawn,

Quoted 2 lines · Shawn Guo

Have you tested it against v3.10-rc1? The issue is still there in my testing.

I am not able to see the issue on 3.10-rc2.

My imx/dt branch is currently basing on v3.10-rc1, and I do not care if it works on v3.10-rc2. I have tested this patch enough on different bases, and I'm not going to test it again and again to find a base which happens to work. I do not feel comfortable to merge this patch if it only works on particular base. Who knows if it will break again with another random patches merged in. There is some issue, and we need to find the root cause of it instead of ignoring it by finding some random base which hides it.

Quoted 5 lines
Quoted 2 lines

What are the exact steps to trigger the problem? Do you see it consistently?

Before I answer your questions, can I ask if you have tried to reproduce it on v3.10-rc1?

What is the problem you observe?

Best regards,
Marek Vasut

#24 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 2 lines · Marek Vasut

What is the problem you observe?

The audio playback gives silent output.

Shawn

#25 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Dear Shawn Guo,

Quoted 4 lines · Marek Vasut
Quoted 1 line

What is the problem you observe?

The audio playback gives silent output.

You mean like nothing? Zilch? Not even a loud pop on the start/stop of playback?

I have no issues with audio + touchscreen on m28evk since like 3.7 or so (even before I pushed the driver mainline), so this is weird. Do you have your speakers connected to LineOut or Speaker output from the SGTL5000 ? In case of LineOut, is your on-board amplifier on ?

Best regards,
Marek Vasut

#26 lore raw

PATCH 1/3 ARM: dts: imx28-evk: Enable touchscreen support

Quoted 9 lines · Marek Vasut

Dear Shawn Guo,

Quoted 4 lines · Marek Vasut
Quoted 1 line

What is the problem you observe?

The audio playback gives silent output.

You mean like nothing? Zilch? Not even a loud pop on the start/stop of playback?

Nothing.

Quoted 5 lines

I have no issues with audio + touchscreen on m28evk since like 3.7 or so (even before I pushed the driver mainline), so this is weird. Do you have your speakers connected to LineOut or Speaker output from the SGTL5000 ? In case of LineOut, is your on-board amplifier on ?

Only headphone.

Shawn