Skip to contentSkip to conversation

pci: set firmware name of q35 to pci

PATCH In review Amos Kong 2 participants 3 messages May 30, 2013

lore
Share & tools
lore

Amos Kong

author
#0 lore raw

PATCH v2 1/1 pci: set firmware name of q35 to pci

In QEMU, we set the firmware name of pc-i440fx to 'pci', and the typename 'q35-pcihost' is set to the firmware name of q35 by default.

The seabios matches pci devices by "/pci/@i0cf8", so q35 device could not be identified, seabios fails to adjust the boot priority of q35 devices.

This patch sets firmware name of q35 to 'pci'.

---
v2: just set the fw_name, no need to change seabios

---
 hw/pci-host/q35.c | 1 +
 1 file changed, 1 insertion(+)
hw/pci-host/q35.c +1 -0
index 8467f86..24df6b5 100644
@@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
 
     k->init = q35_host_init;
     dc->props = mch_props;
+    dc->fw_name = "pci";
 }
 
 static void q35_host_initfn(Object *obj)
Signature · 1 line
1.8.1.4
Tested-by Amos Kong on v2 1/1
#1 lore raw
Quoted 11 lines · Amos Kong

In QEMU, we set the firmware name of pc-i440fx to 'pci', and the typename 'q35-pcihost' is set to the firmware name of q35 by default.

The seabios matches pci devices by "/pci/@i0cf8", so q35 device could not be identified, seabios fails to adjust the boot priority of q35 devices.

This patch sets firmware name of q35 to 'pci'.

Does this imply

?

Quoted 20 lines

---
v2: just set the fw_name, no need to change seabios

---
 hw/pci-host/q35.c | 1 +
 1 file changed, 1 insertion(+)
hw/pci-host/q35.c +1 -0
index 8467f86..24df6b5 100644
@@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
 
     k->init = q35_host_init;
     dc->props = mch_props;
+    dc->fw_name = "pci";
 }
 
 static void q35_host_initfn(Object *obj)
Signature · 1 line
1.8.1.4
#2 lore raw
In reply to Amos Kong
Quoted 11 lines · Amos Kong

In QEMU, we set the firmware name of pc-i440fx to 'pci', and the typename 'q35-pcihost' is set to the firmware name of q35 by default.

The seabios matches pci devices by "/pci/@i0cf8", so q35 device could not be identified, seabios fails to adjust the boot priority of q35 devices.

This patch sets firmware name of q35 to 'pci'.

I've applied this already.

Quoted 20 lines

---
v2: just set the fw_name, no need to change seabios

---
 hw/pci-host/q35.c | 1 +
 1 file changed, 1 insertion(+)
hw/pci-host/q35.c +1 -0
index 8467f86..24df6b5 100644
@@ -76,6 +76,7 @@ static void q35_host_class_init(ObjectClass *klass, void *data)
 
     k->init = q35_host_init;
     dc->props = mch_props;
+    dc->fw_name = "pci";
 }
 
 static void q35_host_initfn(Object *obj)
Signature · 1 line
1.8.1.4