Skip to contentSkip to conversation

doc: specify that ABS_MT_SLOT must have a minimum of 0

PATCH Applied Peter Hutterer 3 participants 3 messages May 31, 2013 – Jun 13, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: specify that ABS_MT_SLOT must have a minimum of 0

This is effectively already in force through input_mt_init_slots, and uinput too ignores the actual minimum.

Since slots are a kernel-genenerated axis only, non-zero minimums make little sense and are likely to cause errors. Better to treat a non-zero minimum as kernel bug if it ever happens.

---
I admit that sentence looks a bit lost there, if you want to move this elsewhere to have more exposure I'm happy to do so once I figure out where.

 Documentation/input/multi-touch-protocol.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/input/multi-touch-protocol.txt +2 -0
index 2c17961..de139b1 100644
@@ -80,6 +80,8 @@ Userspace can detect that a driver can report more total contacts than slots
 by noting that the largest supported BTN_TOOL_*TAP event is larger than the
 total number of type B slots reported in the absinfo for the ABS_MT_SLOT axis.
 
+The minimum value of the ABS_MT_SLOT axis must be 0.
+
 Protocol Example A
 ------------------
 
Signature · 1 line
1.8.2.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Peter Hutterer

This is effectively already in force through input_mt_init_slots, and uinput too ignores the actual minimum.

Since slots are a kernel-genenerated axis only, non-zero minimums make little sense and are likely to cause errors. Better to treat a non-zero minimum as kernel bug if it ever happens.

Adding Dmitry in CC.

Cheers,
Benjamin

#2 lore raw
Quoted 5 lines · Benjamin Tissoires
Quoted 3 lines · Peter Hutterer

This is effectively already in force through input_mt_init_slots, and uinput too ignores the actual minimum.

Quoted 7 lines
Quoted 5 lines

Since slots are a kernel-genenerated axis only, non-zero minimums make little sense and are likely to cause errors. Better to treat a non-zero minimum as kernel bug if it ever happens.

Applied, thanks Peter and Benjamin.

Henrik