Skip to contentSkip to conversation

ssb: sprom: replace strict_strtoul() with kstrtoul()

PATCH Applied Jingoo Han 3 participants 3 messages Jun 1, 2013 – Jun 3, 2013

Subsystems (3)
Networking Network drivers Sonics silicon backplane driver (ssb)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 ssb: sprom: replace strict_strtoul() with kstrtoul()

The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/ssb/sprom.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ssb/sprom.c +1 -1
index a3b2364..e753fbe 100644
@@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
 	while (cnt < sprom_size_words) {
 		memcpy(tmp, dump, 4);
 		dump += 4;
-		err = strict_strtoul(tmp, 16, &parsed);
+		err = kstrtoul(tmp, 16, &parsed);
 		if (err)
 			return err;
 		sprom[cnt++] = swab16((u16)parsed);
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 3 lines · On Sat, 01 Jun 2013 16:35:23 +0900 Jingoo Han <[email protected]> wrote:

The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.

Looks good. John, can you apply, please?

Quoted 19 lines
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/ssb/sprom.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ssb/sprom.c +1 -1
index a3b2364..e753fbe 100644
@@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
 	while (cnt < sprom_size_words) {
 		memcpy(tmp, dump, 4);
 		dump += 4;
-		err = strict_strtoul(tmp, 16, &parsed);
+		err = kstrtoul(tmp, 16, &parsed);
 		if (err)
 			return err;
 		sprom[cnt++] = swab16((u16)parsed);
Signature · 1 line
Michael