regmap: regcache-flat: Implemented sync operation
Subsystems (2)
PATCH 1/1 regmap: regcache-flat: Implemented sync operation
Signed-off-by Maarten ter Huurne <[email protected]>
--- drivers/base/regmap/regcache-flat.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
drivers/base/regmap/regcache-flat.c +32 -0
@@ -62,6 +62,37 @@ static int regcache_flat_write(struct regmap *map, unsigned int reg,return 0 ; } +static int regcache_flat_sync (struct regmap *map,unsigned int min, +unsigned int max) +{ +unsigned int *cache = map->cache; +unsigned int reg; + +for (reg = min; reg <= max; reg++) { +unsigned int val; +int ret; + +if (regmap_volatile (map, reg)) +continue ; + + val = cache[reg]; + +/* Is this the hardware default? If so skip. */ + ret =regcache_lookup_reg (map, reg); +if (ret >=0 && val == map->reg_defaults[ret].def) +continue ; + + map->cache_bypass =1 ; + ret =_regmap_write (map, reg, val); + map->cache_bypass =0 ; +if (ret) +return ret; +dev_dbg (map->dev,"Synced register %#x, value %#x\n" , reg, val); + } + +return 0 ; +} +struct regcache_ops regcache_flat_ops = { .type =REGCACHE_FLAT , .name ="flat" ,
@@ -69,4 +100,5 @@ struct regcache_ops regcache_flat_ops = { .exit = regcache_flat_exit, .read = regcache_flat_read, .write = regcache_flat_write, + .sync = regcache_flat_sync, };
Signature · 1 line
1.7.10.4
Mark Brown
maintainerQuoted 2 lines · Maarten ter Huurne
Signed-off-by Maarten ter Huurne <[email protected]>
This should probably just go into regcache.c as a default sync operation based on doing reads rather than being open coded - it's not meanigfully using any features of the cache data structure really.
PATCH 1/1 regmap: Implemented default cache sync operation
This can be used for cache types for which syncing values one by one is equally efficient as syncing a range, such as the flat cache.
Signed-off-by Maarten ter Huurne <[email protected]>
--- drivers/base/regmap/regcache.c | 46 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-)
drivers/base/regmap/regcache.c +42 -4
@@ -249,6 +249,38 @@ int regcache_write(struct regmap *map,return 0 ; } +static int regcache_default_sync (struct regmap *map,unsigned int min, +unsigned int max) +{ +unsigned int reg; + +for (reg = min; reg <= max; reg++) { +unsigned int val; +int ret; + +if (regmap_volatile (map, reg)) +continue ; + + ret =regcache_read (map, reg, &val); +if (ret) +return ret; + +/* Is this the hardware default? If so skip. */ + ret =regcache_lookup_reg (map, reg); +if (ret >=0 && val == map->reg_defaults[ret].def) +continue ; + + map->cache_bypass =1 ; + ret =_regmap_write (map, reg, val); + map->cache_bypass =0 ; +if (ret) +return ret; +dev_dbg (map->dev,"Synced register %#x, value %#x\n" , reg, val); + } + +return 0 ; +} +/** * regcache_sync: Sync the register cache with the hardware. *
@@ -267,7 +299,7 @@ int regcache_sync(struct regmap *map)const char *name;unsigned int bypass; -BUG_ON (!map->cache_ops || !map->cache_ops->sync); +BUG_ON (!map->cache_ops); map->lock (map);/* Remember the initial bypass state */
@@ -296,7 +328,10 @@ int regcache_sync(struct regmap *map) } map->cache_bypass =0 ; - ret = map->cache_ops->sync (map,0 , map->max_register); +if (map->cache_ops->sync) + ret = map->cache_ops->sync (map,0 , map->max_register); +else + ret =regcache_default_sync (map,0 , map->max_register);if (ret ==0 ) map->cache_dirty = false;
@@ -330,7 +365,7 @@ int regcache_sync_region(struct regmap *map, unsigned int min,const char *name;unsigned int bypass; -BUG_ON (!map->cache_ops || !map->cache_ops->sync); +BUG_ON (!map->cache_ops); map->lock (map);
@@ -345,7 +380,10 @@ int regcache_sync_region(struct regmap *map, unsigned int min,if (!map->cache_dirty) goto out; - ret = map->cache_ops->sync (map, min, max); +if (map->cache_ops->sync) + ret = map->cache_ops->sync (map, min, max); +else + ret =regcache_default_sync (map, min, max); out:trace_regcache_sync (map->dev, name,"stop region" );
Signature · 1 line
1.7.10.4
Re: [PATCH] regmap: Implemented default cache sync operation
Quoted 2 lines · Maarten ter Huurne
This can be used for cache types for which syncing values one by one is equally efficient as syncing a range, such as the flat cache.
Applied, thanks.