Skip to contentSkip to conversation

ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi

PATCH New Adam Baker 3 participants 3 messages Jun 2, 2013 – Jun 3, 2013 Device tree bindings

lore
Share & tools
lore

Adam Baker

author
#0 lore raw

PATCH 1/1 ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi

The Kirkwood CPU Freq driver needs a CPU definition in order for the probe routine to activate it. Add a suitable definition to kirkwood.dtsi

This definition is only correct for single core SoCs. There is a dual core SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in the kernel don't currently support it. If they ever do the cpus definition would need to be duplicated in each of the SoC specific include files.

arch/arm/boot/dts/kirkwood.dtsi +12 -0
@@ -4,6 +4,18 @@
 	compatible = "marvell,kirkwood";
 	interrupt-parent = <&intc>;
 
+        cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+		      device_type = "cpu";
+		      compatible = "marvell,feroceon";
+		      clocks = <&core_clk 1>, <&core_clk 3>, <&gate_clk 11>;
+		      clock-names = "cpu_clk", "ddrclk", "powersave";
+		};
+	};
+
 	aliases {
 	       gpio0 = &gpio0;
 	       gpio1 = &gpio1;
#1 lore raw

PATCH 1/1 ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi

Quoted 9 lines · Adam Baker

The Kirkwood CPU Freq driver needs a CPU definition in order for the probe routine to activate it. Add a suitable definition to kirkwood.dtsi

This definition is only correct for single core SoCs. There is a dual core SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in the kernel don't currently support it. If they ever do the cpus definition would need to be duplicated in each of the SoC specific include files.

Andrew

Quoted 23 lines
arch/arm/boot/dts/kirkwood.dtsi +12 -0
@@ -4,6 +4,18 @@
 	compatible = "marvell,kirkwood";
 	interrupt-parent = <&intc>;
 
+        cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+		      device_type = "cpu";
+		      compatible = "marvell,feroceon";
+		      clocks = <&core_clk 1>, <&core_clk 3>, <&gate_clk 11>;
+		      clock-names = "cpu_clk", "ddrclk", "powersave";
+		};
+	};
+
 	aliases {
 	       gpio0 = &gpio0;
 	       gpio1 = &gpio1;
#2 lore raw

PATCH 1/1 ARM: Kirkwood add cpus definition needed by cpufreq driver to dtsi

In reply to Adam Baker
Quoted 9 lines · Adam Baker

The Kirkwood CPU Freq driver needs a CPU definition in order for the probe routine to activate it. Add a suitable definition to kirkwood.dtsi

This definition is only correct for single core SoCs. There is a dual core SoC in the kirkwood family (88F632X) but the rest of the Kirkwood drivers in the kernel don't currently support it. If they ever do the cpus definition would need to be duplicated in each of the SoC specific include files.

hmm, diffstat is missing. Please make sure you are using git format-patch properly in the future.

After cleaning up some minor whitespace (needed leading tabs), applied to mvebu/dt

thx,

Jason.