ARM: ux500: register LP5521 LEDs in the device tree
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)
arch/arm/boot/dts/href.dtsi +32 -6
@@ -63,16 +63,42 @@ }; i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 { + compatible = "national,lp5521"; reg = <0x33>; + label = "lp5521_pri"; + clock-mode = /bits/ 8 <2>; + chan0 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan1 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan2 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; }; - - lp5521 at 0x34 { - compatible = "lp5521"; + lp5521 at 34 { + compatible = "national,lp5521"; reg = <0x34>; + label = "lp5521_sec"; + clock-mode = /bits/ 8 <2>; + chan0 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan1 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan2 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; }; - bh1780 at 0x29 { compatible = "rohm,bh1780gli"; reg = <0x33>;
Signature · 1 line
1.7.11.3
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
Quoted 7 lines
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
In reply to Linus WalleijQuoted 18 lines · Linus Walleij
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)arch/arm/boot/dts/href.dtsi +0
-0
arch/arm/boot/dts/href.dtsi line 66
Quoted 6 lines
arch/arm/boot/dts/href.dtsi +1
-2@@ -63,16 +63,42 @@ }; i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 {
Is this right, I guess it should be still "lp5521 at 0x33", although it's just a name.
-Bryan
Quoted 45 lines
arch/arm/boot/dts/href.dtsi +31
-5+ compatible = "national,lp5521"; reg = <0x33>; + label = "lp5521_pri"; + clock-mode = /bits/ 8 <2>; + chan0 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan1 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan2 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; }; - - lp5521 at 0x34 { - compatible = "lp5521"; + lp5521 at 34 { + compatible = "national,lp5521"; reg = <0x34>; + label = "lp5521_sec"; + clock-mode = /bits/ 8 <2>; + chan0 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan1 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; + chan2 { + led-cur = /bits/ 8 <0x2f>; + max-cur = /bits/ 8 <0x5f>; + }; }; - bh1780 at 0x29 { compatible = "rohm,bh1780gli"; reg = <0x33>; --1.7.11.3
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
Quoted 22 lines · Bryan Wu
Quoted 20 lines · Linus Walleij
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)arch/arm/boot/dts/href.dtsi +0
-0@@ -63,16 +63,42 @@ };
Quoted 7 lines
arch/arm/boot/dts/href.dtsi line 66
Quoted 4 lines
arch/arm/boot/dts/href.dtsi +1
-2i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 {Is this right, I guess it should be still "lp5521 at
0x33", although it's just a name.
What makes you say that Bryan?
All other nodes drop the '0x', as it's implied.
Signature · 4 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
Quoted 32 lines · Lee Jones
Quoted 22 lines · Bryan Wu
Quoted 20 lines · Linus Walleij
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)arch/arm/boot/dts/href.dtsi +0
-0@@ -63,16 +63,42 @@ };Quoted 7 lines
arch/arm/boot/dts/href.dtsi line 66
Quoted 4 lines
arch/arm/boot/dts/href.dtsi +1
-2i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 {Is this right, I guess it should be still "lp5521 at
0x33", although it's just a name.
Quoted 4 lines
What makes you say that Bryan?
All other nodes drop the '0x', as it's implied.
But I still got this in this patch
" bh1780 at 0x29 {"
which is not changed. So which one should be the right?
-Bryan
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
Quoted 35 lines · Bryan Wu
Quoted 34 lines · Lee Jones
Quoted 22 lines · Bryan Wu
Quoted 20 lines · Linus Walleij
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)arch/arm/boot/dts/href.dtsi +0
-0@@ -63,16 +63,42 @@ };Quoted 7 lines
arch/arm/boot/dts/href.dtsi line 66
Quoted 4 lines
arch/arm/boot/dts/href.dtsi +1
-2i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 {Is this right, I guess it should be still "lp5521 at
0x33", although it's just a name.What makes you say that Bryan?
Quoted 7 lines
Quoted 2 lines
All other nodes drop the '0x', as it's implied.
But I still got this in this patch
" bh1780 at0x29{"which is not changed. So which one should be the right?
The one without the '0x' is correct.
If there are any of these left over that Linus hasn't fixed yet, I'm happy to fix.
Signature · 4 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 1/1 ARM: ux500: register LP5521 LEDs in the device tree
Quoted 43 lines · Lee Jones
Quoted 41 lines · Bryan Wu
Quoted 32 lines · Lee Jones
Quoted 22 lines · Bryan Wu
Quoted 20 lines · Linus Walleij
From: Linus Walleij <[email protected]>
Based on pending device tree support in the LP55xx drivers we can add the correct LED and channel configuration from the ux500 device tree for all HREF variants.
Cc Milo Kim <[email protected]>Cc Bryan Wu <[email protected]>Signed-off-by Linus Walleij <[email protected]>--- arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-)arch/arm/boot/dts/href.dtsi +0
-0@@ -63,16 +63,42 @@ };Quoted 7 lines
arch/arm/boot/dts/href.dtsi line 66
Quoted 4 lines
arch/arm/boot/dts/href.dtsi +1
-2i2c at 80128000 { - lp5521 at 0x33 { - compatible = "lp5521"; + lp5521 at 33 {Is this right, I guess it should be still "lp5521 at
0x33", although it's just a name.Quoted 4 lines
What makes you say that Bryan?
All other nodes drop the '0x', as it's implied.
But I still got this in this patch
" bh1780 at0x29{"
Quoted 6 lines
Quoted 1 line
which is not changed. So which one should be the right?
The one without the '0x' is correct.
If there are any of these left over that Linus hasn't fixed yet, I'm happy to fix.
Sure, no problem. I just found this inconsistence confused me.
Thanks,
-Bryan