Skip to contentSkip to conversation

sconeserver: fix autouild failure

PATCH New spdawson at gmail.com 5 participants 12 messages Jun 3, 2013 – Jun 13, 2013

lore
Share & tools
lore

spdawson at gmail.com

author
#0 lore raw

PATCH 1/1 sconeserver: fix autouild failure

From: Simon Dawson <[email protected]>

Fixes autobuild failures such as the following.

http://autobuild.buildroot.net/results/1bdb5e014daf76b701afea5c82ac83ac4c97d4cb/

Signed-off-by Simon Dawson <[email protected]>
---
 package/sconeserver/sconeserver.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/sconeserver/sconeserver.mk +2 -1
index 744f389..565d467 100644
@@ -60,7 +60,8 @@ endif
 ifeq ($(BR2_PACKAGE_SCONESERVER_MYSQL),y)
 	SCONESERVER_DEPENDENCIES += mysql_client
 	SCONESERVER_CONF_OPT += --with-mysql \
-		--with-mysql_config="$(STAGING_DIR)/usr/bin/mysql_config"
+		--with-mysql_config="$(STAGING_DIR)/usr/bin/mysql_config" \
+		LDFLAGS="$(TARGET_LDFLAGS) -L$(STAGING_DIR)/usr/lib/mysql"
 else
 	SCONESERVER_CONF_OPT += --without-mysql
 endif
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Simon,

Quoted 5 lines · spdawson at gmail.com
package/sconeserver/sconeserver.mk +0 -0
index 744f389..565d467 100644

package/sconeserver/sconeserver.mk endif · line 67

Quoted 9 lines
package/sconeserver/sconeserver.mk +2 -1
@@ -60,7 +60,8 @@ endif
 ifeq ($(BR2_PACKAGE_SCONESERVER_MYSQL),y)
 	SCONESERVER_DEPENDENCIES += mysql_client
 	SCONESERVER_CONF_OPT += --with-mysql \
-		--with-mysql_config="$(STAGING_DIR)/usr/bin/mysql_config"
+		--with-mysql_config="$(STAGING_DIR)/usr/bin/mysql_config" \
+		LDFLAGS="$(TARGET_LDFLAGS) -L$(STAGING_DIR)/usr/lib/mysql"
 else
 	SCONESERVER_CONF_OPT += --without-mysql
 endif

This more-or-less reverts part of your commit 8d34e073c00236ff41a6df8f0fdd6b0b25dc4ad1. Is there a reason why sconeserver isn't taking the right ldflags from mysql_config?

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Hi Thomas; thanks for looking at this.

Quoted 3 lines · Thomas Petazzoni

This more-or-less reverts part of your commit 8d34e073c00236ff41a6df8f0fdd6b0b25dc4ad1. Is there a reason why sconeserver isn't taking the right ldflags from mysql_config?

The sconeserver configure script doesn't call mysql_config until after it has checked for the mysqlclient library; the adjustment of the LDFLAGS in the package makefile is needed so that the check for the mysqlclient library works correctly. Once this library check has been performed, the configure script calls mysql_config to obtain compile and link flags for the build.

Simon.

#3 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Dear Simon Dawson,

Quoted 6 lines · Simon Dawson

The sconeserver configure script doesn't call mysql_config until after it has checked for the mysqlclient library; the adjustment of the LDFLAGS in the package makefile is needed so that the check for the mysqlclient library works correctly. Once this library check has been performed, the configure script calls mysql_config to obtain compile and link flags for the build.

Ok, the configure script is stupid (checking for a library existence before calling mysql_config), but ok, I guess we have to live with that :)

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Quoted 3 lines · Thomas Petazzoni

Ok, the configure script is stupid (checking for a library existence before calling mysql_config), but ok, I guess we have to live with that :)

Yes, agreed.

Simon.

#5 lore raw

PATCH 1/1 sconeserver: fix autouild failure

In reply to spdawson at gmail.com
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

spdawson> From: Simon Dawson <[email protected]> spdawson> Fixes autobuild failures such as the following.

spdawson> http://autobuild.buildroot.net/results/1bdb5e014daf76b701afea5c82ac83ac4c97d4cb/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 sconeserver: fix autouild failure

In reply to spdawson at gmail.com

Dear spdawson at gmail.com,

Quoted 7 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

Fixes autobuild failures such as the following.

http://autobuild.buildroot.net/results/1bdb5e014daf76b701afea5c82ac83ac4c97d4cb/

Signed-off-by Simon Dawson <[email protected]>

There are still build failures related to sconeserver and MySQL. See
http://autobuild.buildroot.org/results/a16/a162fbd8977faa561a76f76072ec3335fb8e8d1f/build-end.log.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#7 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Hi Thomas,

Quoted 2 lines · Thomas Petazzoni

There are still build failures related to sconeserver and MySQL. See
http://autobuild.buildroot.org/results/a16/a162fbd8977faa561a76f76072ec3335fb8e8d1f/build-end.log.

I've been unable to reproduce this using the defconfig from the failed autobuild. I'm struggling to understand what exactly is causing the failures; would appreciate any suggestions that you may have...

Simon.

#8 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Quoted 10 lines · Simon Dawson

Hi Thomas,

Quoted 2 lines · Thomas Petazzoni

There are still build failures related to sconeserver and MySQL. See
http://autobuild.buildroot.org/results/a16/a162fbd8977faa561a76f76072ec3335fb8e8d1f/build-end.log.

I've been unable to reproduce this using the defconfig from the failed autobuild. I'm struggling to understand what exactly is causing the failures; would appreciate any suggestions that you may have...

mysql.h is in $(STAGING_DIR)/usr/include/mysql, but that doesn't get
included in the CXXFLAGS.

Peter, can you reproduce the autobuilder error and extract the
config.log and $(STAGING_DIR)/usr/bin/mysql_config?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#9 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

There are still build failures related to sconeserver and MySQL. See
http://autobuild.buildroot.org/results/a16/a162fbd8977faa561a76f76072ec3335fb8e8d1f/build-end.log.

I've been unable to reproduce this using the defconfig from the failed autobuild. I'm struggling to understand what exactly is causing the failures; would appreciate any suggestions that you may have...

Arnout> mysql.h is in $(STAGING_DIR)/usr/include/mysql, but that doesn't get Arnout> included in the CXXFLAGS.

Arnout> Peter, can you reproduce the autobuilder error and extract the Arnout> config.log and $(STAGING_DIR)/usr/bin/mysql_config?

Ehh, it was a build failure on Thomas' server, so it probably makes more sense that he does it?

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

There are still build failures related to sconeserver and MySQL. See
http://autobuild.buildroot.org/results/a16/a162fbd8977faa561a76f76072ec3335fb8e8d1f/build-end.log.

I've been unable to reproduce this using the defconfig from the failed autobuild. I'm struggling to understand what exactly is causing the failures; would appreciate any suggestions that you may have...

Quoted 8 lines

Arnout> mysql.h is in $(STAGING_DIR)/usr/include/mysql, but that doesn't get Arnout> included in the CXXFLAGS.

Arnout> Peter, can you reproduce the autobuilder error and extract the Arnout> config.log and $(STAGING_DIR)/usr/bin/mysql_config?

Ehh, it was a build failure on Thomas' server, so it probably makes more sense that he does it?

Sorry, I thought that those /home/test paths were yours. Won't happen
again :-)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#11 lore raw

PATCH 1/1 sconeserver: fix autouild failure

Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Ehh, it was a build failure on Thomas' server, so it probably makes more sense that he does it?

Arnout> Sorry, I thought that those /home/test paths were yours. Won't Arnout> happen again :-)

No problem. This is one of the reasons why we have the submitter file in the same directory.

Signature · 1 line
Bye, Peter Korsgaard