Skip to contentSkip to conversation

cciss: info leak in cciss_ioctl32_passthru()

PATCH P J P 2 participants 3 messages Jun 4, 2013 Block layer

lore
Share & tools
lore

P J P

author
#0 lore raw

Hello Dan,
===

drivers/block/cciss.c +1 -0
index 6374dc1..34971aa 100644
@@ -1201,6 +1201,7 @@ static int cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode,
 	int err;
 	u32 cp;
 
+	memset(&arg64, 0, sizeof(arg64));
	...

===

This exact same patch was included back in 2010 by Mr Vasiliy Kulikov.

-> https://git.kernel.org/linus/7ab5118d7c2be650bc936894f159dc1c597badae

But there is no entry/log of its reversal. Any idea why was it removed?

Thank you.
--
Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B

#1 lore raw
Quoted 15 lines · P J P

Hello Dan,
===

drivers/block/cciss.c +1 -0
index 6374dc1..34971aa 100644
@@ -1201,6 +1201,7 @@ static int cciss_ioctl32_passthru(struct
 block_device *bdev, fmode_t mode,
 	int err;
 	u32 cp;
 
+	memset(&arg64, 0, sizeof(arg64));
...

===

Quoted 5 lines

This exact same patch was included back in 2010 by Mr Vasiliy Kulikov.

-> https://git.kernel.org/linus/7ab5118d7c2be650bc936894f159dc1c597badae

But there is no entry/log of its reversal. Any idea why was it removed?

No no. Vasily patched cciss_ioctl32_big_passthru() and this patch changes cciss_ioctl32_passthru().

regards,
dan carpenter

author
#2 lore raw

| No no. Vasily patched cciss_ioctl32_big_passthru() and this patch | changes cciss_ioctl32_passthru().

Oops, yeah, I missed the `big' part!

Thanks.
--
Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B