cw1200: remove an unreachable goto

PATCH In review Dan Carpenter 2 participants 2 messages Jun 6, 2013

Subsystems (2)

Kernel janitors Networking drivers (wireless)

lore

Share & tools

lore

Dan Carpenter

author

2013-06-06 10:51 UTC #0 lore raw

PATCH 1/1 cw1200: remove an unreachable goto

The "return" is correct and the unreachable "goto" line is wrong. I have deleted it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/wireless/cw1200/hwio.c +0 -1

index 1af7b3d..f6b5efd 100644
@@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf,
 	if ((buf_len / 2) >= 0x1000) {
 		pr_err("Can't read more than 0xfff words.\n");
 		return -EINVAL;
-		goto out;
 	}
 
 	priv->sbus_ops->lock(priv->sbus_priv);

Solomon Peachy

2013-06-06 10:55 UTC #1 lore raw

Quoted 2 lines · Dan Carpenter

The "return" is correct and the unreachable "goto" line is wrong. I have deleted it.

A patch for this was posted earlier by Joe Perches. It's in my tree now, awaiting merging.

- Solomon

Signature · 3 lines

Solomon Peachy        		       pizza at shaftnet dot org	 
Delray Beach, FL                          ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.