Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning
A message that is not in the archive (sent off-list or not yet received): 20130607154357.606025038F@opal
Quoted 8 lines · On Fri, Jun 07, 2013 at 03:43:57PM +0000, [email protected] wrote:
Module: openembedded-core.git Branch: master Commit: 3e4f4a1cf07ff7cf4c71566492385f8fbf581789 URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789Author: Andy Voltz <[email protected]> Date: Wed Jun 5 11:52:29 2013 -0400
Quoted 8 lines
tune-cortexa.inc: create a common include for cortex-a armv7a tuning
The tuning files for the cortex-a* processors are mostly identical for the A7,A8,A9,A15 processors. Rework these files to use a
CORTEX_IDvariable to setup the tuning for each specific processor.Signed-off-by Andy Voltz <[email protected]>Signed-off-by Saul Wold <[email protected]>
Something is wrong with this one:
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:
Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH (${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
Tuning 'cortexa8t-neon' has no defined features, and cannot be used.
ERROR: Execution of event handler 'check_sanity_eventhandler' failed
Please use tests like
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
to check that all tunes are still valid after such change.
Quoted 16 lines
---
meta/conf/machine/include/arm/README | 3 ++ meta/conf/machine/include/tune-cortexa.inc | 35 ++++++++++++++++++++++++++ meta/conf/machine/include/tune-cortexa15.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa7.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa8.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa9.inc | 35 +------------------------ 6 files changed, 46 insertions(+), 132 deletions(-)Diff: http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 24 lines · Martin Jansa
Quoted 8 lines · On Fri, Jun 07, 2013 at 03:43:57PM +0000, [email protected] wrote:
Module: openembedded-core.git Branch: master Commit: 3e4f4a1cf07ff7cf4c71566492385f8fbf581789 URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789Author: Andy Voltz <[email protected]> Date: Wed Jun 5 11:52:29 2013 -0400Quoted 8 lines
tune-cortexa.inc: create a common include for cortex-a armv7a tuning
The tuning files for the cortex-a* processors are mostly identical for the A7,A8,A9,A15 processors. Rework these files to use a
CORTEX_IDvariable to setup the tuning for each specific processor.Signed-off-by Andy Voltz <[email protected]>Signed-off-by Saul Wold <[email protected]>Something is wrong with this one:
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:
Quoted 8 lines
Error, the
PACKAGE_ARCHSvariable does not containTUNE_PKGARCH(${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
Tuning 'cortexa8t-neon' has no defined features, and cannot be used.ERROR: Execution of event handler '
check_sanity_eventhandler' failedPlease use tests like
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
to check that all tunes are still valid after such change.
Also it was using -mtune and documentation talks about -mtune, but actual tune-cortexa.inc is using -mcpu, this change wasn't mentioned in commit message and I don't think it's improvement.
Quoted 19 lines
Quoted 16 lines
---
meta/conf/machine/include/arm/README | 3 ++ meta/conf/machine/include/tune-cortexa.inc | 35 ++++++++++++++++++++++++++ meta/conf/machine/include/tune-cortexa15.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa7.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa8.inc | 35 +------------------------ meta/conf/machine/include/tune-cortexa9.inc | 35 +------------------------ 6 files changed, 46 insertions(+), 132 deletions(-)Diff: http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commitsSignature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Hi Martin,
Quoted 8 lines · Martin Jansa
Quoted 7 lines
Something is wrong with this one:
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:
Quoted 9 lines
Quoted 8 lines
Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH (${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:Tuning 'cortexa8t-neon' has no defined features, and cannot be used.
ERROR: Execution of event handler '
check_sanity_eventhandler' failedPlease use tests like
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
to check that all tunes are still valid after such change.
I was not aware of this test. I'll look into this.
Quoted 4 lines
Also it was using -mtune and documentation talks about -mtune, but actual tune-cortexa.inc is using -mcpu, this change wasn't mentioned in commit message and I don't think it's improvement.
*facepalm*
This is actually my mistake when I squashed my cortex-a5 file into a general cortexa file. I meant to keep the -mtune in place. I started out using mcpu before realizing mtune was also valid for cortex-a5.
I have a patch to revert that change / go back to -mtune. I will send it after I rebuild for cortex-a5.
Sorry about that. It didn't come out because the build was happy with -mcpu=cortex-a5
Signature · 2 lines
Andy Voltz Timesys Corporation
Quoted 7 lines · Andy Voltz
Quoted 7 lines
Quoted 7 lines
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:Error, the
PACKAGE_ARCHSvariable does not containTUNE_PKGARCH(${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
Tuning 'cortexa8t-neon' has no defined features, and cannot be used.
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
ERROR: Execution of event handler '
check_sanity_eventhandler' failedPlease use tests like
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
to check that all tunes are still valid after such change.I was not aware of this test. I'll look into this.
This patch is not going to work. How did you test it ?
Its trying to substitute into overrides which then are not expanded before being treated as overrides.
as a result overrides variable themselves are wrong.
We have to revert this patch please and I conur with Martin it did not seem like a significant improvement either.
Hi Khem,
Quoted 15 lines · Khem Raj
Quoted 14 lines · Andy Voltz
Quoted 13 lines
Quoted 12 lines
ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:Error, the
PACKAGE_ARCHSvariable does not containTUNE_PKGARCH(${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
Tuning 'cortexa8t-neon' has no defined features, and cannot be used.ERROR: Execution of event handler '
check_sanity_eventhandler' failedPlease use tests like
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
to check that all tunes are still valid after such change.
Quoted 8 lines
Quoted 1 line
I was not aware of this test. I'll look into this.
This patch is not going to work. How did you test it ?
Its trying to substitute into overrides which then are not expanded before being treated as overrides.
as a result overrides variable themselves are wrong.
We have to revert this patch please and I conur with Martin it did not seem like a significant improvement either.
I understand that. I sent an updated patch which reverts to mtune, but I'm getting acquainted with this tune test and it's still showing issues. I'm need to dig in more.
I tested this originally by building for the cortex-a5. I'm going to revert locally and keep using this test to keep things consistent.
Regards
Signature · 2 lines
Andy Voltz Timesys Corporation
Quoted 1 line · Andy Voltz
I understand that. I sent an updated patch which reverts to mtune, but I'm getting
mtune/march is small issue with this patch. I would recommend to send a revert of the patches
since all arm architectures are broken as of now in OE-Core
Hi Khem,
Quoted 6 lines · Andy Voltz
Quoted 1 line
I understand that. I sent an updated patch which reverts to mtune, but I'm getting
mtune/march is small issue with this patch. I would recommend to send a revert of the patches
since all arm architectures are broken as of now in OE-Core
I see the issue now. It seems that overriding the tunes with a variable reference does not work for all the tunings. With the tune test script, I'm seeing that these tunes are broken:
log.fake-cortexa9.cortexa9*
log.fake-cortexa8.cortexa8*
I see that variables can be assigned with a reference based on stuff like FILES_${QT_BASE_NAME}-fonts = ...
(From recipes-qt/qt4/qt4-embedded.inc)
I'm not sure why it works there and not in the tunings, or how to fix.
For now I have a revert patch which removes tune-cortexa.inc and restores the previous contents of the a7,a8,a9,15 tuning files.
It also adds the tune-cortexa5.inc file I had sent on the list originally which led to this code-reduction experiment. That thread is here for reference:
http://lists.openembedded.org/pipermail/openembedded-core/2013-June/079452.html
Thanks for pointing out this issue. Patch is on the way.
Regards
Signature · 2 lines
Andy Voltz Timesys Corporation
Quoted 15 lines · Andy Voltz
Hi Khem,
Quoted 6 lines · Andy Voltz
Quoted 1 line
I understand that. I sent an updated patch which reverts to mtune, but I'm getting
mtune/march is small issue with this patch. I would recommend to send a revert of the patches
since all arm architectures are broken as of now in OE-CoreI see the issue now. It seems that overriding the tunes with a variable reference does not work for all the tunings. With the tune test script, I'm seeing that these tunes are broken:
log.fake-cortexa9.cortexa9*
log.fake-cortexa8.cortexa8*
Quoted 7 lines
I see that variables can be assigned with a reference based on stuff like FILES_${QT_BASE_NAME}-fonts = …
(From recipes-qt/qt4/qt4-embedded.inc)
I'm not sure why it works there and not in the tunings, or how to fix.
its a different thing. Its constructing a variable name and not override. You were trying to create a override on the fly that won't work.
Quoted 10 lines
For now I have a revert patch which removes tune-cortexa.inc and restores the previous contents of the a7,a8,a9,15 tuning files.
It also adds the tune-cortexa5.inc file I had sent on the list originally which led to this code-reduction experiment. That thread is here for reference:
http://lists.openembedded.org/pipermail/openembedded-core/2013-June/079452.html
Thanks for pointing out this issue. Patch is on the way.
np
Quoted 4 lines
Regards
Signature · 2 lines
Andy Voltz Timesys Corporation