Skip to contentSkip to conversation

i2c-designware-platform: don't check resource with devm_ioremap_resource

PATCH In review Andy Shevchenko 2 participants 2 messages Jun 7, 2013 – Jun 11, 2013 1 message not in the archive

Subsystems (3)
I2C subsystem host drivers Intel LPSS (Low Power SubSystem) drivers Synopsys DesignWare I2C driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 i2c-designware-platform: don't check resource with devm_ioremap_resource

devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.

Signed-off-by Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/i2c/busses/i2c-designware-platdrv.c +1 -7
index 35b70a1..ee46c92 100644
@@ -87,13 +87,6 @@ static int dw_i2c_probe(struct platform_device *pdev)
 	struct resource *mem;
 	int irq, r;
 
-	/* NOTE: driver uses the static register mapping */
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!mem) {
-		dev_err(&pdev->dev, "no mem resource?\n");
-		return -EINVAL;
-	}
-
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
 		dev_err(&pdev->dev, "no irq resource?\n");

@@ -104,6 +97,7 @@ static int dw_i2c_probe(struct platform_device *pdev)
 	if (!dev)
 		return -ENOMEM;
 
+	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	dev->base = devm_ioremap_resource(&pdev->dev, mem);
 	if (IS_ERR(dev->base))
 		return PTR_ERR(dev->base);
Signature · 1 line
1.8.2.rc0.22.gb3600c3

A message that is not in the archive (sent off-list or not yet received): 1370613449-29719-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]