Skip to contentSkip to conversation

ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)

PATCH New Peter Ujfalusi 2 participants 5 messages Jun 11, 2013 – Jun 12, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Peter Ujfalusi

author
#0 lore raw

cover ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)

Hi,

Small patches to silence the hwmod lookup failures in case when we boot the kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC, HDMI audio).

Regards,
Peter
---
Peter Ujfalusi (3):
ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup
fails

 arch/arm/mach-omap2/devices.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
Signature · 1 line
1.8.2.1
author
#1 lore raw

PATCH 1/3 ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails

It means that the SoC does not have McPDM IP.

Reported-by Paul Walmsley <[email protected]>
Signed-off-by Peter Ujfalusi <[email protected]>
---
 arch/arm/mach-omap2/devices.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-omap2/devices.c +1 -3
index 4269fc1..b82538d 100644
@@ -374,10 +374,8 @@ static void __init omap_init_mcpdm(void)
 	struct platform_device *pdev;
 
 	oh = omap_hwmod_lookup("mcpdm");
-	if (!oh) {
-		printk(KERN_ERR "Could not look up mcpdm hw_mod\n");
+	if (!oh)
 		return;
-	}
 
 	pdev = omap_device_build("omap-mcpdm", -1, oh, NULL, 0);
 	WARN(IS_ERR(pdev), "Can't build omap_device for omap-mcpdm.\n");
Signature · 1 line
1.8.2.1
author
#2 lore raw

PATCH 2/3 ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails

In reply to Peter Ujfalusi

It means that the SoC does not have DMIC IP
.

Reported-by Paul Walmsley <[email protected]>
Signed-off-by Peter Ujfalusi <[email protected]>
---
 arch/arm/mach-omap2/devices.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-omap2/devices.c +1 -3
index b82538d..8f268b4 100644
@@ -393,10 +393,8 @@ static void __init omap_init_dmic(void)
 	struct platform_device *pdev;
 
 	oh = omap_hwmod_lookup("dmic");
-	if (!oh) {
-		pr_err("Could not look up dmic hw_mod\n");
+	if (!oh)
 		return;
-	}
 
 	pdev = omap_device_build("omap-dmic", -1, oh, NULL, 0);
 	WARN(IS_ERR(pdev), "Can't build omap_device for omap-dmic.\n");
Signature · 1 line
1.8.2.1
author
#3 lore raw

PATCH 3/3 ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup fails

In reply to Peter Ujfalusi

The dss_hdmi hwmod is used to create the HDMI audio device for OMAP4+ When we boot the kernel we can silently ignore the failure since the IP does not exist on them.

Reported-by Paul Walmsley <[email protected]>
Signed-off-by Peter Ujfalusi <[email protected]>
---
 arch/arm/mach-omap2/devices.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-omap2/devices.c +1 -3
index 8f268b4..daa0ff6 100644
@@ -417,10 +417,8 @@ static void __init omap_init_hdmi_audio(void)
 	struct platform_device *pdev;
 
 	oh = omap_hwmod_lookup("dss_hdmi");
-	if (!oh) {
-		printk(KERN_ERR "Could not look up dss_hdmi hw_mod\n");
+	if (!oh)
 		return;
-	}
 
 	pdev = omap_device_build("omap-hdmi-audio-dai", -1, oh, NULL, 0);
 	WARN(IS_ERR(pdev),
Signature · 1 line
1.8.2.1
maintainer
#4 lore raw

cover ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)

In reply to Peter Ujfalusi
Quoted 5 lines · Peter Ujfalusi

Hi,

Small patches to silence the hwmod lookup failures in case when we boot the kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC, HDMI audio).

Thanks applying into omap-for-v3.11/fixes-non-critical.

Regards,

Tony

Quoted 12 lines

Peter Ujfalusi (3):
ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup
fails

 arch/arm/mach-omap2/devices.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
Signature · 1 line
1.8.2.1