RAPIDIO: Fix idt_gen2.c build
PATCH 1/1 RAPIDIO: Fix idt_gen2.c build
idt_gen2.c relies that one of the header files used will include <asm/page.h> which will define the required symbol PAGE_SIZE. On MIPS for example <asm/page.h> will not be included implicitly which will result in the following build error:
CC drivers/rapidio/switches/idt_gen2.odrivers/rapidio/switches/idt_gen2.c: In function ‘idtg2_show_errlog’:drivers/rapidio/switches/idt_gen2.c:379:30: error: ‘PAGE_SIZE’ undeclared (first use in this function) drivers/rapidio/switches/idt_gen2.c:379:30: note: each undeclared identifier is reported only once for each function it appears in
---
If you're ok with this patch I can put it into my next pull request for Linux. Thanks!
drivers/rapidio/switches/idt_gen2.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/rapidio/switches/idt_gen2.c +2 -0
@@ -15,6 +15,8 @@#include <linux/rio_drv.h> #include <linux/rio_ids.h> #include <linux/delay.h> + +#include <asm/page.h> #include "../rio.h" #define LOCAL_RTE_CONF_DESTID_SEL 0x010070
Looks good to me.
Quoted 34 lines
-----Original Message-----
From: Ralf Baechle [mailto:[email protected]]
Sent: Thursday, June 13, 2013 11:43 AM
To: Matt Porter; Bounine, Alexandre; [email protected]
Subject: [PATCH] RAPIDIO: Fixidt_gen2.cbuild
idt_gen2.crelies that one of the header files used will include <asm/page.h> which will define the required symbolPAGE_SIZE. On MIPS for example <asm/page.h> will not be included implicitly which will result in the following build error:CC
drivers/rapidio/switches/idt_gen2.odrivers/rapidio/switches/idt_gen2.c: In function ‘idtg2_show_errlog’:drivers/rapidio/switches/idt_gen2.c:379:30: error: ‘PAGE_SIZE’ undeclared (first use in this function)drivers/rapidio/switches/idt_gen2.c:379:30: note: each undeclared identifier is reported only once for each function it appears inSigned-off-by Ralf Baechle <[email protected]>---
If you're ok with this patch I can put it into my next pull request for Linux. Thanks!
drivers/rapidio/switches/idt_gen2.c | 2 ++ 1 file changed, 2 insertions(+)drivers/rapidio/switches/idt_gen2.c +0
-0
drivers/rapidio/switches/idt_gen2.c line 22
Quoted 8 lines
drivers/rapidio/switches/idt_gen2.c +2
-0@@ -15,6 +15,8 @@#include <linux/rio_drv.h> #include <linux/rio_ids.h> #include <linux/delay.h> + +#include <asm/page.h> #include "../rio.h" #define LOCAL_RTE_CONF_DESTID_SEL 0x010070
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�