Skip to contentSkip to conversation

arm: omap: board-overo: reset GPIO for SMSC911x

PATCH New Florian Vaussard 2 participants 2 messages May 21, 2013 – Jun 18, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Florian Vaussard

author
#0 lore raw

PATCH 1/1 arm: omap: board-overo: reset GPIO for SMSC911x

The reset GPIO should be set for the SMSC911x, otherwise the controller will not work and probing will fail. In the case of the tobi-duo expansion board, the second controller shares the same GPIO, thus no more changes are required (not tested).

Signed-off-by Florian Vaussard <[email protected]>
---
 arch/arm/mach-omap2/board-overo.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-overo.c +2 -1
index 4ca6b68..5748b5d 100644
@@ -68,6 +68,7 @@
 
 #define OVERO_SMSC911X_CS      5
 #define OVERO_SMSC911X_GPIO    176
+#define OVERO_SMSC911X_NRESET  64
 #define OVERO_SMSC911X2_CS     4
 #define OVERO_SMSC911X2_GPIO   65
 

@@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
 	.id		= 0,
 	.cs             = OVERO_SMSC911X_CS,
 	.gpio_irq       = OVERO_SMSC911X_GPIO,
-	.gpio_reset     = -EINVAL,
+	.gpio_reset     = OVERO_SMSC911X_NRESET,
 	.flags		= SMSC911X_USE_32BIT,
 };
Signature · 1 line
1.7.5.4
maintainer
#1 lore raw

PATCH 1/1 arm: omap: board-overo: reset GPIO for SMSC911x

Quoted 6 lines · Florian Vaussard

The reset GPIO should be set for the SMSC911x, otherwise the controller will not work and probing will fail. In the case of the tobi-duo expansion board, the second controller shares the same GPIO, thus no more changes are required (not tested).

Signed-off-by Florian Vaussard <[email protected]>

Thanks applying into omap-for-v3.11/board.

Regards,

Tony

Quoted 28 lines
---
 arch/arm/mach-omap2/board-overo.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-overo.c +2 -1
index 4ca6b68..5748b5d 100644
@@ -68,6 +68,7 @@
 
 #define OVERO_SMSC911X_CS      5
 #define OVERO_SMSC911X_GPIO    176
+#define OVERO_SMSC911X_NRESET  64
 #define OVERO_SMSC911X2_CS     4
 #define OVERO_SMSC911X2_GPIO   65
 

@@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
 	.id		= 0,
 	.cs             = OVERO_SMSC911X_CS,
 	.gpio_irq       = OVERO_SMSC911X_GPIO,
-	.gpio_reset     = -EINVAL,
+	.gpio_reset     = OVERO_SMSC911X_NRESET,
 	.flags		= SMSC911X_USE_32BIT,
 };
Signature · 1 line
1.7.5.4