Skip to contentSkip to conversation

ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

PATCH New Lokesh Vutla 3 participants 4 messages Jun 13, 2013 – Jun 18, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Lokesh Vutla

author
#0 lore raw

PATCH 1/1 ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

On 37xx EVM non-dt boot fails with current mainline, because of broken GPIO numbering in the board file that uses hardcoded GPIOs.

So marking omap3_evm_display_init() with CONFIG_BROKEN
for now as suggested by Tony as per the below link:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg90399.html

Signed-off-by Lokesh Vutla <[email protected]>
---
 arch/arm/mach-omap2/board-omap3evm.c |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-omap2/board-omap3evm.c +4 -0
index f76d0de..278bf25 100644
@@ -174,6 +174,7 @@ static struct panel_sharp_ls037v7dw01_data omap3_evm_lcd_data = {
 	.ud_gpio = OMAP3EVM_LCD_PANEL_UD,
 };
 
+#ifdef CONFIG_BROKEN
 static void __init omap3_evm_display_init(void)
 {
 	int r;

@@ -193,6 +194,7 @@ static void __init omap3_evm_display_init(void)
 	else
 		gpio_set_value_cansleep(OMAP3EVM_LCD_PANEL_BKLIGHT_GPIO, 1);
 }
+#endif
 
 static struct omap_dss_device omap3_evm_lcd_device = {
 	.name			= "lcd",

@@ -715,7 +717,9 @@ static void __init omap3_evm_init(void)
 
 	omap_ads7846_init(1, OMAP3_EVM_TS_GPIO, 310, NULL);
 	omap3evm_init_smsc911x();
+#ifdef CONFIG_BROKEN
 	omap3_evm_display_init();
+#endif
 	omap3_evm_wl12xx_init();
 	omap_twl4030_audio_init("omap3evm", NULL);
 }
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

Quoted 9 lines · Lokesh Vutla

On 37xx EVM non-dt boot fails with current mainline, because of broken GPIO numbering in the board file that uses hardcoded GPIOs.

So marking omap3_evm_display_init() with CONFIG_BROKEN
for now as suggested by Tony as per the below link:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg90399.html

Signed-off-by Lokesh Vutla <[email protected]> ---
Tested-by Paul Walmsley <[email protected]>

- Paul

maintainer
#2 lore raw

PATCH 1/1 ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

Quoted 6 lines · Paul Walmsley
Quoted 4 lines · Lokesh Vutla

On 37xx EVM non-dt boot fails with current mainline, because of broken GPIO numbering in the board file that uses hardcoded GPIOs.

Quoted 7 lines
Quoted 5 lines

So marking omap3_evm_display_init() with CONFIG_BROKEN
for now as suggested by Tony as per the below link:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg90399.html

Signed-off-by Lokesh Vutla <[email protected]> ---
Tested-by Paul Walmsley <[email protected]>

Thanks applying into omap-for-v3.11/board.

Regards,

Tony

#3 lore raw

PATCH 1/1 ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

Quoted 11 lines · Tony Lindgren
Quoted 10 lines · Paul Walmsley
Quoted 8 lines · Lokesh Vutla

On 37xx EVM non-dt boot fails with current mainline, because of broken GPIO numbering in the board file that uses hardcoded GPIOs.

So marking omap3_evm_display_init() with CONFIG_BROKEN
for now as suggested by Tony as per the below link:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg90399.html

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Lokesh Vutla <[email protected]> ---
Tested-by Paul Walmsley <[email protected]>

Thanks applying into omap-for-v3.11/board.

This one is probably a candidate for v3.10-rc... Otherwise 37xx EVM won't boot on v3.10.

- Paul