Patch for disktest: Handle long filenames more reasonably
Hi all (please CC as I'm not on the list)
I've been using disktest, but I found a less than optimal piece of code regarding the device names.
I'd like to contribute the following patch:
main.h 2013-06-17 16:10:08.725310241 +0200 renamed from main2.h 2013-06-17 16:21:26.585825912 +0200 +0 -0
@@ -54,7 +54,7 @@ #define BLKGETSIZE _IO(0x12,96) /* IOCTL for getting
the device size */
#define BLKSSZGET _IO(0x12,104) /* ALT IOCTL for getting the
device size */
-#define DEV_NAME_LEN 80 /* max character for
target name */
+#define DEV_NAME_LEN 256 /* max character for
target name */
#define MAX_ARG_LEN 160 /* max length
of command line arguments for startarg display */
#define HOSTNAME_SIZE 16 /* number of hostname
characters used in mark header */
#define BLK_SIZE 512 /* default size
of an LBA in bytes */
(or perhaps simply use PATH_MAX)
80 characters is way too much for devices like /dev/sdc, but easily too little for "/dev/disk/by-path/ip-172.16.15.51:3260-iscsi-iqn.2013-01.com.synology:srvnas1.02-lun-0" (that's a real device name, btw)
I know, iSCSI names are really long, but disktest should be able to handle it more gracefully. I got a really odd error ("could not open device") because the last handful of characters has been cut out.
Signature · 13 lines
Med venlig hilsen Christian Iversen ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 6 lines
Hi all (please CC as I'm not on the list)
I've been using disktest, but I found a less than optimal piece of code regarding the device names.
I'd like to contribute the following patch:
Could you please send signed patch that could be applied with 'git am' (best done with git format-patch or git send-email).
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list