xfs: Remove XFS_MOUNT_RETERR
PATCH v3 1/2 xfs: Remove XFS_MOUNT_RETERR
From: Jie Liu <[email protected]>
XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)" branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so we always be emitting a warning and returning an error.
Hence, we can remove it and get rid of a couple of redundant check up against it at xfs_upate_alignment().
Thanks Dave Chinner for the suggestions of simplify the code in xfs_parseargs().
--- fs/xfs/xfs_mount.c | 37 +++++++++++-------------------------- fs/xfs/xfs_mount.h | 2 -- fs/xfs/xfs_super.c | 11 +++-------- 3 files changed, 14 insertions(+), 36 deletions(-)
fs/xfs/xfs_mount.c +11 -26
@@ -872,42 +872,27 @@ xfs_update_alignment(xfs_mount_t *mp)*/ if ((BBTOB (mp->m_dalign) & mp->m_blockmask) || (BBTOB (mp->m_swidth) & mp->m_blockmask)) { -if (mp->m_flags &XFS_MOUNT_RETERR ) { -xfs_warn (mp,"alignment check failed: " -"(sunit/swidth vs. blocksize)" ); -return XFS_ERROR (EINVAL ); - } - mp->m_dalign = mp->m_swidth =0 ; +xfs_warn (mp, +"alignment check failed: sunit/swidth vs. blocksize(%d)" , + sbp->sb_blocksize); +return XFS_ERROR (EINVAL ); }else {/* * Convert the stripe unit and width to FSBs. */ mp->m_dalign =XFS_BB_TO_FSBT (mp, mp->m_dalign);if (mp->m_dalign && (sbp->sb_agblocks % mp->m_dalign)) { -if (mp->m_flags &XFS_MOUNT_RETERR ) { -xfs_warn (mp,"alignment check failed: " -"(sunit/swidth vs. ag size)" ); -return XFS_ERROR (EINVAL ); - }xfs_warn (mp, -"stripe alignment turned off: sunit(%d)/swidth(%d) " -"incompatible with agsize(%d)" , - mp->m_dalign, mp->m_swidth, - sbp->sb_agblocks); - - mp->m_dalign =0 ; - mp->m_swidth =0 ; +"alignment check failed: sunit/swidth vs. agsize(%d)" , + sbp->sb_agblocks); +return XFS_ERROR (EINVAL ); }else if (mp->m_dalign) { mp->m_swidth =XFS_BB_TO_FSBT (mp, mp->m_swidth); }else { -if (mp->m_flags &XFS_MOUNT_RETERR ) { -xfs_warn (mp,"alignment check failed: " -"sunit(%d) less than bsize(%d)" , - mp->m_dalign, - mp->m_blockmask +1 ); -return XFS_ERROR (EINVAL ); - } - mp->m_swidth =0 ; +xfs_warn (mp, +"alignment check failed: sunit(%d) less than bsize(%d)" , + mp->m_dalign, sbp->sb_blocksize); +return XFS_ERROR (EINVAL ); } }
fs/xfs/xfs_mount.h +0 -2
@@ -228,8 +228,6 @@ typedef struct xfs_mount {operations, typically for disk errors in metadata */ #define XFS_MOUNT_DISCARD (1ULL << 5)/* discard unused blocks */ -#define XFS_MOUNT_RETERR (1ULL << 6)/* return alignment errors to -user */ #define XFS_MOUNT_NOALIGN (1ULL << 7)/* turn off stripe alignment allocations */ #define XFS_MOUNT_ATTR2 (1ULL << 8)/* allow use of attr2 format */
fs/xfs/xfs_super.c +3 -8
@@ -439,20 +439,15 @@ xfs_parseargs( } done: -if (!(mp->m_flags &XFS_MOUNT_NOALIGN )) { +if (dsunit && !(mp->m_flags &XFS_MOUNT_NOALIGN )) {/* * At this point the superblock has not been read * in, therefore we do not know the block size. * Before the mount call ends we will convert * these to FSBs. */ -if (dsunit) { - mp->m_dalign = dsunit; - mp->m_flags |=XFS_MOUNT_RETERR ; - } - -if (dswidth) - mp->m_swidth = dswidth; + mp->m_dalign = dsunit; + mp->m_swidth = dswidth; } if (mp->m_logbufs != -1 &&
Signature · 6 lines
1.7.9.5 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Jeff Liu
From: Jie Liu<[email protected]>
XFS_MOUNT_RETERRis going to be set atxfs_parseargs()ifmp->m_dalignis enabled, so any time we enter "if (mp->m_dalign)" branch inxfs_update_alignment(),XFS_MOUNT_RETERRis set and so we always be emitting a warning and returning an error.
Quoted 7 lines
Hence, we can remove it and get rid of a couple of redundant check up against it at
xfs_upate_alignment().Thanks Dave Chinner for the suggestions of simplify the code in
xfs_parseargs().Signed-off-by Jie Liu<[email protected]>
"alignment check failed: sunit/swidth vs. blocksize(%d)",
^^^^
"alignment check failed: sunit/swidth vs. agsize(%d)",
^^^^
"alignment check failed: sunit(%d) less than bsize(%d)",
^^^^ ^^^^I know you copied these statements verbatim, but I wonder why all these statements do not have a space between the type and value?
Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 16 lines · Mark Tinguely
Quoted 7 lines · Jeff Liu
From: Jie Liu<[email protected]>
XFS_MOUNT_RETERRis going to be set atxfs_parseargs()ifmp->m_dalignis enabled, so any time we enter "if (mp->m_dalign)" branch inxfs_update_alignment(),XFS_MOUNT_RETERRis set and so we always be emitting a warning and returning an error.Quoted 7 lines
Hence, we can remove it and get rid of a couple of redundant check up against it at
xfs_upate_alignment().Thanks Dave Chinner for the suggestions of simplify the code in
xfs_parseargs().Signed-off-by Jie Liu<[email protected]>
Quoted 8 lines
"alignment check failed: sunit/swidth vs. blocksize(%d)",
^^^^ "alignment check failed: sunit/swidth vs. agsize(%d)", ^^^^ "alignment check failed: sunit(%d) less than bsize(%d)", ^^^^ ^^^^I know you copied these statements verbatim, but I wonder why all these statements do not have a space between the type and value?
Looks the old statements violate the above rule(don't have a space between them) as there are many places formating the statements with a space.
Thanks,
-Jeff
Quoted 10 lines
Looks good.
Reviewed-by Mark Tinguely <[email protected]>_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Ben Myers
AppliedQuoted 10 lines · Jeff Liu
From: Jie Liu <[email protected]>
XFS_MOUNT_RETERRis going to be set atxfs_parseargs()ifmp->m_dalignis enabled, so any time we enter "if (mp->m_dalign)" branch inxfs_update_alignment(),XFS_MOUNT_RETERRis set and so we always be emitting a warning and returning an error.Hence, we can remove it and get rid of a couple of redundant check up against it at
xfs_upate_alignment().
Quoted 6 lines
Thanks Dave Chinner for the suggestions of simplify the code in
xfs_parseargs().Signed-off-by Jie Liu <[email protected]>Cc Dave Chinner <[email protected]>Cc Mark Tinguely <[email protected]>
Applied.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs