Skip to contentSkip to conversation

softirq: weaken warning in local_bh_enable_ip()

PATCH In review Joern Engel 1 participant 2 messages Jun 19, 2013 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softirq: weaken warning in local_bh_enable_ip()

This reliably triggers with the following backtrace:

local_bh_enable_ip+0x128/0x140
_raw_spin_unlock_bh+0x15/0x20
iscsit_inc_conn_usage_count+0x37/0x50 [iscsi_target_mod]
iscsit_stop_session+0x1db/0x280 [iscsi_target_mod]
lio_tpg_shutdown_session+0xb2/0xf0 [iscsi_target_mod]
core_tpg_set_initiator_node_queue_depth+0x119/0x2f0 [target_core_mod]
iscsit_tpg_set_initiator_node_queue_depth+0x12/0x20 [iscsi_target_mod]
lio_target_nacl_store_cmdsn_depth+0x110/0x1e0 [iscsi_target_mod]
target_fabric_nacl_base_attr_store+0x39/0x40 [target_core_mod]
configfs_write_file+0xbd/0x120
vfs_write+0xc6/0x180
sys_write+0x51/0x90
system_call_fastpath+0x16/0x1b

core_tpg_set_initiator_node_queue_depth() calls lio_tpg_shutdown_session() inside a spin_lock_irqsave-protected block. Calling spin_unlock_bh later in the call chain always triggers the warning.

Cc Johannes Berg <[email protected]>
Cc Michael Buesch <[email protected]>
Cc David Ellingsworth <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "Nicholas A. Bellinger" <[email protected]>
---
 kernel/softirq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/softirq.c +1 -1
index 14d7758..d4ee1c6 100644
@@ -157,7 +157,7 @@ EXPORT_SYMBOL(_local_bh_enable);
 
 static inline void _local_bh_enable_ip(unsigned long ip)
 {
-	WARN_ON_ONCE(in_irq() || irqs_disabled());
+	WARN_ON_ONCE(in_irq());
 #ifdef CONFIG_TRACE_IRQFLAGS
 	local_irq_disable();
 #endif
Signature · 1 line
1.7.10.4

A message that is not in the archive (sent off-list or not yet received): CA+55aFyBL9S9y=kpBte67PfO6EaB79CP3JtMP3KwMWQfo3PrFg@mail.gmail.com

#2 lore raw
Quoted 3 lines · Linus Torvalds

No the warning is correct, the SCSI target code needs to be fixed. You cannot call spin_unlock_bh with interrupts disabled.

That sounds like something coverity could be taught with reasonable effort - if someone from them is listening. Not sure if sparse has enough context to do the same.

Just to play thick and make things ultra-clear, you say the following pattern is never legal, correct?

spin_lock_irq(save)
...
spin_lock_bh
...
spin_unlock_bh
...
spin_unlock_irq(restore)

Quoted 1 line

So fix the code, don't weaken the warning.

Will do.

Jörn

--
The only real mistake is the one from which we learn nothing. -- John Powell