imx53-qsb: enable usb power
PATCH 1/1 imx53-qsb: enable usb power
An embedded and charset-unspecified text was scrubbed...
Name: imx53-qsb-usb-power.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130620/749dd8d2/attachment.ksh>
PATCH 1/1 imx53-qsb: enable usb power
Quoted 11 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Signed-off-by Arnaud Patard <[email protected]>Index:
linux-next/arch/arm/boot/dts/imx53-qsb.dts
===================================================================arch/arm/boot/dts/imx53-qsb.dts +0
-0@@ -93,6 +93,15 @@ regulator-max-microvolt = <3200000>; regulator-always-on;
arch/arm/boot/dts/imx53-qsb.dts line 104
Quoted 10 lines
arch/arm/boot/dts/imx53-qsb.dts +9
-0}; + + reg_usbpwr: usbpwr { + compatible = "regulator-fixed"; + regulator-name = "usbpwr"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio7 8 0>; + regulator-always-on; + };
Shouldn't this be provided to the chipidea driver as vbus?
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 imx53-qsb: enable usb power
Quoted 16 lines · Sascha Hauer
Quoted 15 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Signed-off-by Arnaud Patard <[email protected]>Index:
linux-next/arch/arm/boot/dts/imx53-qsb.dts
===================================================================arch/arm/boot/dts/imx53-qsb.dts +3
-0@@ -93,6 +93,15 @@ regulator-max-microvolt = <3200000>; regulator-always-on; }; + + reg_usbpwr: usbpwr { + compatible = "regulator-fixed";
Quoted 8 lines
arch/arm/boot/dts/imx53-qsb.dts line 104
Quoted 6 lines
arch/arm/boot/dts/imx53-qsb.dts +6
-0+ regulator-name = "usbpwr"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio7 8 0>; + regulator-always-on; + };Shouldn't this be provided to the chipidea driver as vbus?
I'm not sure about that. This gpio is controlling the usb power for the 2 usb ports while the vbus is more a port-basis thing.
Arnaud
PATCH 1/1 imx53-qsb: enable usb power
In reply to Arnaud Patard (Rtp)Quoted 4 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Signed-off-by Arnaud Patard <[email protected]>
Could you please test this against linux-next?
It does not work for me:
usbcore: registered new interface driver usb-storage platform 53f80000.usb: Driver imx_usb requests probe deferral platform 53f80200.usb: Driver imx_usb requests probe deferral
PATCH 1/1 imx53-qsb: enable usb power
Quoted 7 lines · Fabio Estevam
Quoted 4 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Signed-off-by Arnaud Patard <[email protected]>
Quoted 7 lines
Could you please test this against linux-next?
It does not work for me:
usbcore: registered new interface driver usb-storage platform 53f80000.usb: Driver
imx_usbrequests probe deferral platform 53f80200.usb: Driverimx_usbrequests probe deferral
Ok, got it working now, but had to do two changes:
- Add a vbus-supply node for usbh1 as suggested by Sascha
- Select CONFIG_NOP_USB_XCEIV. Will send a patch to select it by default.
PATCH 1/1 imx53-qsb: enable usb power
Quoted 12 lines · Fabio Estevam
Quoted 11 lines · Fabio Estevam
Quoted 4 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Signed-off-by Arnaud Patard <[email protected]>Could you please test this against linux-next?
It does not work for me:
Quoted 7 lines
Quoted 3 lines
usbcore: registered new interface driver usb-storage platform 53f80000.usb: Driver
imx_usbrequests probe deferral platform 53f80200.usb: Driverimx_usbrequests probe deferralOk, got it working now, but had to do two changes:
- Add a vbus-supply node for usbh1 as suggested by Sascha
How do you want to proceed ? send a patch on top of mine or send a new patch containing my patch and this change ? ( I guess that the later would be easier)
btw, now that it seems that some more stuff has been merged in chipidea are in next, what about enabling the second port ?
Arnaud
PATCH 1/1 imx53-qsb: enable usb power
Quoted 3 lines · Arnaud Patard
How do you want to proceed ? send a patch on top of mine or send a new patch containing my patch and this change ? ( I guess that the later would be easier)
It would be nice if you could send a v2 of your patch adding the vbus_supply node.
Quoted 3 lines
btw, now that it seems that some more stuff has been merged in chipidea are in next, what about enabling the second port ?
That would be nice as well, please send a patch for it if you have a chance.
PATCH 1/1 imx53-qsb: enable usb power
In reply to Arnaud Patard (Rtp)Quoted 2 lines · Arnaud Patard
Enable usb power pin by using a fixed regulator. With this and the usb clock patch is making usb working on my loco.
Which "usb clock patch" are you referring to?