gvfs: Select and depend on libgcrypt

PATCH New Markos Chandras 2 participants 4 messages Jun 21, 2013

lore

Share & tools

lore

Markos Chandras

author

2013-06-21 10:20 UTC #0 lore raw

PATCH 1/1 gvfs: Select and depend on libgcrypt

From: Markos Chandras <[email protected]>

Fixes the following build problem when building gvfs without having libgcrypt installed.

gvfsbackendafpbrowse.c:31:20: fatal error: gcrypt.h: No such file or directory

Signed-off-by Markos Chandras <[email protected]>

---
 package/gvfs/Config.in | 1 +
 package/gvfs/gvfs.mk   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

package/gvfs/Config.in +1 -0

index e0a945e..3791830 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_GVFS
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_USE_MMU # dbus
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
+	select BR2_PACKAGE_LIBGCRYPT
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_SHARED_MIME_INFO

package/gvfs/gvfs.mk +1 -1

index d99c784..0a2eece 100644
@@ -10,7 +10,7 @@ GVFS_VERSION = $(GVFS_VERSION_MAJOR).$(GVFS_VERSION_MINOR)
 GVFS_SOURCE = gvfs-$(GVFS_VERSION).tar.xz
 GVFS_SITE = http://ftp.gnome.org/pub/GNOME/sources/gvfs/$(GVFS_VERSION_MAJOR)
 GVFS_INSTALL_STAGING = YES
-GVFS_DEPENDENCIES = host-pkgconf host-libglib2 libglib2 dbus shared-mime-info
+GVFS_DEPENDENCIES = host-pkgconf host-libglib2 libgcrypt libglib2 dbus shared-mime-info
 
 GVFS_CONF_OPT = \
 	--disable-gconf			\

Signature · 1 line

1.8.2.1

Thomas Petazzoni

2013-06-21 10:31 UTC #1 lore raw

PATCH 1/1 gvfs: Select and depend on libgcrypt

Dear Markos Chandras,

Quoted 4 lines · Markos Chandras

Fixes the following build problem when building gvfs without having libgcrypt installed.
gvfsbackendafpbrowse.c:31:20: fatal error: gcrypt.h: No such file or directory

This seems strange because:

#ifdef HAVE_GCRYPT
#include <gcrypt.h>
#endif

in gvfsbackendafpbrowse.c.

Maybe there's a mis-detection of the gcrypt on your host and we need to make sure gvfs doesn't try to detect gcrypt when it is not part of the enabled packages. I am quite sure I did a build of gvfs 1.16.2 without gcrypt support, but the machine didn't had the gcrypt development files installed in the distribution.

Thanks,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Markos Chandras

author

2013-06-21 10:33 UTC #2 lore raw

PATCH 1/1 gvfs: Select and depend on libgcrypt

Quoted 15 lines · Thomas Petazzoni

Dear Markos Chandras,
Quoted 4 lines · Markos Chandras
Fixes the following build problem when building gvfs without having libgcrypt installed.
gvfsbackendafpbrowse.c:31:20: fatal error: gcrypt.h: No such file or directory
This seems strange because:
#ifdef HAVE_GCRYPT
#include <gcrypt.h>
#endif

Quoted 7 lines

in gvfsbackendafpbrowse.c.
Maybe there's a mis-detection of the gcrypt on your host and we need to make sure gvfs doesn't try to detect gcrypt when it is not part of the enabled packages. I am quite sure I did a build of gvfs 1.16.2 without gcrypt support, but the machine didn't had the gcrypt development files installed in the distribution.

Hi Thomas,

I will have a look in the build files. I have libgcrypt installed on the host so maybe it detects this one and fails.

--
Regards,
Markos Chandras

Markos Chandras

author

2013-06-21 12:49 UTC #3 lore raw

PATCH 1/1 gvfs: Select and depend on libgcrypt

Quoted 25 lines · Markos Chandras

Quoted 15 lines · Thomas Petazzoni
Dear Markos Chandras,
Quoted 4 lines · Markos Chandras
Fixes the following build problem when building gvfs without having libgcrypt installed.
gvfsbackendafpbrowse.c:31:20: fatal error: gcrypt.h: No such file or directory
This seems strange because:
#ifdef HAVE_GCRYPT
#include <gcrypt.h>
#endif
Quoted 7 lines
in gvfsbackendafpbrowse.c.
Maybe there's a mis-detection of the gcrypt on your host and we need to make sure gvfs doesn't try to detect gcrypt when it is not part of the enabled packages. I am quite sure I did a build of gvfs 1.16.2 without gcrypt support, but the machine didn't had the gcrypt development files installed in the distribution.

Quoted 8 lines

Hi Thomas,
I will have a look in the build files. I have libgcrypt installed on the host so maybe it detects this one and fails.
--
Regards,
Markos Chandras

Indeed, it seems the host libgcrypt is picked if there is not one for the target

configure:18751: checking for mips-buildroot-linux-uclibc-libgcrypt-config configure:18784: result: no
configure:18794: checking for libgcrypt-config configure:18812: found /usr/bin/libgcrypt-config configure:18824: result: /usr/bin/libgcrypt-config configure:18836: WARNING: using cross tools not prefixed with host triplet

I will have a look on how to fix this

--
Regards,
Markos Chandras