Skip to contentSkip to conversation

ipv6: don't disable interface if last ipv6 address is removed

PATCH Applied Hannes Frederic Sowa 2 participants 2 messages Jun 23, 2013 – Jun 25, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipv6: don't disable interface if last ipv6 address is removed

The reason behind this change is that as soon as we delete the last ipv6 address of an interface we also lose the /proc/sys/net/ipv6/conf/<interface> directory. This seems to be a usability problem for me.

I don't see any reason why we should shutdown ipv6 on that interface in such cases.

---
 net/ipv6/addrconf.c | 6 ------
 1 file changed, 6 deletions(-)
net/ipv6/addrconf.c +0 -6
index 8044912..3c1c789 100644
@@ -2502,12 +2502,6 @@ static int inet6_addr_del(struct net *net, int ifindex, const struct in6_addr *p
 			read_unlock_bh(&idev->lock);
 
 			ipv6_del_addr(ifp);
-
-			/* If the last address is deleted administratively,
-			   disable IPv6 on this interface.
-			 */
-			if (list_empty(&idev->addr_list))
-				addrconf_ifdown(idev->dev, 1);
 			return 0;
 		}
 	}
Signature · 1 line
1.8.1.4
maintainer Applied
#1 lore raw

From: Hannes Frederic Sowa <[email protected]>
Date: Mon, 24 Jun 2013 00:22:20 +0200

Quoted 10 lines

The reason behind this change is that as soon as we delete the last ipv6 address of an interface we also lose the /proc/sys/net/ipv6/conf/<interface> directory. This seems to be a usability problem for me.

I don't see any reason why we should shutdown ipv6 on that interface in such cases.

Applied.