Skip to contentSkip to conversation

ARM: at91/PMC: some fixes for clock functionalies

PATCH In review Nicolas Ferre 3 participants 8 messages Jun 24, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Nicolas Ferre

author
#0 lore raw

cover ARM: at91/PMC: some fixes for clock functionalies

It seems that some errors where made when affecting some functionalies to SoCs.

Please review this quickly as I do want to send these fixes for next merge window with will open soon.

Best regards,

Nicolas Ferre (3):
ARM: at91/PMC: sama5d3 family doesn't have a PLLB
ARM: at91/PMC: at91sam9n12 family have a PLLB
ARM: at91/PMC: at91sam9n12 family has USB HS feature

 arch/arm/mach-at91/clock.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.2.2
author
#1 lore raw

PATCH 1/3 ARM: at91/PMC: sama5d3 family doesn't have a PLLB

Signed-off-by Nicolas Ferre <[email protected]>
---
 arch/arm/mach-at91/clock.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-at91/clock.c +2 -1
index da84188..085a79d 100644
@@ -75,7 +75,8 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
 #define cpu_has_pllb()		(!(cpu_is_at91sam9rl() \
 				|| cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
-				|| cpu_is_at91sam9n12()))
+				|| cpu_is_at91sam9n12() \
+				|| cpu_is_sama5d3()))
 
 #define cpu_has_upll()		(cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
Signature · 1 line
1.8.2.2
#2 lore raw

PATCH 1/3 ARM: at91/PMC: sama5d3 family doesn't have a PLLB

Quoted 1 line · Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
Acked-by Ludovic Desroches <[email protected]>
Quoted 21 lines
---
 arch/arm/mach-at91/clock.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-at91/clock.c +2 -1
index da84188..085a79d 100644
@@ -75,7 +75,8 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
 #define cpu_has_pllb()		(!(cpu_is_at91sam9rl() \
 				|| cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
-				|| cpu_is_at91sam9n12()))
+				|| cpu_is_at91sam9n12() \
+				|| cpu_is_sama5d3()))
 
 #define cpu_has_upll()		(cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
Signature · 1 line
1.8.2.2
author
#3 lore raw

PATCH 2/3 ARM: at91/PMC: at91sam9n12 family have a PLLB

In reply to Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
---
 arch/arm/mach-at91/clock.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-at91/clock.c +0 -1
index 085a79d..978de42 100644
@@ -75,7 +75,6 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
 #define cpu_has_pllb()		(!(cpu_is_at91sam9rl() \
 				|| cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
-				|| cpu_is_at91sam9n12() \
 				|| cpu_is_sama5d3()))
 
 #define cpu_has_upll()		(cpu_is_at91sam9g45() \
Signature · 1 line
1.8.2.2
Acked-by on v1 2/3
#4 lore raw

Re: [PATCH 2/3] ARM: at91/PMC: at91sam9n12 family have a PLLB

Quoted 1 line · Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
Acked-by Bo Shen <[email protected]>
Quoted 17 lines
---
  arch/arm/mach-at91/clock.c | 1 -
  1 file changed, 1 deletion(-)
arch/arm/mach-at91/clock.c +0 -1
index 085a79d..978de42 100644
@@ -75,7 +75,6 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
  #define cpu_has_pllb()		(!(cpu_is_at91sam9rl() \
  				|| cpu_is_at91sam9g45() \
  				|| cpu_is_at91sam9x5() \
-				|| cpu_is_at91sam9n12() \
  				|| cpu_is_sama5d3()))
 
  #define cpu_has_upll()		(cpu_is_at91sam9g45() \
author
#5 lore raw

PATCH 3/3 ARM: at91/PMC: at91sam9n12 family has USB HS feature

In reply to Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
---
 arch/arm/mach-at91/clock.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-at91/clock.c +1 -0
index 978de42..1b9bbba 100644
@@ -88,6 +88,7 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
 #define cpu_has_udpfs()		(!(cpu_is_at91sam9rl() \
 				|| cpu_is_at91sam9g45() \
 				|| cpu_is_at91sam9x5() \
+				|| cpu_is_at91sam9n12() \
 				|| cpu_is_sama5d3()))
 
 #define cpu_has_plladiv2()	(cpu_is_at91sam9g45() \
Signature · 1 line
1.8.2.2
#6 lore raw

Re: [PATCH 3/3] ARM: at91/PMC: at91sam9n12 family has USB HS feature

Hi Nicolas,

Quoted 10 lines · Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
---
  arch/arm/mach-at91/clock.c | 1 +
  1 file changed, 1 insertion(+)
arch/arm/mach-at91/clock.c +0 -0
index 978de42..1b9bbba 100644

arch/arm/mach-at91/clock.c EXPORT_SYMBOL_GPL(at91_pmc_base); · line 92

Quoted 5 lines
arch/arm/mach-at91/clock.c +1 -0
@@ -88,6 +88,7 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
  #define cpu_has_udpfs()		(!(cpu_is_at91sam9rl() \
  				|| cpu_is_at91sam9g45() \
  				|| cpu_is_at91sam9x5() \
+				|| cpu_is_at91sam9n12() \
  				|| cpu_is_sama5d3()))

The at91sam9n12 don't have USB HS device port feature. It only has USB FS device port feature.

arch/arm/mach-at91/clock.c EXPORT_SYMBOL_GPL(at91_pmc_base); · line 94

Quoted 2 lines
arch/arm/mach-at91/clock.c +0 -0
  #define cpu_has_plladiv2()	(cpu_is_at91sam9g45() \

Best Regards,
Bo Shen

author
#7 lore raw

Re: [PATCH 3/3] ARM: at91/PMC: at91sam9n12 family has USB HS feature

On 24/06/2013 12:46, Bo Shen :

Quoted 8 lines

Hi Nicolas,

Quoted 5 lines · Nicolas Ferre
Signed-off-by Nicolas Ferre <[email protected]>
---
  arch/arm/mach-at91/clock.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 13 lines

arch/arm/mach-at91/clock.c EXPORT_SYMBOL_GPL(at91_pmc_base); · line 92

Quoted 10 lines
arch/arm/mach-at91/clock.c +1 -0
index 978de42..1b9bbba 100644
@@ -88,6 +88,7 @@ EXPORT_SYMBOL_GPL(at91_pmc_base);
  #define cpu_has_udpfs()        (!(cpu_is_at91sam9rl() \
                  || cpu_is_at91sam9g45() \
                  || cpu_is_at91sam9x5() \
+                || cpu_is_at91sam9n12() \
                  || cpu_is_sama5d3()))

The at91sam9n12 don't have USB HS device port feature. It only has USB FS device port feature.

OMG! sure ;-)

So I remove this patch from my series (sorry for the noise ;-))

Quoted 6 lines

arch/arm/mach-at91/clock.c EXPORT_SYMBOL_GPL(at91_pmc_base); · line 94

Quoted 3 lines
arch/arm/mach-at91/clock.c +0 -0
  #define cpu_has_plladiv2()    (cpu_is_at91sam9g45() \

Best Regards,
Bo Shen

Thanks! bye.

Signature · 1 line
Nicolas Ferre