Skip to contentSkip to conversation

Charge at least one credit, if server says that it supports multicredit

CIFS Dan Carpenter 2 participants 2 messages Jun 24, 2013 – Jun 26, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello Steve French,

This is a semi-automatic email about new static checker warnings.

The patch 7f420cee8bd6: "[CIFS] Charge at least one credit, if server says that it supports multicredit" from Jun 23, 2013, leads to the following Smatch complaint:

fs/cifs/smb2pdu.c:120 smb2_hdr_assemble()

	 warn: variable dereferenced before check 'tcon->ses' (see line 115)

fs/cifs/smb2pdu.c
114 if (tcon->ses->server->capabilities & SMB2_GLOBAL_CAP_LARGE_MTU)

                    ^^^^^^^^^^^

New dereference.

115 hdr->CreditCharge = cpu_to_le16(1);
116 /* else CreditCharge MBZ */
117
118 hdr->TreeId = tcon->tid;
119 /* Uid is not converted */
120 if (tcon->ses)

                    ^^^^^^^^^

Old check.

121 hdr->SessionId = tcon->ses->Suid;
122 /* BB check following DFS flags BB */

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Fixed. Thanks for pointing this out

Author: Steve French <[email protected]>
Date:   Wed Jun 26 17:52:17 2013 -0500

[CIFS] fix static checker warning

Dan Carpenter wrote:

The patch 7f420cee8bd6: "[CIFS] Charge at least one credit, if server says that it supports multicredit" from Jun 23, 2013, leads to the following Smatch complaint:

fs/cifs/smb2pdu.c:120 smb2_hdr_assemble()
warn: variable dereferenced before check 'tcon->ses' (see line 115)

fs/cifs/smb2pdu.c +2 -1
index f9b74da..53275bf 100644
@@ -111,7 +111,8 @@ smb2_hdr_assemble(struct smb2_hdr *hdr, __le16 smb2_cmd /* c
        /* BB FIXME when we do write > 64K add +1 for every 64K in req or rsp */
        /* GLOBAL_CAP_LARGE_MTU will only be set if dialect > SMB2.02 */
        /* See sections 2.2.4 and 3.2.4.1.5 of MS-SMB2 */
-       if (tcon->ses->server->capabilities & SMB2_GLOBAL_CAP_LARGE_MTU)
+       if ((tcon->ses) &&
+           (tcon->ses->server->capabilities & SMB2_GLOBAL_CAP_LARGE_MTU))
                hdr->CreditCharge = cpu_to_le16(1);
        /* else CreditCharge MBZ */
 
Quoted 30 lines · Dan Carpenter

Hello Steve French,

This is a semi-automatic email about new static checker warnings.

The patch 7f420cee8bd6: "[CIFS] Charge at least one credit, if server says that it supports multicredit" from Jun 23, 2013, leads to the following Smatch complaint:

fs/cifs/smb2pdu.c:120 smb2_hdr_assemble()

         warn: variable dereferenced before check 'tcon->ses' (see line 115)

fs/cifs/smb2pdu.c
114 if (tcon->ses->server->capabilities & SMB2_GLOBAL_CAP_LARGE_MTU)

                    ^^^^^^^^^^^

New dereference.

   115                  hdr->CreditCharge = cpu_to_le16(1);
   116          /* else CreditCharge MBZ */
   117
   118          hdr->TreeId = tcon->tid;
   119          /* Uid is not converted */
   120          if (tcon->ses)
                    ^^^^^^^^^

Old check.

121 hdr->SessionId = tcon->ses->Suid;
122 /* BB check following DFS flags BB */

regards,
dan carpenter

Signature · 3 lines
Thanks,

Steve