Skip to contentSkip to conversation

mmap/mmap13.c: new case to test SIGBUS error of mmap

PATCH [email protected] 1 participant 2 messages Jun 24, 2013 – Jul 1, 2013 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi!

Quoted 9 lines

Test SIGBUS error by accessing to a portion of the buffer that does not correspond to the file.

---
 runtest/syscalls                        |   1 +
 testcases/kernel/syscalls/mmap/mmap13.c | 152 ++++++++++++++++++++++++++++++++
 2 files changed, 153 insertions(+)
 create mode 100644 testcases/kernel/syscalls/mmap/mmap13.c

...

Review

Quoted 3 lines
(quoted diff) +3 -0
+
+		addr = mmap(0, page_sz * 2, PROT_READ | PROT_WRITE,
+			    MAP_FILE | MAP_SHARED, fildes, 0);

The first parameter should really have been NULL, pushed with that change, thanks.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi!

Quoted 10 lines
Quoted 4 lines

Test SIGBUS error by accessing to a portion of the buffer that does not correspond to the file.

v2 looks good to me. As for others, ../.gitignore is missing "mmap13", but I think comitter can add that.

I've commited this one allready (along with another patch to add it to gitignore (as I noticed this later)).

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list