Skip to contentSkip to conversation

nfsd dropping requests after lazy umount

DISCUSSION Malahal Naineni 2 participants 2 messages Jun 25, 2013 – Jul 1, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi All,

I have found an issue with lazy/forced unmounts with nfsd. Let us say /nfs is a mount point, and we are exporting /nfs/exp directory.

After mounting from a client, this export will have a cache entry "svc_export" in the kernel. The exports pathname d_path(svc_export->ex_path) correctly resolves to "/nfs/exp"

After the /nfs is lazy unmounted, the d_path(svc_export->ex_path) resolves to "/exp" only.

Now, if the cache entry needs revalidation, you will see "/exp" in the nfsd.export/channel file that never gets cleared as that cache entry will be in a forever CACHE_PENDING state. We will also see svc_export_parse() failing with -2 err as such a pathname doesn't exist in the system any more.

I noticed that svc_export has two fields: ex_path and ex_pathname. Is it possible to make a string comparison of d_path(ex_path) and ex_pathname? If so, we should be able to fail the upcall without making the upcall if those two don't match.

Regards, Malahal.

#1 lore raw
Quoted 9 lines · Malahal Naineni

Hi All,

I have found an issue with lazy/forced unmounts with nfsd. Let us say /nfs is a mount point, and we are exporting /nfs/exp directory.

After mounting from a client, this export will have a cache entry "svc_export" in the kernel. The exports pathname d_path(svc_export->ex_path) correctly resolves to "/nfs/exp"

Quoted 8 lines

After the /nfs is lazy unmounted, the d_path(svc_export->ex_path) resolves to "/exp" only.

Now, if the cache entry needs revalidation, you will see "/exp" in the nfsd.export/channel file that never gets cleared as that cache entry will be in a forever CACHE_PENDING state. We will also see svc_export_parse() failing with -2 err as such a pathname doesn't exist in the system any more.

So, mountd is trying to do a downcall for "/exp" but it's failing because the kern_path("/exp",.,.) fails?

Quoted 1 line

I noticed that svc_export has two fields: ex_path and ex_pathname.

Not any more--see 2f1ddda1749a223d1a05e16dc6ea28632b9ec570 "NFSD: Remove the ex_pathname field from struct svc_export".

--b.

Quoted 7 lines

Is
it possible to make a string comparison of d_path(ex_path) and ex_pathname? If so, we should be able to fail the upcall without making the upcall if those two don't match.

Regards, Malahal.