xfstests: fix README, FSTYP options
PATCH 1/1 xfstests: fix README, FSTYP options
commit cbcc88fb changed test selection to use shell globs, so fixup the examples given in the README file.
add options for FSTYPs supported by _scratch_mkfs().
--- README | 5 +++-- check | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-)
README +3 -2
@@ -81,9 +81,10 @@ Running tests: - cd xfstests - By default the tests suite will run xfs tests: - - ./check 001 002 003 ... or you can explicitly run a filesystem: + - ./check '*/001' '*/002' '*/003' + - ./check '*/06?' + - You can explicitly specify a filesystem (btrfs, ext4, nfs, udf, xfs): ./check -xfs [test(s)] - - You can run a range of tests: ./check 067-078 - Groups of tests maybe ran by: ./check -g [group(s)] See the 'group' file for details on groups - for udf tests: ./check -udf [test(s)]
check +3 -1
@@ -159,9 +159,11 @@ while [ $# -gt 0 ]; do case "$1" in -\? | -h | --help) usage ;; + -btrfs) FSTYP=btrfs ;; + -ext4) FSTYP=ext4 ;; + -nfs) FSTYP=nfs ;; -udf) FSTYP=udf ;; -xfs) FSTYP=xfs ;; - -nfs) FSTYP=nfs ;; -g) group=$2 ; shift ; group_list=$(get_group_list $group)
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 4 lines · Dwight Engen
commit
cbcc88fbchanged test selection to use shell globs, so fixup the examples given in the README file.add options for FSTYPs supported by
_scratch_mkfs().
To tell the truth, I'd prefer to get rid of the -xfs/-udf/... etc options rather than propoagate them further. We autodetect the FSTYP just fine on Linux via blkid probing of $TEST_DEV. Hence in reality, the only CLI option we need is for NFS...
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · On Wed, 26 Jun 2013 10:50:29 +1000 Dave Chinner <[email protected]> wrote:
Quoted 4 lines · Dwight Engen
commit
cbcc88fbchanged test selection to use shell globs, so fixup the examples given in the README file.add options for FSTYPs supported by
_scratch_mkfs().To tell the truth, I'd prefer to get rid of the -xfs/-udf/... etc options rather than propoagate them further. We autodetect the FSTYP just fine on Linux via blkid probing of $TEST_DEV. Hence in reality, the only CLI option we need is for NFS...
Yep, I realized there was autodetection (nice!) later. I'll resubmit with only NFS in the list.
Quoted 3 lines
Cheers,
Dave.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
PATCH v2 1/1 xfstests: fix README, FSTYP options
In reply to Dave Chinnercommit cbcc88fb changed test selection to use shell globs, so fixup the examples given in the README file.
remove options for FSTYP other than NFS since the FSTYP will be automatically detected (on Linux) from $TEST_DEV.
--- README | 8 +++++--- check | 4 ---- 2 files changed, 5 insertions(+), 7 deletions(-)
README +5 -3
@@ -81,9 +81,11 @@ Running tests: - cd xfstests - By default the tests suite will run xfs tests: - - ./check 001 002 003 ... or you can explicitly run a filesystem: - ./check -xfs [test(s)] - - You can run a range of tests: ./check 067-078 + - ./check '*/001' '*/002' '*/003' + - ./check '*/06?' + - You can explicitly specify NFS, otherwise the filesystem type will be + autodetected from $TEST_DEV: + ./check -nfs [test(s)] - Groups of tests maybe ran by: ./check -g [group(s)] See the 'group' file for details on groups - for udf tests: ./check -udf [test(s)]
check +0 -4
@@ -73,8 +73,6 @@ usage() echo "Usage: $0 [options] [testlist]"' check options - -xfs test XFS (default) - -udf test UDF -nfs test NFS -l line mode diff -udiff show unified diff (default)
@@ -159,8 +157,6 @@ while [ $# -gt 0 ]; do case "$1" in -\? | -h | --help) usage ;; - -udf) FSTYP=udf ;; - -xfs) FSTYP=xfs ;; -nfs) FSTYP=nfs ;; -g) group=$2 ; shift ;
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Dwight Engen
commit
cbcc88fbchanged test selection to use shell globs, so fixup the examples given in the README file.remove options for FSTYP other than NFS since the FSTYP will be automatically detected (on Linux) from $TEST_DEV.
Signed-off-by Dwight Engen <[email protected]>
Looks good. Applied.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs