Skip to contentSkip to conversation

ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

PATCH Superseded Hiroshi Doyu 3 participants 4 messages Jun 26, 2013 – Jul 1, 2013

Subsystems (2)

v1 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH 6/23 ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra114 SoC.

---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/tegra114.dtsi +1 -1
index 1f45cf5..715b5d6 100644
@@ -323,7 +323,7 @@
 		       0x70019228 0x074>;
 		nvidia,#asids = <4>;
 		dma-window = <0 0x40000000>;
-		nvidia,swgroups = <0x18659fe>;
+		nvidia,swgroups = <0x00000000 0x01b659fe>;
 		nvidia,ahb = <&ahb>;
 	};
 
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 6/23 ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

Quoted 13 lines · Hiroshi Doyu

This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra114 SoC.

---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/tegra114.dtsi +0 -0
index 1f45cf5..715b5d6 100644

arch/arm/boot/dts/tegra114.dtsi line 328

Quoted 7 lines
arch/arm/boot/dts/tegra114.dtsi +1 -1
@@ -323,7 +323,7 @@
 		       0x70019228 0x074>;
 		nvidia,#asids = <4>;
 		dma-window = <0 0x40000000>;
-		nvidia,swgroups = <0x18659fe>;
+		nvidia,swgroups = <0x00000000 0x01b659fe>;
 		nvidia,ahb = <&ahb>;
 	};

It seems like an nvidia,tegra114-smmu.txt file is missing from the Documentation/devicetree/bindings/iommu directory. And similarily to my comment for the tegra30.dtsi update this could be a symbolic value such as TEGRA114_SWGID_ALL.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/fdd17edb/attachment-0001.sig>

#2 lore raw

PATCH 6/23 ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

Thierry Reding <[email protected]> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:

Quoted 11 lines

* PGP Signed by an unknown key

Quoted 8 lines · Hiroshi Doyu

This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra114 SoC.

---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

arch/arm/boot/dts/tegra114.dtsi line 328

Quoted 12 lines
arch/arm/boot/dts/tegra114.dtsi +1 -1
index 1f45cf5..715b5d6 100644
@@ -323,7 +323,7 @@
 		       0x70019228 0x074>;
 		nvidia,#asids = <4>;
 		dma-window = <0 0x40000000>;
-		nvidia,swgroups = <0x18659fe>;
+		nvidia,swgroups = <0x00000000 0x01b659fe>;
 		nvidia,ahb = <&ahb>;
 	};

It seems like an nvidia,tegra114-smmu.txt file is missing from the Documentation/devicetree/bindings/iommu directory.

All difference between T30 and T114 is now provided from DT. They have all same entries but only those values are different.

Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just tweaking nvidia,tegra30-smmu.txt for t114 enough?

#3 lore raw

PATCH 6/23 ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

Quoted 4 lines · Hiroshi Doyu

Thierry Reding <[email protected]> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:

Quoted 3 lines · Hiroshi Doyu
Quoted 2 lines

This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra114 SoC.

...

Quoted 8 lines
Quoted 2 lines

It seems like an nvidia,tegra114-smmu.txt file is missing from the Documentation/devicetree/bindings/iommu directory.

All difference between T30 and T114 is now provided from DT. They have all same entries but only those values are different.

Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just tweaking nvidia,tegra30-smmu.txt for t114 enough?

If the two HW are identical (at least as far as bindings), the existing nvidia,tegra30-smmu.txt should be enough. We probably should at least update it to list the additional supported compatible value though, especially if the driver interprets the two compatible values in a different way (e.g. there are HW differences, but they don't affect the binding definition).