iommu/tegra: smmu: Workaround PCIe IOMMU'able

PATCH Superseded Hiroshi Doyu 2 participants 4 messages Jun 26, 2013

Subsystems (3)

Tegra architecture support IOMMU Tegra IOMMU drivers

lore

Share & tools

lore

Hiroshi Doyu

author

2013-06-26 09:28 UTC #0 lore raw

PATCH 18/23 iommu/tegra: smmu: Workaround PCIe IOMMU'able

Make PCIe work as it is. IOMMU support can be implemented later.

Signed-off-by Hiroshi Doyu <[email protected]>

---
 drivers/iommu/tegra-smmu.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/iommu/tegra-smmu.c +3 -0

index 64da08a..6e82df3 100644
@@ -402,6 +402,9 @@ static int __smmu_client_set_hwgrp(struct smmu_client *c,
 
 	for_each_set_bit(i, (unsigned long *)&map,
 			 sizeof(map) * BITS_PER_BYTE) {
+		if (i == SWGID_AFI) /* FIXME: IOMMU'able PCIe */
+			continue;
+
 		offs = HWGRP_ASID_REG(i);
 		val = smmu_read(smmu, offs);
 		if (on) {

Signature · 1 line

1.8.1.5

Thierry Reding

2013-06-26 11:06 UTC #1 lore raw

PATCH 18/23 iommu/tegra: smmu: Workaround PCIe IOMMU'able

Quoted 6 lines · Hiroshi Doyu

Make PCIe work as it is. IOMMU support can be implemented later.
Signed-off-by Hiroshi Doyu <[email protected]>
---
 drivers/iommu/tegra-smmu.c | 3 +++
 1 file changed, 3 insertions(+)

Can you provide more information about what the problem is here? Why is PCIe not working when mapped through the IOMMU?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/308f25c8/attachment-0001.sig>

Hiroshi Doyu

author

2013-06-26 11:09 UTC #2 lore raw

PATCH 18/23 iommu/tegra: smmu: Workaround PCIe IOMMU'able

Thierry Reding <[email protected]> wrote @ Wed, 26 Jun 2013 13:06:27 +0200:

Quoted 5 lines

* PGP Signed by an unknown key
Quoted 2 lines · Hiroshi Doyu
Make PCIe work as it is. IOMMU support can be implemented later.

Quoted 7 lines

Quoted 4 lines
Signed-off-by Hiroshi Doyu <[email protected]>
---
 drivers/iommu/tegra-smmu.c | 3 +++
 1 file changed, 3 insertions(+)
Can you provide more information about what the problem is here? Why is PCIe not working when mapped through the IOMMU?

I haven't had a code to register PCI device as IOMMU'able as ops->add_device() does for platform_devices. I'll add this comment.

Thierry Reding

2013-06-26 11:15 UTC #3 lore raw

PATCH 18/23 iommu/tegra: smmu: Workaround PCIe IOMMU'able

Quoted 12 lines · Hiroshi Doyu

Thierry Reding <[email protected]> wrote @ Wed, 26 Jun 2013 13:06:27 +0200:
Quoted 10 lines
* PGP Signed by an unknown key
Quoted 6 lines · Hiroshi Doyu
Make PCIe work as it is. IOMMU support can be implemented later.
Signed-off-by Hiroshi Doyu <[email protected]>
---
 drivers/iommu/tegra-smmu.c | 3 +++
 1 file changed, 3 insertions(+)

Quoted 5 lines

Quoted 2 lines
Can you provide more information about what the problem is here? Why is PCIe not working when mapped through the IOMMU?
I haven't had a code to register PCI device as IOMMU'able as ops->add_device() does for platform_devices. I'll add this comment.

Okay, that should be solved then when we merge the PCIe driver. I hope that can happen soon.