dfu:ext4:fix Fix ext4{read|write} command formatting
PATCH 1/1 dfu:ext4:fix Fix ext4{read|write} command formatting
In the following commit:
"dfu: Support larger than memory transfers."
SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
The ext4{read|write} command formatting has been changed. It removed a mandatory [sizebytes] parameter.
It prevented from ext4 update via dfu. This commit restored the previous behaviour.
--- drivers/dfu/dfu_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dfu/dfu_mmc.c +2 -2
@@ -94,10 +94,10 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu,sprintf (cmd_buf +strlen (cmd_buf)," %lx" , *len);break ;case DFU_FS_EXT4 : -sprintf (cmd_buf,"ext4%s mmc %d:%d 0x%x /%s" , +sprintf (cmd_buf,"ext4%s mmc %d:%d 0x%x /%s %ld" , op ==DFU_OP_READ ?"load" :"write" , dfu->data.mmc.dev, dfu->data.mmc.part, - (unsigned int ) buf, dfu->name); + (unsigned int ) buf, dfu->name, *len);break ;default : printf("%s: Layout (%s) not (yet) supported!\n", __func__,
Signature · 1 line
1.7.10.4
PATCH 1/1 dfu:ext4:fix Fix ext4{read|write} command formatting
Hi Tom,
Quoted 9 lines
In the following commit:
"dfu: Support larger than memory transfers."
SHA1:ea2453d56b8860dbd18a3c517531ffc8dcb5c839The ext4{read|write} command formatting has been changed. It removed a mandatory [sizebytes] parameter.
It prevented from ext4 update via dfu. This commit restored the previous behaviour.
Tom, please drop this patch, since it only fixes DFU eMMC write.
Unfortunately after dfu.c code changes to support NAND and arbitrary files transmission, the eMMC ext4 read needs to be fixed.
I will prepare one patch set, which fixes read and write.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH 1/1 dfu:ext4:fix Fix ext4{read|write} command formatting
Quoted 12 lines · Lukasz Majewski
Hi Tom,
Quoted 9 lines
In the following commit:
"dfu: Support larger than memory transfers."
SHA1:ea2453d56b8860dbd18a3c517531ffc8dcb5c839The ext4{read|write} command formatting has been changed. It removed a mandatory [sizebytes] parameter.
It prevented from ext4 update via dfu. This commit restored the previous behaviour.
Quoted 6 lines
Tom, please drop this patch, since it only fixes DFU eMMC write.
Unfortunately after
dfu.ccode changes to support NAND and arbitrary files transmission, the eMMC ext4 read needs to be fixed.I will prepare one patch set, which fixes read and write.
Ouch, sorry. I thought I had tested those cases still.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130626/b8f03620/attachment.pgp>
PATCH 1/1 dfu:ext4:fix Fix ext4{read|write} command formatting
Quoted 13 lines · Tom Rini
Quoted 12 lines · Lukasz Majewski
Hi Tom,
Quoted 9 lines
In the following commit:
"dfu: Support larger than memory transfers."
SHA1:ea2453d56b8860dbd18a3c517531ffc8dcb5c839The ext4{read|write} command formatting has been changed. It removed a mandatory [sizebytes] parameter.
It prevented from ext4 update via dfu. This commit restored the previous behaviour.
Quoted 9 lines
Quoted 6 lines
Tom, please drop this patch, since it only fixes DFU eMMC write.
Unfortunately after
dfu.ccode changes to support NAND and arbitrary files transmission, the eMMC ext4 read needs to be fixed.I will prepare one patch set, which fixes read and write.
Ouch, sorry. I thought I had tested those cases still.
With RAW_ADDR from very beginning, we can read chunk by chunk when proper request from DFU arrives.
With e.g. DFU_FS_EXT4 we first need to read all data from file system to a buffer (dfu_buf) and then give it to DFU gadget piece by piece.
I will fix this and share patches.
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group