Skip to contentSkip to conversation

video: mxsfb: Break the line in videomode message

PATCH New Fabio Estevam 4 participants 4 messages Jun 26, 2013 – Jun 28, 2013

Subsystems (2)
Arm i.MX and Layerscape Framebuffer layer
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 video: mxsfb: Break the line in videomode message

Currently we have the following on boot:

CPU:   Freescale i.MX28 rev1.2 at 454 MHz
BOOT:  SSP SD/MMC #0, 3V3
DRAM:  128 MiB
MMC:   MXS MMC: 0
Video: MXSFB: 'videomode' variable not set!In:    serial

Break the line of the warning message in order to have a better reading format.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/video/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/mxsfb.c +1 -1
index b189419..411d356 100644
@@ -137,7 +137,7 @@ void *video_hw_init(void)
 	/* Suck display configuration from "videomode" variable */
 	penv = getenv("videomode");
 	if (!penv) {
-		printf("MXSFB: 'videomode' variable not set!");
+		printf("MXSFB: 'videomode' variable not set!\n");
 		return NULL;
 	}
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 video: mxsfb: Break the line in videomode message

Dear Fabio Estevam,

Quoted 21 lines

Currently we have the following on boot:

CPU:   Freescale i.MX28 rev1.2 at 454 MHz
BOOT:  SSP SD/MMC #0, 3V3
DRAM:  128 MiB
MMC:   MXS MMC: 0
Video: MXSFB: 'videomode' variable not set!In:    serial

Break the line of the warning message in order to have a better reading format.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/video/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/mxsfb.c +0 -0
index b189419..411d356 100644

drivers/video/mxsfb.c void *video_hw_init(void) · line 140

Quoted 5 lines
drivers/video/mxsfb.c +1 -1
@@ -137,7 +137,7 @@ void *video_hw_init(void)
 	/* Suck display configuration from "videomode" variable */
 	penv = getenv("videomode");
 	if (!penv) {
-		printf("MXSFB: 'videomode' variable not set!");
+		printf("MXSFB: 'videomode' variable not set!\n");

puts() ... and you might want to fix it in all drivers ;-)

drivers/video/mxsfb.c void *video_hw_init(void) · line 142

Quoted 2 lines
drivers/video/mxsfb.c +0 -0
 		return NULL;
 	}

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 video: mxsfb: Break the line in videomode message

Hi Fabio, hi Marek,

Quoted 18 lines · Marek Vasut

Dear Fabio Estevam,

Quoted 16 lines

Currently we have the following on boot:

CPU:   Freescale i.MX28 rev1.2 at 454 MHz
BOOT:  SSP SD/MMC #0, 3V3
DRAM:  128 MiB
MMC:   MXS MMC: 0
Video: MXSFB: 'videomode' variable not set!In:    serial

Break the line of the warning message in order to have a better reading format.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/video/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

drivers/video/mxsfb.c void *video_hw_init(void) · line 140

Quoted 10 lines
drivers/video/mxsfb.c +1 -1
index b189419..411d356 100644
@@ -137,7 +137,7 @@ void *video_hw_init(void)
 	/* Suck display configuration from "videomode" variable */
 	penv = getenv("videomode");
 	if (!penv) {
-		printf("MXSFB: 'videomode' variable not set!");
+		printf("MXSFB: 'videomode' variable not set!\n");

puts() ... and you might want to fix it in all drivers ;-)

That is correct - as it is a very small change, I fix it myself by applying the patch.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#3 lore raw

PATCH 1/1 video: mxsfb: Break the line in videomode message

Quoted 2 lines · Stefano Babic

That is correct - as it is a very small change, I fix it myself by applying the patch.

Thanks, Stefano!

Quoted 5 lines

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic