Skip to contentSkip to conversation

ARM: shmobile: r8a73a4: Fix resources for SCIFB0

PATCH New Takanari Hayama 3 participants 3 messages Jul 1, 2013

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Takanari Hayama

author
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a73a4: Fix resources for SCIFB0

From: Takanari Hayama <[email protected]>

Fix base address and IRQ resources associated with SCIFB0.

Signed-off-by Takanari Hayama <[email protected]>
---
 arch/arm/mach-shmobile/setup-r8a73a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/setup-r8a73a4.c
index c5a75a7..7f45c2e 100644

arch/arm/mach-shmobile/setup-r8a73a4.c +1 -1
@@ -62,7 +62,7 @@ enum { SCIFA0, SCIFA1, SCIFB0, SCIFB1, SCIFB2, SCIFB3 };
 static const struct plat_sci_port scif[] = {
 	SCIFA_DATA(SCIFA0, 0xe6c40000, gic_spi(144)), /* SCIFA0 */
 	SCIFA_DATA(SCIFA1, 0xe6c50000, gic_spi(145)), /* SCIFA1 */
-	SCIFB_DATA(SCIFB0, 0xe6c50000, gic_spi(145)), /* SCIFB0 */
+	SCIFB_DATA(SCIFB0, 0xe6c20000, gic_spi(148)), /* SCIFB0 */
 	SCIFB_DATA(SCIFB1, 0xe6c30000, gic_spi(149)), /* SCIFB1 */
 	SCIFB_DATA(SCIFB2, 0xe6ce0000, gic_spi(150)), /* SCIFB2 */
 	SCIFB_DATA(SCIFB3, 0xe6cf0000, gic_spi(151)), /* SCIFB3 */
Signature · 6 lines
1.8.0

-- 
Takanari Hayama, Ph.D. (taki at igel.co.jp)
IGEL Co.,Ltd.
http://www.igel.co.jp/
maintainer
#1 lore raw

PATCH 1/1 ARM: shmobile: r8a73a4: Fix resources for SCIFB0

Hi Hayama-san,

Quoted 24 lines · Takanari Hayama

From: Takanari Hayama <[email protected]>

Fix base address and IRQ resources associated with SCIFB0.

Signed-off-by Takanari Hayama <[email protected]>
---
 arch/arm/mach-shmobile/setup-r8a73a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/setup-r8a73a4.c +1 -2
index c5a75a7..7f45c2e 100644
@@ -62,7 +62,7 @@ enum { SCIFA0, SCIFA1, SCIFB0, SCIFB1, SCIFB2, SCIFB3 };
 static const struct plat_sci_port scif[] = {
        SCIFA_DATA(SCIFA0, 0xe6c40000, gic_spi(144)), /* SCIFA0 */
        SCIFA_DATA(SCIFA1, 0xe6c50000, gic_spi(145)), /* SCIFA1 */
-       SCIFB_DATA(SCIFB0, 0xe6c50000, gic_spi(145)), /* SCIFB0 */
+       SCIFB_DATA(SCIFB0, 0xe6c20000, gic_spi(148)), /* SCIFB0 */
        SCIFB_DATA(SCIFB1, 0xe6c30000, gic_spi(149)), /* SCIFB1 */
        SCIFB_DATA(SCIFB2, 0xe6ce0000, gic_spi(150)), /* SCIFB2 */
        SCIFB_DATA(SCIFB3, 0xe6cf0000, gic_spi(151)), /* SCIFB3 */
--
Quoted 1 line

1.8.0

Thanks for catching this and submitting a fix. I've verified the proposed change using the APE6 rev0.7 hardware manual and it looks good to me.

Acked-by Magnus Damm <[email protected]>
#2 lore raw

PATCH 1/1 ARM: shmobile: r8a73a4: Fix resources for SCIFB0

Quoted 33 lines · Magnus Damm

Hi Hayama-san,

Quoted 24 lines · Takanari Hayama

From: Takanari Hayama <[email protected]>

Fix base address and IRQ resources associated with SCIFB0.

Signed-off-by Takanari Hayama <[email protected]>
---
 arch/arm/mach-shmobile/setup-r8a73a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/setup-r8a73a4.c +1 -2
index c5a75a7..7f45c2e 100644
@@ -62,7 +62,7 @@ enum { SCIFA0, SCIFA1, SCIFB0, SCIFB1, SCIFB2, SCIFB3 };
 static const struct plat_sci_port scif[] = {
        SCIFA_DATA(SCIFA0, 0xe6c40000, gic_spi(144)), /* SCIFA0 */
        SCIFA_DATA(SCIFA1, 0xe6c50000, gic_spi(145)), /* SCIFA1 */
-       SCIFB_DATA(SCIFB0, 0xe6c50000, gic_spi(145)), /* SCIFB0 */
+       SCIFB_DATA(SCIFB0, 0xe6c20000, gic_spi(148)), /* SCIFB0 */
        SCIFB_DATA(SCIFB1, 0xe6c30000, gic_spi(149)), /* SCIFB1 */
        SCIFB_DATA(SCIFB2, 0xe6ce0000, gic_spi(150)), /* SCIFB2 */
        SCIFB_DATA(SCIFB3, 0xe6cf0000, gic_spi(151)), /* SCIFB3 */
--
Quoted 1 line

1.8.0

Thanks for catching this and submitting a fix. I've verified the proposed change using the APE6 rev0.7 hardware manual and it looks good to me.

Quoted 1 line
Acked-by Magnus Damm <[email protected]>

Thanks, I will try and get this included in v3.11 as a fix and then added to v3.10 stable.