Multiple DA9055 chips
It seems we have two drivers in mainline for da9055 on I2C. We've got one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Quoted 5 lines · Mark Brown
It seems we have two drivers in mainline for da9055 on I2C. We've got one in
sound/soc/codecs/da9055.cand one indrivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Yes, this is a combined CODEC and PMIC.
Quoted 8 lines · Ashish Chavan
Quoted 5 lines · Mark Brown
It seems we have two drivers in mainline for da9055 on I2C. We've got one in
sound/soc/codecs/da9055.cand one indrivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?Yes, this is a combined CODEC and PMIC.
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Quoted 8 lines · Mark Brown
Quoted 6 lines · Ashish Chavan
Quoted 5 lines · Mark Brown
It seems we have two drivers in mainline for da9055 on I2C. We've got one in
sound/soc/codecs/da9055.cand one indrivers/mfd/da9055-i2c.c, both registering themselves identically. What's going on here? Is this a combined CODEC and PMIC, has someone decided to release two chips with the same name or is one of the drivers misnamed?
Quoted 4 lines
Quoted 1 line
Yes, this is a combined CODEC and PMIC.
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
Quoted 8 lines · Ashish Chavan
Quoted 2 lines
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
Both drivers need to be changed.
Quoted 5 lines · Mark Brown
Quoted 2 lines · Ashish Chavan
Quoted 2 lines
OK, in that case the CODEC driver is just plain broken then. Did anyone actually test this stuff? Please fix.
Quoted 7 lines
Quoted 5 lines
Yes, I think so. Actually the CODEC driver was merged before PMIC ino main line and was tested at that time. I will check with PMIC team if they did test with CODEC.
I guess the fix should be in PMIC, right?
Both drivers need to be changed.
OK. We will fix both of them.
Thanks for pointing this out.