spi: spi-ep93xx: remove bits_per_word() helper
PATCH v2 3/11 spi: spi-ep93xx: remove bits_per_word() helper
Check t->bits_per_word directly and remove the inline helper function.
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ryan Mallon <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Mark Brown <[email protected]>
Cc Grant Likely <[email protected]>
--- drivers/spi/spi-ep93xx.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
drivers/spi/spi-ep93xx.c +3 -11
@@ -429,17 +429,9 @@ static void ep93xx_spi_chip_setup(const struct ep93xx_spi *espi,ep93xx_spi_write_u16 (espi,SSPCR0 , cr0); } -static inline int bits_per_word (const struct ep93xx_spi *espi) -{ -struct spi_message *msg = espi->current_msg; -struct spi_transfer *t = msg->state; - -return t->bits_per_word; -} -static void ep93xx_do_write (struct ep93xx_spi *espi,struct spi_transfer *t) { -if (bits_per_word (espi) >8 ) { +if (t->bits_per_word >8 ) {u16 tx_val =0 ;if (t->tx_buf)
@@ -458,7 +450,7 @@ static void ep93xx_do_write(struct ep93xx_spi *espi, struct spi_transfer *t)static void ep93xx_do_read (struct ep93xx_spi *espi,struct spi_transfer *t) { -if (bits_per_word (espi) >8 ) { +if (t->bits_per_word >8 ) {u16 rx_val; rx_val =ep93xx_spi_read_u16 (espi,SSPDR );
@@ -544,7 +536,7 @@ ep93xx_spi_dma_prepare(struct ep93xx_spi *espi, enum dma_transfer_direction dir)size_t len = t->len;int i, ret, nents; -if (bits_per_word (espi) >8 ) +if (t->bits_per_word >8 ) buswidth =DMA_SLAVE_BUSWIDTH_2_BYTES ;else buswidth =DMA_SLAVE_BUSWIDTH_1_BYTE ;
Signature · 9 lines
1.8.1.4 ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev
Quoted 5 lines · H Hartley Sweeten
Check
t->bits_per_worddirectly and remove the inline helper function.Signed-off-by H Hartley Sweeten <[email protected]>Cc Ryan Mallon <[email protected]>Cc Mika Westerberg <[email protected]>
I wonder why the helper was there in the first place.
Acked-by Mika Westerberg <[email protected]>
Quoted 1 line · H Hartley Sweeten
Check
t->bits_per_worddirectly and remove the inline helper function.
Applied, thanks.