Skip to contentSkip to conversation

spi: spi-ep93xx: don't bother calculating the divisors in ep93xx_spi_setup()

PATCH Applied H Hartley Sweeten 2 participants 2 messages Jul 2, 2013 – Jul 8, 2013 SPI

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH v2 8/11 spi: spi-ep93xx: don't bother calculating the divisors in ep93xx_spi_setup()

The divisors needed to generate the SPI clock are calculated per transfer based on the t->speed_hz. There is no reason to calculate them in ep93xx_spi_setup().

Signed-off-by H Hartley Sweeten <[email protected]>
Acked-by Mika Westerberg <[email protected]>
Cc Ryan Mallon <[email protected]>
Cc Mark Brown <[email protected]>
Cc Grant Likely <[email protected]>
---
 drivers/spi/spi-ep93xx.c | 14 --------------
 1 file changed, 14 deletions(-)
drivers/spi/spi-ep93xx.c +0 -14
index cc2a240..6cdfc40 100644
@@ -136,7 +136,6 @@ struct ep93xx_spi {
 /**
  * struct ep93xx_spi_chip - SPI device hardware settings
  * @spi: back pointer to the SPI device
- * @rate: max rate in hz this chip supports
  * @div_cpsr: cpsr (pre-scaler) divider
  * @div_scr: scr divider
  * @ops: private chip operations

@@ -147,7 +146,6 @@ struct ep93xx_spi {
  */
 struct ep93xx_spi_chip {
 	const struct spi_device		*spi;
-	unsigned long			rate;
 	u8				div_cpsr;
 	u8				div_scr;
 	struct ep93xx_spi_chip_ops	*ops;

@@ -315,18 +313,6 @@ static int ep93xx_spi_setup(struct spi_device *spi)
 		spi_set_ctldata(spi, chip);
 	}
 
-	if (spi->max_speed_hz != chip->rate) {
-		int err;
-
-		err = ep93xx_spi_calc_divisors(espi, chip, spi->max_speed_hz);
-		if (err != 0) {
-			spi_set_ctldata(spi, NULL);
-			kfree(chip);
-			return err;
-		}
-		chip->rate = spi->max_speed_hz;
-	}
-
 	ep93xx_spi_cs_control(spi, false);
 	return 0;
 }
Signature · 9 lines
1.8.1.4


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
maintainer Applied
#1 lore raw
Quoted 3 lines · H Hartley Sweeten

The divisors needed to generate the SPI clock are calculated per transfer based on the t->speed_hz. There is no reason to calculate them in ep93xx_spi_setup().

Applied, thanks.