Input: cyttsp4 - silence shift wrap warning
Subsystems (4)
PATCH 1/3 Input: cyttsp4 - silence shift wrap warning
"*max" is a size_t (long) type but "1" is an int so static checkers complain that the shift could wrap.
Signed-off-by Dan Carpenter <[email protected]>
drivers/input/touchscreen/cyttsp4_core.c +1 -1
@@ -153,7 +153,7 @@ static int cyttsp4_hw_reset(struct cyttsp4 *cd)*/ static int cyttsp4_bits_2_bytes (unsigned int nbits,size_t *max) { - *max =1 << nbits; + *max =1UL << nbits;return (nbits +7 ) /8 ; }
Quoted 4 lines · Dan Carpenter
"*max" is a
size_t(long) type but "1" is an int so static checkers complain that the shift could wrap.Signed-off-by Dan Carpenter <[email protected]>
Applied all 3, thank you Dan.
Quoted 14 lines
drivers/input/touchscreen/cyttsp4_core.c +1
-1@@ -153,7 +153,7 @@ static int cyttsp4_hw_reset(struct cyttsp4 *cd)*/ static int cyttsp4_bits_2_bytes (unsigned int nbits,size_t *max) { - *max =1 << nbits; + *max =1UL << nbits;return (nbits +7 ) /8 ; }
Signature · 1 line
Dmitry