Skip to contentSkip to conversation

3.10: Intel HWMON/NIC temperature sensor question

lm-sensors Justin Piszcz 3 participants 4 messages Jul 3, 2013

lore
Share & tools
lore
#0 lore raw

Hi,

I saw this in the device drive section and was curious which Intel-based NICs contain temperature sensors?

Intel(R) 10GbE PCI Express adapters HWMON support

Intel(R) PCI-Express Gigabit adapters HWMON support

I checked the boards below and none appear to expose a hwmon interface:

08:00.0 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.1 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.2 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.3 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

09:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection

0a:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection

01:00.0 Ethernet controller: Intel Corporation 82598EB 10-Gigabit AT2 Server Adapter (rev 01)

# find /sys/|grep hwmon

Radeon:

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/name

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power/control

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power/runtime _active_time

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power/autosus pend_delay_ms

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power/runtime _status

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/power/runtime _suspended_time

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/device

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/subsystem

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/uevent

/sys/devices/pci0000:00/0000:00:03.1/0000:05:00.0/hwmon/hwmon0/temp1_input

Onboard chipset:

/sys/devices/platform/nct6775.2608/hwmon

/sys/devices/platform/nct6775.2608/hwmon/hwmon2

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power/control

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power/runtime_active_time

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power/autosuspend_delay_ms

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power/runtime_status

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/power/runtime_suspended_time

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/device

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/subsystem

/sys/devices/platform/nct6775.2608/hwmon/hwmon2/uevent

CPU:

/sys/devices/platform/coretemp.0/hwmon

/sys/devices/platform/coretemp.0/hwmon/hwmon1

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power/control

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power/runtime_active_time

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power/autosuspend_delay_ms

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power/runtime_status

/sys/devices/platform/coretemp.0/hwmon/hwmon1/power/runtime_suspended_time

/sys/devices/platform/coretemp.0/hwmon/hwmon1/device

/sys/devices/platform/coretemp.0/hwmon/hwmon1/subsystem

/sys/devices/platform/coretemp.0/hwmon/hwmon1/uevent

Justin.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw
Quoted 29 lines · Justin Piszcz

Hi,

I saw this in the device drive section and was curious which Intel-based NICs contain temperature sensors?

Intel(R) 10GbE PCI Express adapters HWMON support

Intel(R) PCI-Express Gigabit adapters HWMON support

I checked the boards below and none appear to expose a hwmon interface:

08:00.0 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.1 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.2 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

08:00.3 Ethernet controller: Intel Corporation 82580 Gigabit Network Connection (rev 01)

Quoted 9 lines

09:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection

0a:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection

01:00.0 Ethernet controller: Intel Corporation 82598EB 10-Gigabit AT2 Server Adapter (rev 01)

82575 and 82599. Doesn't matter much, though, since they don't export the "name" attribute from their driver, meaning the sensors command won't find the sensors. Also, they enerate the hwmon device first and then create the attributes, which is the wrong order and creates a potential race condition with demons.

Someone who has a board will have to fix that at some point.

Guenter

#2 lore raw
Quoted 4 lines · Guenter Roeck

82575 and 82599. Doesn't matter much, though, since they don't export the "name" attribute from their driver, meaning the sensors command won't find the sensors. Also, they enerate the hwmon device first and then create the attributes, which is the wrong order and creates a potential race condition with demons.

Yes and no. For devices which are only implementing hwmon features, hwmon is just a link and the attributes belong to the device. So we can create the attributes first and the hwmon device second.

However for devices which are primarily something else and only register a hwmon device as a side object, the hwmon attributes are attached to the hwmon class device and not the main device. In that case the hwmon device has to be created first and the attributes second. Yes, this is racy. The only clean way around it AFAIK is to implement all the attributes as proper class attributes rather than creating them manually - but it would take a whole redesign of the hwmon core module.

A workaround may be to create the name attribute last.

Quoted 1 line

Someone who has a board will have to fix that at some point.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw
Quoted 10 lines · Jean Delvare
Quoted 4 lines · Guenter Roeck

82575 and 82599. Doesn't matter much, though, since they don't export the "name" attribute from their driver, meaning the sensors command won't find the sensors. Also, they enerate the hwmon device first and then create the attributes, which is the wrong order and creates a potential race condition with demons.

Yes and no. For devices which are only implementing hwmon features, hwmon is just a link and the attributes belong to the device. So we can create the attributes first and the hwmon device second.

Quoted 9 lines

However for devices which are primarily something else and only register a hwmon device as a side object, the hwmon attributes are attached to the hwmon class device and not the main device. In that case the hwmon device has to be created first and the attributes second. Yes, this is racy. The only clean way around it AFAIK is to implement all the attributes as proper class attributes rather than creating them manually - but it would take a whole redesign of the hwmon core module.

Actually, there would be a simple solution. We can add an API call such as hwmon_device_register_groups(), which in addition to passing the parent device would also pass "struct attribute_groups **". It would have to create the device manually instead of calling device_create(), but would add the groups to the device structure prior to calling device_register(). The core device handling code would then automatically create all attributes (and remove them later on).

We might even be able to convince the device core maintainers to let us add a "device_register_groups()" API into the device core code.

Code itself should be straightforward. Worth a try ?

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors