Skip to contentSkip to conversation

libiqrf: Bump to v0.1.2 + update build system.

PATCH New Marek Belisko 4 participants 5 messages Jul 3, 2013 – Jul 28, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libiqrf: Bump to v0.1.2 + update build system.

v0.1.2 update build system from autotools to cmake.

---
 package/libiqrf/libiqrf.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libiqrf/libiqrf.mk +2 -2
index f2d5b4c..df4bb42 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-LIBIQRF_VERSION = v0.1.0
+LIBIQRF_VERSION = v0.1.2
 LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
 LIBIQRF_INSTALL_STAGING = YES
 
 LIBIQRF_DEPENDENCIES = libusb
 
-$(eval $(autotools-package))
+$(eval $(cmake-package))
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 libiqrf: Bump to v0.1.2 + update build system.

Marek, All,

On 2013-07-03 22:51 +0200, Marek Belisko spake thusly:

Quoted 1 line

v0.1.2 update build system from autotools to cmake.

Is it mandatory to switch to cmake when upgrading?
If not, then please split this in two: one to upgrade, one to switch.

If possible, I'd prefer we stick to using autotools if it is still supported (and maintained) by libiqrf. I'm wary of the fuss around cmake (but agreed, that's a personal taste). Every now and then, I pester at cmake usage, since I don't really want to pay the price for Yet-Another-Build-System, and the very few packages that I need and use cmake, do compile in an aggregated time much smaller than it takes to build cmake itself.

So, my personal taste would be to favour autotools against cmake where/if possible, please. ;-)

Note: of course, if autotools is no longer supported by libiqrf, then the switch is mandatory, but if so, state it explicitly in the commit message.

Quoted 12 lines
---
 package/libiqrf/libiqrf.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libiqrf/libiqrf.mk +0 -0
index f2d5b4c..df4bb42 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################

package/libiqrf/libiqrf.mk line 13

Quoted 10 lines
package/libiqrf/libiqrf.mk +2 -2
 
-LIBIQRF_VERSION = v0.1.0
+LIBIQRF_VERSION = v0.1.2
 LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
 LIBIQRF_INSTALL_STAGING = YES
 
 LIBIQRF_DEPENDENCIES = libusb
 
-$(eval $(autotools-package))
+$(eval $(cmake-package))

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 libiqrf: Bump to v0.1.2 + update build system.

Hi Yann,

Quoted 16 lines · Yann E. MORIN

Marek, All,

On 2013-07-03 22:51 +0200, Marek Belisko spake thusly:

Quoted 1 line

v0.1.2 update build system from autotools to cmake.

Is it mandatory to switch to cmake when upgrading?
If not, then please split this in two: one to upgrade, one to switch.

If possible, I'd prefer we stick to using autotools if it is still supported (and maintained) by libiqrf. I'm wary of the fuss around cmake (but agreed, that's a personal taste). Every now and then, I pester at cmake usage, since I don't really want to pay the price for Yet-Another-Build-System, and the very few packages that I need and use cmake, do compile in an aggregated time much smaller than it takes to build cmake itself.

Quoted 6 lines

So, my personal taste would be to favour autotools against cmake where/if possible, please. ;-)

Note: of course, if autotools is no longer supported by libiqrf, then the switch is mandatory, but if so, state it explicitly in the commit message.

Right, autotools was replaced by cmake in version v0.1.2.

Quoted 27 lines
Quoted 13 lines
---
 package/libiqrf/libiqrf.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libiqrf/libiqrf.mk +0 -0
index f2d5b4c..df4bb42 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################

package/libiqrf/libiqrf.mk line 13

Quoted 10 lines
package/libiqrf/libiqrf.mk +2 -2
 
-LIBIQRF_VERSION = v0.1.0
+LIBIQRF_VERSION = v0.1.2
 LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
 LIBIQRF_INSTALL_STAGING = YES
 
 LIBIQRF_DEPENDENCIES = libusb
 
-$(eval $(autotools-package))
+$(eval $(cmake-package))

Regards,
Yann E. MORIN.

Quoted 7 lines

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

Marek

--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

#3 lore raw

PATCH 1/1 libiqrf: Bump to v0.1.2 + update build system.

In reply to Marek Belisko

Dear Marek Belisko,

Quoted 1 line · Marek Belisko

v0.1.2 update build system from autotools to cmake.

Committed, thanks. I had to add a simple patch to the CMakeLists.txt to avoid CMake needlessly checking for a C++ compiler. It would be good if this patch could be upstreamed.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 libiqrf: Bump to v0.1.2 + update build system.

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni

Dear Marek Belisko,

Quoted 1 line · Marek Belisko

v0.1.2 update build system from autotools to cmake.

Committed, thanks. I had to add a simple patch to the CMakeLists.txt to avoid CMake needlessly checking for a C++ compiler. It would be good if this patch could be upstreamed.

Thanks. Sure I'll take your patch and add it upstream.

Quoted 9 lines

Thanks,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com