Skip to contentSkip to conversation

tracing/uprobes: Support soft-mode disabling

PATCH In review zhangwei(Jovi) 3 participants 3 messages Jul 4, 2013 Tracing

lore
Share & tools
lore

zhangwei(Jovi)

author
#0 lore raw

PATCH v6 2/2 tracing/uprobes: Support soft-mode disabling

Support soft-mode disabling on uprobe-based dynamic events. Soft-disabling is just ignoring recording if the soft disabled flag is set.

Signed-off-by zhangwei(Jovi) <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Oleg Nesterov <[email protected]>
Cc Srikar Dronamraju <[email protected]>
---
 kernel/trace/trace_uprobe.c |    3 +++
 1 file changed, 3 insertions(+)
kernel/trace/trace_uprobe.c +3 -0
index 2fc9931..94f180d 100644
@@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
 
 	WARN_ON(call != ftrace_file->event_call);
 
+	if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
+		return;
+
 	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
 	event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
 						call->event.type,
Signature · 1 line
1.7.9.7
Reviewed-by on v6 2/2
#1 lore raw
Quoted 5 lines · zhangwei(Jovi)

Support soft-mode disabling on uprobe-based dynamic events. Soft-disabling is just ignoring recording if the soft disabled flag is set.

Signed-off-by zhangwei(Jovi) <[email protected]>

looks good for me too.

Reviewed-by Masami Hiramatsu <[email protected]>

Thanks!

Quoted 23 lines
Cc Masami Hiramatsu <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Oleg Nesterov <[email protected]>
Cc Srikar Dronamraju <[email protected]>
---
 kernel/trace/trace_uprobe.c |    3 +++
 1 file changed, 3 insertions(+)
kernel/trace/trace_uprobe.c +3 -0
index 2fc9931..94f180d 100644
@@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
 
 	WARN_ON(call != ftrace_file->event_call);
 
+	if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
+		return;
+
 	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
 	event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
 						call->event.type,
Signature · 4 lines
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]