perf sched: Move struct perf_sched definition out of cmd_sched()
Namhyung Kim
maintainerPATCH RESEND 1/1 perf sched: Move struct perf_sched definition out of cmd_sched()
From: Namhyung Kim <[email protected]>
For some reason it consumed quite amount of compile time when declared as local variable, and it disappeared when moved out of the function. Moving other variables/tables didn't help.
On my system this single-file-change build time reduced from 11s to 3s.
--- tools/perf/builtin-sched.c | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-)
tools/perf/builtin-sched.c +21 -20
@@ -1663,28 +1663,29 @@ static int __cmd_record(int argc, const char **argv)return cmd_record (i, rec_argv,NULL ); } +static const char default_sort_order[] ="avg, max, switch, runtime" ; +static struct perf_sched sched = { + .tool = { + .sample = perf_sched__process_tracepoint_sample, + .comm = perf_event__process_comm, + .lost = perf_event__process_lost, + .fork = perf_event__process_fork, + .ordered_samples = true, + }, + .cmp_pid =LIST_HEAD_INIT (sched.cmp_pid), + .sort_list =LIST_HEAD_INIT (sched.sort_list), + .start_work_mutex =PTHREAD_MUTEX_INITIALIZER , + .work_done_wait_mutex =PTHREAD_MUTEX_INITIALIZER , + .curr_pid = { [0 ...MAX_CPUS -1 ] =-1 }, + .sort_order = default_sort_order, + .replay_repeat =10 , + .profile_cpu =-1 , + .next_shortname1 ='A' , + .next_shortname2 ='0' , +}; +int cmd_sched (int argc,const char **argv,const char *prefix__maybe_unused ) { -const char default_sort_order[] ="avg, max, switch, runtime" ; -struct perf_sched sched = { - .tool = { - .sample = perf_sched__process_tracepoint_sample, - .comm = perf_event__process_comm, - .lost = perf_event__process_lost, - .fork = perf_event__process_fork, - .ordered_samples = true, - }, - .cmp_pid =LIST_HEAD_INIT (sched.cmp_pid), - .sort_list =LIST_HEAD_INIT (sched.sort_list), - .start_work_mutex =PTHREAD_MUTEX_INITIALIZER , - .work_done_wait_mutex =PTHREAD_MUTEX_INITIALIZER , - .curr_pid = { [0 ...MAX_CPUS -1 ] =-1 }, - .sort_order = default_sort_order, - .replay_repeat =10 , - .profile_cpu =-1 , - .next_shortname1 ='A' , - .next_shortname2 ='0' , - };const struct option latency_options[] = {OPT_STRING ('s' ,"sort" , &sched.sort_order,"key[,key2...]" ,"sort by key(s): runtime, switch, avg, max" ),
Signature · 1 line
1.7.11.7
Em Tue, Jun 04, 2013 at 02:46:19PM +0900, Namhyung Kim escreveu:
Quoted 7 lines
From: Namhyung Kim <[email protected]>
For some reason it consumed quite amount of compile time when declared as local variable, and it disappeared when moved out of the function. Moving other variables/tables didn't help.
On my system this single-file-change build time reduced from 11s to 3s.
Thanks a lot, applied.
- Arnaldo
Quoted 7 lines · Namhyung Kim
From: Namhyung Kim <[email protected]>
For some reason it consumed quite amount of compile time when declared as local variable, and it disappeared when moved out of the function. Moving other variables/tables didn't help.
On my system this single-file-change build time reduced from 11s to 3s.
cooool.. I spent some time wondering what was the reason in the past, nice! :-)
jirka
tip-bot for Namhyung Kim
merge botperf sched: Move struct perf_sched definition out of cmd_sched()
Commit-ID: f36f83f947ede547833e462696893f866df77324 Gitweb: http://git.kernel.org/tip/f36f83f947ede547833e462696893f866df77324 Author: Namhyung Kim <[email protected]> AuthorDate: Tue, 4 Jun 2013 14:46:19 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 12 Jul 2013 13:52:35 -0300
perf sched: Move struct perf_sched definition out of cmd_sched()
For some reason it consumed quite amount of compile time when declared as local variable, and it disappeared when moved out of the function. Moving other variables/tables didn't help.
On my system this single-file-change build time reduced from 11s to 3s.
--- tools/perf/builtin-sched.c | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-)
tools/perf/builtin-sched.c +21 -20
@@ -1662,28 +1662,29 @@ static int __cmd_record(int argc, const char **argv)return cmd_record (i, rec_argv,NULL ); } +static const char default_sort_order[] ="avg, max, switch, runtime" ; +static struct perf_sched sched = { + .tool = { + .sample = perf_sched__process_tracepoint_sample, + .comm = perf_event__process_comm, + .lost = perf_event__process_lost, + .fork = perf_event__process_fork, + .ordered_samples = true, + }, + .cmp_pid =LIST_HEAD_INIT (sched.cmp_pid), + .sort_list =LIST_HEAD_INIT (sched.sort_list), + .start_work_mutex =PTHREAD_MUTEX_INITIALIZER , + .work_done_wait_mutex =PTHREAD_MUTEX_INITIALIZER , + .curr_pid = { [0 ...MAX_CPUS -1 ] =-1 }, + .sort_order = default_sort_order, + .replay_repeat =10 , + .profile_cpu =-1 , + .next_shortname1 ='A' , + .next_shortname2 ='0' , +}; +int cmd_sched (int argc,const char **argv,const char *prefix__maybe_unused ) { -const char default_sort_order[] ="avg, max, switch, runtime" ; -struct perf_sched sched = { - .tool = { - .sample = perf_sched__process_tracepoint_sample, - .comm = perf_event__process_comm, - .lost = perf_event__process_lost, - .fork = perf_event__process_fork, - .ordered_samples = true, - }, - .cmp_pid =LIST_HEAD_INIT (sched.cmp_pid), - .sort_list =LIST_HEAD_INIT (sched.sort_list), - .start_work_mutex =PTHREAD_MUTEX_INITIALIZER , - .work_done_wait_mutex =PTHREAD_MUTEX_INITIALIZER , - .curr_pid = { [0 ...MAX_CPUS -1 ] =-1 }, - .sort_order = default_sort_order, - .replay_repeat =10 , - .profile_cpu =-1 , - .next_shortname1 ='A' , - .next_shortname2 ='0' , - };const struct option latency_options[] = {OPT_STRING ('s' ,"sort" , &sched.sort_order,"key[,key2...]" ,"sort by key(s): runtime, switch, avg, max" ),