dfu:ext4:fix Fix ext4{read|write} command formatting

PATCH New Lukasz Majewski 4 participants 14 messages Jun 28, 2013 – Jul 8, 2013

lore

Share & tools

lore

Lukasz Majewski

author

2013-06-28 16:41 UTC #0 lore raw

PATCH 1/2 dfu:ext4:fix Fix ext4{read|write} command formatting

In the following commit:
"dfu: Support larger than memory transfers."
SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839

The ext4{read|write} command formatting has been changed. It removed a write mandatory [sizebytes] parameter.

It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory parameter for DFU write.

Signed-off-by Lukasz Majewski <[email protected]>

Cc Tom Rini <[email protected]>

Cc Pantelis Antoniou <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Heiko Schocher <[email protected]>

---
 drivers/dfu/dfu_mmc.c |    2 ++
 1 file changed, 2 insertions(+)

drivers/dfu/dfu_mmc.c +2 -0

index e2f3978..e7ee077 100644
@@ -98,6 +98,8 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu,
 			op == DFU_OP_READ ? "load" : "write",
 			dfu->data.mmc.dev, dfu->data.mmc.part,
 			(unsigned int) buf, dfu->name);
+		if (op == DFU_OP_WRITE)
+			sprintf(cmd_buf + strlen(cmd_buf), " %ld", *len);
 		break;
 	default:
 		printf("%s: Layout (%s) not (yet) supported!\n", __func__,

Signature · 1 line

1.7.10.4

Lukasz Majewski

author

2013-06-28 16:41 UTC #1 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].

For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.

Signed-off-by Lukasz Majewski <[email protected]>

Cc Tom Rini <[email protected]>

Cc Pantelis Antoniou <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Heiko Schocher <[email protected]>

---
 drivers/dfu/dfu.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

drivers/dfu/dfu.c +5 -4

index e429d74..0521752 100644
@@ -248,7 +248,11 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num)
 	       __func__, dfu->name, buf, size, blk_seq_num, dfu->i_buf);
 
 	if (!dfu->inited) {
-		ret = dfu->read_medium(dfu, 0, buf, &dfu->r_left);
+		dfu->i_buf_start = dfu_get_buf();
+		if (dfu->i_buf_start == NULL)
+			return -ENOMEM;
+
+		ret = dfu->read_medium(dfu, 0, dfu->i_buf_start, &dfu->r_left);
 		if (ret != 0) {
 			debug("%s: failed to get r_left\n", __func__);
 			return ret;

@@ -259,9 +263,6 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num)
 		dfu->i_blk_seq_num = 0;
 		dfu->crc = 0;
 		dfu->offset = 0;
-		dfu->i_buf_start = dfu_get_buf();
-		if (dfu->i_buf_start == NULL)
-			return -ENOMEM;
 		dfu->i_buf_end = dfu_get_buf() + dfu_buf_size;
 		dfu->i_buf = dfu->i_buf_start;
 		dfu->b_left = 0;

Signature · 1 line

1.7.10.4

Tom Rini

2013-07-03 19:33 UTC #2 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

Quoted 4 lines · ??ukasz Majewski

For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].

Quoted 8 lines

For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]>
Cc Pantelis Antoniou <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Heiko Schocher <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130703/179f6fd6/attachment.pgp>

Marek Vasut

2013-07-03 21:49 UTC #3 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

Dear Tom Rini,

Quoted 8 lines · ??ukasz Majewski

Quoted 7 lines
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.

Quoted 7 lines

Quoted 5 lines
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]>
Cc Pantelis Antoniou <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!

Tom, why are you picking USB changes now? This is creating quite some mess ...

Best regards,
Marek Vasut

Tom Rini

2013-07-05 12:48 UTC #4 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

Quoted 16 lines · Marek Vasut

Dear Tom Rini,
Quoted 14 lines · ??ukasz Majewski
Quoted 12 lines
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]>
Cc Pantelis Antoniou <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Heiko Schocher <[email protected]>

Quoted 3 lines

Quoted 1 line
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...

Just trying to clear up the queue of fixes.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130705/79e8e474/attachment.pgp>

Marek Vasut

2013-07-05 13:55 UTC #5 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

Dear Tom Rini,

Quoted 17 lines · Marek Vasut

Quoted 16 lines
Dear Tom Rini,
Quoted 14 lines · ??ukasz Majewski
Quoted 12 lines
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]>
Cc Pantelis Antoniou <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Heiko Schocher <[email protected]>

Quoted 6 lines

Quoted 4 lines
Quoted 1 line
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.

Ok, if you manage to merge it with the USB PR ...

Best regards,
Marek Vasut

Tom Rini

2013-07-05 14:09 UTC #6 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 19 lines · Marek Vasut

Dear Tom Rini,
Quoted 17 lines · Marek Vasut
Quoted 16 lines
Dear Tom Rini,
Quoted 14 lines
Quoted 11 lines · ??ukasz Majewski
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Signed-off-by Lukasz Majewski <[email protected]> Cc:
Tom Rini <[email protected]> Cc: Pantelis Antoniou <[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>

Quoted 8 lines

Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...

Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJR1tOoAAoJENk4IS6UOR1WUToP/1+NJg5S9fFWaFWFfya0eRhi N3qdiA9bTs2hye/EwPB75HQ7tllWmr5/pHwFXLvkrCbV8pL/P2SnSch/lmN4PX7l qC6EEz5xlgpy0vhPQ8S+rLgoa2qavurBFAR2G3D+s2s4NkjSTmUrs/VHnzXOexKI 6DG4gu8FrNBvE0SMCfuXHJcRD7rEvXYsDH0sz+21DlhFr/WIk1ErREP3rXHk0ffp b0rOWvdYTQcceYDgXS70JSXpwmRl/QWga8UpdseNtujhz18RX3C8W8XG6dSoTZGv CYZQzAldU9k5y/S1c7t1W87Himc6bZfcuTYlXpvAB2isN02S3jQmzmdFZ95xc0Lv AZUV05VRAsVKXkwihpmxUCBwTafzcczFjm48bdJ5n5Qvpy5VnwsiFucHyB4/9ikv 1e3eOueaxLaMNHCHfiP/J8tr8/4H8M+dq4HKQvjZdmCsBqEHiKUUDQIKTFaryOg2 sohWAH6v76qK2CjQ2I2rHju1lMeLeOHpR33ZUb0FBVLRVzdZl9QD3rTRuW840pPt OCdscioGWatJ0YkND4giCey15O38IaKQ0Q6McqoZe/GIhvt2tqTWJrKdM1d76lXZ 9TaYLKxY20GAvfxPAopUaNdnwFiu3uefwZpMsJGbqg+aJyOuncCqXRDKprru9bbj chpFHxwvm/wGhkLDleeO
=XazZ
-----END PGP SIGNATURE-----

Marek Vasut

2013-07-05 14:32 UTC #7 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

Dear Tom Rini,

Quoted 26 lines · Marek Vasut

Quoted 25 lines
Dear Tom Rini,
Quoted 23 lines · Marek Vasut
Quoted 21 lines
Dear Tom Rini,
Quoted 10 lines
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
Quoted 7 lines · wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukasz Majewski <[email protected]> Cc:
Tom Rini <[email protected]> Cc: Pantelis Antoniou <[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...

Quoted 6 lines

Quoted 3 lines
Quoted 1 line
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)

I see discussion , not patch. Link?

Best regards,
Marek Vasut

Lukasz Majewski

author

2013-07-05 15:25 UTC #8 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:

Hi,

Quoted 28 lines

Dear Tom Rini,
Quoted 26 lines · Marek Vasut
Quoted 25 lines
Dear Tom Rini,
Quoted 23 lines · Marek Vasut
Quoted 21 lines
Dear Tom Rini,
Quoted 10 lines
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
Quoted 7 lines · wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukasz Majewski <[email protected]> Cc:
Tom Rini <[email protected]> Cc: Pantelis Antoniou <[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...

Quoted 9 lines

Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?

Here you are:
http://patchwork.ozlabs.org/patch/257068/

:-)

Quoted 6 lines

Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Sumit Gemini

2013-07-07 06:43 UTC #9 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

HI All,
May i know how DFU upload functionality resolved as still i am facing
problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.

Please give me pointer to solution of this problem

Regards
~Sumit Gemini

Quoted 66 lines · Lukasz Majewski

On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Quoted 28 lines
Dear Tom Rini,
Quoted 26 lines · Marek Vasut
Quoted 25 lines
Dear Tom Rini,
Quoted 23 lines · Marek Vasut
Quoted 21 lines
Dear Tom Rini,
Quoted 10 lines
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
Quoted 7 lines · wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukasz Majewski <[email protected]> Cc:
Tom Rini <[email protected]> Cc: Pantelis Antoniou <[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are:
http://patchwork.ozlabs.org/patch/257068/
:-)
Quoted 6 lines
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Lukasz Majewski

author

2013-07-08 06:22 UTC #10 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote:

Hi Sumit,

Quoted 4 lines

HI All,
May i know how DFU upload functionality resolved as still i am
facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.

From what medium do you copy? Is that NAND or eMMC device.

Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs.

Quoted 76 lines

Please give me pointer to solution of this problem
Regards
~Sumit Gemini
Quoted 66 lines · Lukasz Majewski
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Quoted 28 lines
Dear Tom Rini,
Quoted 26 lines · Marek Vasut
Quoted 25 lines
Dear Tom Rini,
Quoted 23 lines · Marek Vasut
Quoted 21 lines
Dear Tom Rini,
Quoted 10 lines
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
Quoted 7 lines · wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]> Cc: Pantelis Antoniou
<[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are:
http://patchwork.ozlabs.org/patch/257068/
:-)
Quoted 6 lines
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Sumit Gemini

2013-07-08 08:59 UTC #11 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

HI Lukasz,

I am using spi nor flash, and may i know the fixes which you fixed, and
all changes. because i am facing problem only in upload.

Please help me in this issue.

Thanks
~Sumit

Quoted 100 lines · Lukasz Majewski

On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote:
Hi Sumit,
Quoted 4 lines
HI All,
May i know how DFU upload functionality resolved as still i am
facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done.
From what medium do you copy? Is that NAND or eMMC device.
Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs.
Quoted 76 lines
Please give me pointer to solution of this problem
Regards
~Sumit Gemini
Quoted 66 lines · Lukasz Majewski
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
Hi,
Quoted 28 lines
Dear Tom Rini,
Quoted 26 lines · Marek Vasut
Quoted 25 lines
Dear Tom Rini,
Quoted 23 lines · Marek Vasut
Quoted 21 lines
Dear Tom Rini,
Quoted 10 lines
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
Quoted 7 lines · wrote:
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*].
For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]> Cc: Pantelis Antoniou
<[email protected]> Cc: Marek Vasut <[email protected]> Cc: Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Tom, why are you picking USB changes now? This is creating quite some mess ...
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Just trying to clear up the queue of fixes.
Ok, if you manage to merge it with the USB PR ...
Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :)
I see discussion , not patch. Link?
Here you are:
http://patchwork.ozlabs.org/patch/257068/
:-)
Quoted 6 lines
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Tom Rini

2013-07-08 14:16 UTC #12 lore raw

PATCH 2/2 dfu:ext4:fix Fix DFU upload functionality

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Sumit Gemini

HI Lukasz,
I am using spi nor flash, and may i know the fixes which you fixed, and all changes. because i am facing problem only in upload.

This means you are not using mainline, as we do not have DFU for SPI.
Please post it, or hassle your vendor (I suspect I know who it is) to
get the patches posted. Thanks!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJR2sm9AAoJENk4IS6UOR1WuRUP/iKBpBTUO+hAphWC+kqrjAgn 5z0zQbZNSL4S2eGCdI4ApmVs7uMxavPFf2hukwX4pJal631G8AkAPfgfiYRMYZ3U iv6mkhwSV0IMxE4zemcZkfABILo+O5+2RlJo7QUvSaNs5c3xNBkdIb20797ORinS MNi17zYeFph8NDYz/TTcIE0MWLwcH/skW8jabw6skgaeoEa+wUIJTayExe7thTcJ S1ZuAk6WQ5SKQ5hAdKTjNtPTv35ZK5IFYp1HIKpCiq2RHCUHzuvgdlz60fcbdQSI 9Av9c+9zWO90vEFK+0dT8LkdRylPrGdH/CnRNFep9DKnHUrBPdMGIYN94MRCpIiJ TWIPD2LvquwJAMeARw9Wak+fnTb/7K1xMN2A+LyRV+N6sRgB46b71lQkE/I5+6E3 QC0RD4pG70gXQSmJfolpwgjdk3NvFuzDGTasjW0e23I6znKivGvTJU56fs4lZ9Mi jvRk9qeWVL4JrFXVXcvciRUXgaNk3GNymvkJd+QUybh+ZW09NEaLMpBAye9xg80Q eQd4acdg92P8x7/3avKS8Z2xjWqLvwOPJD8ux2lmEMq6PnVH7bRxHCyW1ZNI4vQk wc9Gbt0TTFVax0v/lxqtXgpr7y4WqjvQPWh1cTErkELo00tdx95q4xeKvQHl4Oyi +h/+U2ot7gBB82SfYk+x
=fB83
-----END PGP SIGNATURE-----

Tom Rini

2013-07-03 19:33 UTC #13 lore raw

PATCH 1/2 dfu:ext4:fix Fix ext4{read|write} command formatting

In reply to Lukasz Majewski

Quoted 7 lines · ??ukasz Majewski

In the following commit:
"dfu: Support larger than memory transfers."
SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
The ext4{read|write} command formatting has been changed. It removed a write mandatory [sizebytes] parameter.

Quoted 8 lines

It extents DFU_FS_EXT4 case at mmc_file_op to provide mandatory parameter for DFU write.
Signed-off-by Lukasz Majewski <[email protected]>
Cc Tom Rini <[email protected]>
Cc Pantelis Antoniou <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Heiko Schocher <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130703/bcfe6cb8/attachment.pgp>