Skip to contentSkip to conversation

bitwise: xml: export len node

PATCH Applied Arturo Borrero Gonzalez 2 participants 2 messages Jul 8, 2013 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitwise: xml: export len node

The len unsigned int was not being exported in XML.

---
 src/expr/bitwise.c                 |    5 +++--
 tests/xmlfiles/20-rule-bitwise.xml |    1 +
 2 files changed, 4 insertions(+), 2 deletions(-)
src/expr/bitwise.c +3 -2
index 67c120f..52fc648 100644
@@ -280,8 +280,9 @@ nft_rule_expr_bitwise_snprintf_xml(char *buf, size_t size,
 	int len = size, offset = 0, ret;
 
 	ret = snprintf(buf, len, "<sreg>%u</sreg>"
-				"<dreg>%u</dreg>",
-		       bitwise->sreg, bitwise->dreg);
+				"<dreg>%u</dreg>"
+				"<len>%u</len>",
+		       bitwise->sreg, bitwise->dreg, bitwise->len);
 	SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
 
 	ret = snprintf(buf+offset, len, "<mask>");
tests/xmlfiles/20-rule-bitwise.xml +1 -0
index 411e28f..ce2d851 100644
@@ -3,6 +3,7 @@
   <expr type="bitwise">
     <sreg>2</sreg>
     <dreg>2</dreg>
+    <len>16</len>
     <mask>
       <data_reg type="value">
         <len>16</len>
maintainer Applied
#1 lore raw
Quoted 1 line · Arturo Borrero Gonzalez

The len unsigned int was not being exported in XML.

Applied, thanks.