Skip to contentSkip to conversation

perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build

PATCH Applied Jiri Olsa 2 participants 2 messages Jul 7, 2013 – Jul 8, 2013 perf events

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 perf tools: Fix boolean for NO_LIBPYTHON=1 NO_LIBPERL=1 build

The build is broken for 'NO_LIBPYTHON=1 NO_LIBPERL=1' switches.

The reason is that without perl and python support we dont have TRUE/FALSE macro definitions in dso and vdso objects (added there by commit 7821317).

Using stdbool.h defines instead which seems to be more common in perf code anyway.

Cc Waiman Long <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Corey Ashford <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc David Ahern <[email protected]>
---
 tools/perf/util/dso.c  | 2 +-
 tools/perf/util/vdso.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/dso.c +1 -1
index 3d80f92..c4374f0 100644
@@ -531,7 +531,7 @@ struct dso *dsos__find(struct list_head *head, const char *name, bool cmp_short)
 
 struct dso *__dsos__findnew(struct list_head *head, const char *name)
 {
-	struct dso *dso = dsos__find(head, name, FALSE);
+	struct dso *dso = dsos__find(head, name, false);
 
 	if (!dso) {
 		dso = dso__new(name);
tools/perf/util/vdso.c +1 -1
index a8fd73d..3915982 100644
@@ -91,7 +91,7 @@ void vdso__exit(void)
 
 struct dso *vdso__dso_findnew(struct list_head *head)
 {
-	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, TRUE);
+	struct dso *dso = dsos__find(head, VDSO__MAP_NAME, true);
 
 	if (!dso) {
 		char *file;
Signature · 1 line
1.7.11.7
#1 lore raw

Em Sun, Jul 07, 2013 at 03:55:39PM +0200, Jiri Olsa escreveu:

Quoted 8 lines

The build is broken for 'NO_LIBPYTHON=1 NO_LIBPERL=1' switches.

The reason is that without perl and python support we dont have TRUE/FALSE macro definitions in dso and vdso objects (added there by commit 7821317).

Using stdbool.h defines instead which seems to be more common in perf code anyway.

Thanks, applied.

- Arnaldo