Skip to contentSkip to conversation

Generic PHY Framework

PATCH Superseded Kishon Vijay Abraham I 5 participants 33 messages Jun 26, 2013 – Jul 30, 2013

Subsystems (9)

v9 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v9 cover Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.

This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy drivers spread all over the Linux kernel to drivers/phy to increase code re-use and to increase code maintainability.

Comments to make PHY as bus wasn't done because PHY devices can be part of other bus and making a same device attached to multiple bus leads to bad design.

If the PHY driver has to send notification on connect/disconnect, the PHY driver should make use of the extcon framework. Using this susbsystem to use extcon framwork will have to be analysed.

Making omap-usb2 and twl4030 to use this framework is provided as a sample.

This patch series is developed on linux mainline tree.

This framework is already being used by display PHYs
http://www.spinics.net/lists/arm-kernel/msg251666.html

These patches are hosted in git://gitorious.org/linuxphy/linuxphy.git testing

Changes from v8:
* Added phy_set_drvdata and phy_get_drvdata in phy.h.
* Changed phy_create API not to take void *priv. private data should now be set using phy_set_drvdata now.

Changes from v7:
* Fixed Documentation
* Added to_phy, of_phy_provider_register and devm_of_phy_provider_register
* modified runtime_pm usage in phy_init, phy_exit, phy_power_on and phy_power_off. Now phy_power_on will enable the clocks and phy_power_off will disable the clocks.
* pm_runtime_no_callbacks() is added so that pm_runtime_get_sync doesn't fail
* modified other patches to adhere to the changes in the PHY framework
* removed usb: phy: twl4030: twl4030 shouldn't be subsys_initcall as it will be merged separately.
* reference counting has been added to protect phy ops when the PHY is shared by multiple consumers.

Changes from v6
* corrected few typos in Documentation
* Changed PHY Subsystem to *bool* in Kconfig (to avoid compilation errors when PHY Subsystem is kept as module and the dependent modules are built-in)
* Added if pm_runtime_enabled check before runtime pm calls.

Changes from v5:
* removed the new sysfs entries as it dint have any new information other than what is already there in /sys/devices/...
* removed a bunch of APIs added to get the PHY and now only phy_get and devm_phy_get are used.
* Added new APIs to register/unregister the PHY provider. This is needed for dt boot case.
* Enabled pm runtime and incorporated the comments given by Alan Stern in a different patch series by Gautam.
* Removed the *phy_bind* API. Now the phy binding information should be passed using the platform data to the controller devices.
* Fixed a few typos.

Changes from v4:
* removed of_phy_get_with_args/devm_of_phy_get_with_args. Now the *phy providers* should use their custom implementation of of_xlate or use of_phy_xlate to get *phy instance* from *phy providers*.
* Added of_phy_xlate to be used by *phy providers* if it provides only one PHY.
* changed phy_core from having subsys_initcall to module_init.
* other minor fixes.

Changes from v3:
* Changed the return value of PHY APIs to ENOSYS
* Added APIs of_phy_get_with_args/devm_of_phy_get_with_args to support getting PHYs if the same IP implements multiple PHYs.
* modified phy_bind API so that the binding information can now be _updated_. In effect of this removed the binding information added in board files and added only in usb-musb.c. If a particular board uses a different phy binding, it can update it in board file after usb_musb_init().
* Added Documentation/devicetree/bindings/phy/phy-bindings.txt for dt binding information.

Changes from v2:
* removed phy_descriptor structure completely so changed the APIs which were taking phy_descriptor as parameters
* Added 2 more APIs *of_phy_get_byname* and *devm_of_phy_get_byname* to be used by PHY user drivers which has *phy* and *phy-names* binding in the dt data
* Fixed a few typos
* Removed phy_list and we now use class_dev_iter_init, class_dev_iter_next and class_dev_iter_exit for traversing through the phy list. (Note we still need phy_bind list and phy_bind_mutex).
* Changed the sysfs entry name from *bind* to *phy_bind*.

Changes from v1:
* Added Documentation for the PHY framework
* Added few more APIs mostly w.r.t devres
* Modified omap-usb2 and twl4030 to make use of the new framework

Did USB enumeration testing in panda and beagle.

Kishon Vijay Abraham I (8):
drivers: phy: add generic PHY framework
usb: phy: omap-usb2: use the new generic PHY framework
usb: phy: twl4030: use the new generic PHY framework
ARM: OMAP: USB: Add phy binding information
ARM: dts: omap: update usb_otg_hs data
usb: musb: omap2430: use the new generic PHY framework
usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

 .../devicetree/bindings/phy/phy-bindings.txt       |   66 +++
 Documentation/devicetree/bindings/usb/omap-usb.txt |    5 +
 Documentation/devicetree/bindings/usb/usb-phy.txt  |    6 +
 Documentation/phy.txt                              |  129 +++++
 MAINTAINERS                                        |    7 +
 arch/arm/boot/dts/omap3-beagle-xm.dts              |    2 +
 arch/arm/boot/dts/omap3-evm.dts                    |    2 +
 arch/arm/boot/dts/omap3-overo.dtsi                 |    2 +
 arch/arm/boot/dts/omap4.dtsi                       |    3 +
 arch/arm/boot/dts/twl4030.dtsi                     |    1 +
 arch/arm/mach-omap2/usb-musb.c                     |    6 +-
 drivers/Kconfig                                    |    2 +
 drivers/Makefile                                   |    2 +
 drivers/phy/Kconfig                                |   13 +
 drivers/phy/Makefile                               |    5 +
 drivers/phy/phy-core.c                             |  544 ++++++++++++++++++++
 drivers/usb/musb/Kconfig                           |    1 +
 drivers/usb/musb/musb_core.c                       |    1 +
 drivers/usb/musb/musb_core.h                       |    3 +
 drivers/usb/musb/omap2430.c                        |   26 +-
 drivers/usb/phy/Kconfig                            |    1 +
 drivers/usb/phy/phy-omap-usb2.c                    |   60 ++-
 drivers/usb/phy/phy-twl4030-usb.c                  |   63 ++-
 include/linux/phy/phy.h                            |  344 +++++++++++++
 include/linux/usb/musb.h                           |    3 +
 25 files changed, 1243 insertions(+), 54 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/phy-bindings.txt
 create mode 100644 Documentation/phy.txt
 create mode 100644 drivers/phy/Kconfig
 create mode 100644 drivers/phy/Makefile
 create mode 100644 drivers/phy/phy-core.c
 create mode 100644 include/linux/phy/phy.h
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v9 1/8 drivers: phy: add generic PHY framework

The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework.

PHY drivers should create the PHY by passing id and ops like init, exit, power_on and power_off. This framework is also pm runtime enabled.

The documentation for the generic PHY framework is added in Documentation/phy.txt and the documentation for dt binding can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt

---
 .../devicetree/bindings/phy/phy-bindings.txt       |   66 +++
 Documentation/phy.txt                              |  129 +++++
 MAINTAINERS                                        |    7 +
 drivers/Kconfig                                    |    2 +
 drivers/Makefile                                   |    2 +
 drivers/phy/Kconfig                                |   13 +
 drivers/phy/Makefile                               |    5 +
 drivers/phy/phy-core.c                             |  544 ++++++++++++++++++++
 include/linux/phy/phy.h                            |  344 +++++++++++++
 9 files changed, 1112 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/phy-bindings.txt
 create mode 100644 Documentation/phy.txt
 create mode 100644 drivers/phy/Kconfig
 create mode 100644 drivers/phy/Makefile
 create mode 100644 drivers/phy/phy-core.c
 create mode 100644 include/linux/phy/phy.h
Documentation/devicetree/bindings/phy/phy-bindings.txt new file +66 -0
new file mode 100644
index 0000000..8ae844f
@@ -0,0 +1,66 @@
+This document explains only the device tree data binding. For general
+information about PHY subsystem refer to Documentation/phy.txt
+
+PHY device node
+===============
+
+Required Properties:
+#phy-cells:	Number of cells in a PHY specifier;  The meaning of all those
+		cells is defined by the binding for the phy node. The PHY
+		provider can use the values in cells to find the appropriate
+		PHY.
+
+For example:
+
+phys: phy {
+    compatible = "xxx";
+    reg = <...>;
+    .
+    .
+    #phy-cells = <1>;
+    .
+    .
+};
+
+That node describes an IP block (PHY provider) that implements 2 different PHYs.
+In order to differentiate between these 2 PHYs, an additonal specifier should be
+given while trying to get a reference to it.
+
+PHY user node
+=============
+
+Required Properties:
+phys : the phandle for the PHY device (used by the PHY subsystem)
+phy-names : the names of the PHY corresponding to the PHYs present in the
+	    *phys* phandle
+
+Example 1:
+usb1: usb_otg_ss at xxx {
+    compatible = "xxx";
+    reg = <xxx>;
+    .
+    .
+    phys = <&usb2_phy>, <&usb3_phy>;
+    phy-names = "usb2phy", "usb3phy";
+    .
+    .
+};
+
+This node represents a controller that uses two PHYs, one for usb2 and one for
+usb3.
+
+Example 2:
+usb2: usb_otg_ss at xxx {
+    compatible = "xxx";
+    reg = <xxx>;
+    .
+    .
+    phys = <&phys 1>;
+    phy-names = "usbphy";
+    .
+    .
+};
+
+This node represents a controller that uses one of the PHYs of the PHY provider
+device defined previously. Note that the phy handle has an additional specifier
+"1" to differentiate between the two PHYs.
Documentation/phy.txt new file +129 -0

129 lines not on this page · raw message

MAINTAINERS +7 -0
index 0c9dc71..c234461 100644
@@ -3536,6 +3536,13 @@ S:	Maintained
 F:	include/asm-generic
 F:	include/uapi/asm-generic
 
+GENERIC PHY FRAMEWORK
+M:	Kishon Vijay Abraham I <[email protected]>
+L:	linux-kernel at vger.kernel.org
+S:	Supported
+F:	drivers/phy/
+F:	include/linux/phy/
+
 GENERIC UIO DRIVER FOR PCI DEVICES
 M:	"Michael S. Tsirkin" <[email protected]>
 L:	kvm at vger.kernel.org
drivers/Kconfig +2 -0
index 9953a42..2943fb6 100644
@@ -166,4 +166,6 @@ source "drivers/ipack/Kconfig"
 
 source "drivers/reset/Kconfig"
 
+source "drivers/phy/Kconfig"
+
 endmenu
drivers/Makefile +2 -0
index 130abc1..46c99a1 100644
@@ -8,6 +8,8 @@
 obj-y				+= irqchip/
 obj-y				+= bus/
 
+obj-$(CONFIG_GENERIC_PHY)	+= phy/
+
 # GPIO must come after pinctrl as gpios may need to mux pins etc
 obj-y				+= pinctrl/
 obj-y				+= gpio/
drivers/phy/Kconfig new file +13 -0
new file mode 100644
index 0000000..5f85909
@@ -0,0 +1,13 @@
+#
+# PHY
+#
+
+menuconfig GENERIC_PHY
+	tristate "PHY Subsystem"
+	help
+	  Generic PHY support.
+
+	  This framework is designed to provide a generic interface for PHY
+	  devices present in the kernel. This layer will have the generic
+	  API by which phy drivers can create PHY using the phy framework and
+	  phy users can obtain reference to the PHY.
drivers/phy/Makefile new file +5 -0
new file mode 100644
index 0000000..9e9560f
@@ -0,0 +1,5 @@
+#
+# Makefile for the phy drivers.
+#
+
+obj-$(CONFIG_GENERIC_PHY)	+= phy-core.o
drivers/phy/phy-core.c new file +544 -0

544 lines not on this page · raw message

include/linux/phy/phy.h new file +344 -0

344 lines not on this page · raw message

Signature · 1 line
1.7.10.4
Acked-by on v9 1/8
#2 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Quoted 8 lines · Kishon Vijay Abraham I

The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework.

PHY drivers should create the PHY by passing id and ops like init, exit, power_on and power_off. This framework is also pm runtime enabled.

Quoted 6 lines

The documentation for the generic PHY framework is added in Documentation/phy.txt and the documentation for dt binding can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt

looks great to my eyes

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/47aed22b/attachment.sig>
maintainer
#3 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

In reply to Kishon Vijay Abraham I

drivers/phy/Kconfig line 13

Quoted 9 lines · Kishon Vijay Abraham I
drivers/phy/Kconfig new file +9 -0
+menuconfig GENERIC_PHY
+	tristate "PHY Subsystem"
+	help
+	  Generic PHY support.
+
+	  This framework is designed to provide a generic interface for PHY
+	  devices present in the kernel. This layer will have the generic
+	  API by which phy drivers can create PHY using the phy framework and
+	  phy users can obtain reference to the PHY.

Shouldn't this be something that other drivers select? How will anyone know if they need this or not?

Quoted 4 lines
drivers/phy/phy-core.c new file +1 -0
@@ -0,0 +1,544 @@
+/*

drivers/phy/phy-core.c line 11

Quoted 10 lines
drivers/phy/phy-core.c new file +10 -0
+ * phy-core.c  --  Generic Phy framework.
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
+ * Author: Kishon Vijay Abraham I <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.

You really mean "any later version" (I have to ask)?

drivers/phy/phy-core.c line 19

Quoted 7 lines
drivers/phy/phy-core.c new file +7 -0
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.

Are these two paragraphs needed? This isn't a "program", and they got a copy of the GPL already with the kernel.

drivers/phy/phy-core.c line 32

Quoted 1 line
drivers/phy/phy-core.c new file +1 -0
+static struct class *phy_class;

Why do you need a class?

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

thanks,

greg k-h

#4 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Hi,

Quoted 13 lines · Greg KH

drivers/phy/Kconfig line 13

Quoted 9 lines · Kishon Vijay Abraham I
drivers/phy/Kconfig new file +9 -0
+menuconfig GENERIC_PHY
+	tristate "PHY Subsystem"
+	help
+	  Generic PHY support.
+
+	  This framework is designed to provide a generic interface for PHY
+	  devices present in the kernel. This layer will have the generic
+	  API by which phy drivers can create PHY using the phy framework and
+	  phy users can obtain reference to the PHY.

Shouldn't this be something that other drivers select? How will anyone know if they need this or not?

All the PHY drivers should go here. So only if *GENERIC_PHY* is enabled those PHY drivers can be selected like in [1].
The PHY consumer driver should ideally use *depends on* in their Kconfig.

[1] ->
http://archive.arm.linux.org.uk/lurker/message/20130628.134308.4a8f7668.ca.html

Quoted 17 lines
Quoted 5 lines
drivers/phy/phy-core.c new file +1 -0
@@ -0,0 +1,544 @@
+/*

drivers/phy/phy-core.c line 11

Quoted 10 lines
drivers/phy/phy-core.c new file +10 -0
+ * phy-core.c  --  Generic Phy framework.
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
+ * Author: Kishon Vijay Abraham I <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.

You really mean "any later version" (I have to ask)?

That was copied from somewhere :-s

Quoted 11 lines

drivers/phy/phy-core.c line 19

Quoted 8 lines
drivers/phy/phy-core.c new file +7 -0
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.

Are these two paragraphs needed? This isn't a "program", and they got a copy of the GPL already with the kernel.

hmm.. I can remove that.

Quoted 4 lines

drivers/phy/phy-core.c line 32

Quoted 2 lines
drivers/phy/phy-core.c new file +1 -0
+static struct class *phy_class;

Why do you need a class?

Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then it was decided to go with class itself.

[3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html

Quoted 3 lines

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

I'm not actually adding any new sysfs entry other than what a *class_create* must have created. Do I need to add one for that?

Thanks
Kishon

maintainer
#5 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Quoted 17 lines · Kishon Vijay Abraham I

Hi,

Quoted 13 lines · Greg KH

drivers/phy/Kconfig line 13

Quoted 9 lines · Kishon Vijay Abraham I
drivers/phy/Kconfig new file +9 -0
+menuconfig GENERIC_PHY
+	tristate "PHY Subsystem"
+	help
+	  Generic PHY support.
+
+	  This framework is designed to provide a generic interface for PHY
+	  devices present in the kernel. This layer will have the generic
+	  API by which phy drivers can create PHY using the phy framework and
+	  phy users can obtain reference to the PHY.

Shouldn't this be something that other drivers select? How will anyone know if they need this or not?

Quoted 6 lines

All the PHY drivers should go here. So only if *GENERIC_PHY* is enabled those PHY drivers can be selected like in [1].
The PHY consumer driver should ideally use *depends on* in their Kconfig.

[1] ->
http://archive.arm.linux.org.uk/lurker/message/20130628.134308.4a8f7668.ca.html

No, switch it around the other way. How would I even _know_ that I need to enable the generic PHY subsystem in the first place? How can I determine that I need this for my hardware? You need to give hints to someone who doesn't even know what a PHY is, otherwise they will always disable it and move on.

Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
drivers/phy/phy-core.c new file +5 -0
@@ -0,0 +1,544 @@
+/*
+ * phy-core.c  --  Generic Phy framework.
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
Quoted 8 lines

drivers/phy/phy-core.c line 11

Quoted 6 lines
drivers/phy/phy-core.c new file +6 -0
+ * Author: Kishon Vijay Abraham I <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.

You really mean "any later version" (I have to ask)?

Quoted 1 line

That was copied from somewhere :-s

So, is that what you really mean to have for this code?

Quoted 15 lines
Quoted 10 lines

drivers/phy/phy-core.c line 19

Quoted 7 lines
drivers/phy/phy-core.c new file +7 -0
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.

Are these two paragraphs needed? This isn't a "program", and they got a copy of the GPL already with the kernel.

hmm.. I can remove that.

Quoted 3 lines
Quoted 2 lines
drivers/phy/phy-core.c new file +1 -0
+static struct class *phy_class;
Quoted 8 lines
Quoted 1 line

Why do you need a class?

Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then it was decided to go with class itself.

[3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html

Ok, but what does the class usage get you?

Quoted 5 lines
Quoted 2 lines

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

I'm not actually adding any new sysfs entry other than what a *class_create* must have created. Do I need to add one for that?

If you are not creating anything in sysfs at all, why use the driver model? (hint, I think you need to do something here to justify it...)

thanks,

greg k-h

#6 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Hi,

Quoted 48 lines · Greg KH
Quoted 17 lines · Kishon Vijay Abraham I

Hi,

Quoted 13 lines · Greg KH

drivers/phy/Kconfig line 13

Quoted 9 lines · Kishon Vijay Abraham I
drivers/phy/Kconfig new file +9 -0
+menuconfig GENERIC_PHY
+	tristate "PHY Subsystem"
+	help
+	  Generic PHY support.
+
+	  This framework is designed to provide a generic interface for PHY
+	  devices present in the kernel. This layer will have the generic
+	  API by which phy drivers can create PHY using the phy framework and
+	  phy users can obtain reference to the PHY.

Shouldn't this be something that other drivers select? How will anyone know if they need this or not?

Quoted 6 lines

All the PHY drivers should go here. So only if *GENERIC_PHY* is enabled those PHY drivers can be selected like in [1].
The PHY consumer driver should ideally use *depends on* in their Kconfig.

[1] ->
http://archive.arm.linux.org.uk/lurker/message/20130628.134308.4a8f7668.ca.html

No, switch it around the other way. How would I even _know_ that I need to enable the generic PHY subsystem in the first place? How can I determine that I need this for my hardware? You need to give hints to someone who doesn't even know what a PHY is, otherwise they will always disable it and move on.

Quoted 17 lines
Quoted 16 lines
Quoted 4 lines
drivers/phy/phy-core.c new file +1 -0
@@ -0,0 +1,544 @@
+/*

drivers/phy/phy-core.c line 11

Quoted 10 lines
drivers/phy/phy-core.c new file +10 -0
+ * phy-core.c  --  Generic Phy framework.
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
+ * Author: Kishon Vijay Abraham I <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.

You really mean "any later version" (I have to ask)?

Quoted 3 lines
Quoted 1 line

That was copied from somewhere :-s

So, is that what you really mean to have for this code?

indeed.

Quoted 18 lines
Quoted 18 lines
Quoted 11 lines

drivers/phy/phy-core.c line 19

Quoted 8 lines
drivers/phy/phy-core.c new file +7 -0
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.

Are these two paragraphs needed? This isn't a "program", and they got a copy of the GPL already with the kernel.

hmm.. I can remove that.

Quoted 4 lines

drivers/phy/phy-core.c line 32

Quoted 2 lines
drivers/phy/phy-core.c new file +1 -0
+static struct class *phy_class;

Why do you need a class?

Quoted 8 lines
Quoted 6 lines

Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then it was decided to go with class itself.

[3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html

Ok, but what does the class usage get you?

hmm.. actually I use class only to iterate through the list of devices in *phy* class which could very well be implemented using list. Just that I wont have a /sys/class/phy/ entry to find the list of phys added in the system. I dont think I want to add any other stuff to expose to the user space at this point of time.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

I'm not actually adding any new sysfs entry other than what a *class_create* must have created. Do I need to add one for that?

If you are not creating anything in sysfs at all, why use the driver model? (hint, I think you need to do something here to justify it...)

Well.. it helps me to use pm_runtime to enable clocks utilizing the parent-child relationship.

Thanks
Kishon

maintainer
#7 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Quoted 18 lines · Kishon Vijay Abraham I
Quoted 8 lines
Quoted 6 lines

Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then it was decided to go with class itself.

[3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html

Ok, but what does the class usage get you?

hmm.. actually I use class only to iterate through the list of devices in *phy* class which could very well be implemented using list. Just that I wont have a /sys/class/phy/ entry to find the list of phys added in the system. I dont think I want to add any other stuff to expose to the user space at this point of time.

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'm not actually adding any new sysfs entry other than what a *class_create* must have created. Do I need to add one for that?

If you are not creating anything in sysfs at all, why use the driver model? (hint, I think you need to do something here to justify it...)

Well.. it helps me to use pm_runtime to enable clocks utilizing the parent-child relationship.

Ok, that's a good reason for this, nevermind then. Care to send the latest patches you have in emails so I can review them?

thanks,

greg k-h

#8 lore raw

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

Quoted 22 lines · Greg KH
Quoted 21 lines · Kishon Vijay Abraham I
Quoted 8 lines
Quoted 6 lines

Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then it was decided to go with class itself.

[3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html

Ok, but what does the class usage get you?

hmm.. actually I use class only to iterate through the list of devices in *phy* class which could very well be implemented using list. Just that I wont have a /sys/class/phy/ entry to find the list of phys added in the system. I dont think I want to add any other stuff to expose to the user space at this point of time.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

When modifying/adding new sysfs stuff, you need a Documentation/ABI/ entry as well.

I'm not actually adding any new sysfs entry other than what a *class_create* must have created. Do I need to add one for that?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

If you are not creating anything in sysfs at all, why use the driver model? (hint, I think you need to do something here to justify it...)

Well.. it helps me to use pm_runtime to enable clocks utilizing the parent-child relationship.

Ok, that's a good reason for this, nevermind then. Care to send the latest patches you have in emails so I can review them?

Sure.

Thanks
Kishon

#9 lore raw

PATCH v9 2/8 usb: phy: omap-usb2: use the new generic PHY framework

In reply to Kishon Vijay Abraham I

Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively.

However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library.

---
 drivers/usb/phy/Kconfig         |    1 +
 drivers/usb/phy/phy-omap-usb2.c |   45 +++++++++++++++++++++++++++++++++++----
 2 files changed, 42 insertions(+), 4 deletions(-)
drivers/usb/phy/Kconfig +1 -0
index 7ef3eb8..5caeafd 100644
@@ -69,6 +69,7 @@ config OMAP_CONTROL_USB
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on GENERIC_PHY
 	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
drivers/usb/phy/phy-omap-usb2.c +41 -4

79 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#10 lore raw

PATCH v9 3/8 usb: phy: twl4030: use the new generic PHY framework

In reply to Kishon Vijay Abraham I

Used the generic PHY framework API to create the PHY. For powering on and powering off the PHY, power_on and power_off ops are used. Once the MUSB OMAP glue is adapted to the new framework, the suspend and resume ops of usb phy library will be removed.

However using the old usb phy library cannot be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library.

---
 drivers/usb/phy/phy-twl4030-usb.c |   50 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 49 insertions(+), 1 deletion(-)
drivers/usb/phy/phy-twl4030-usb.c +49 -1
index 8fbe2d9..437ba30 100644
@@ -33,6 +33,7 @@
 #include <linux/io.h>
 #include <linux/delay.h>
 #include <linux/usb/otg.h>
+#include <linux/phy/phy.h>
 #include <linux/usb/musb-omap.h>
 #include <linux/usb/ulpi.h>
 #include <linux/i2c/twl.h>
@@ -431,6 +432,14 @@ static void twl4030_phy_suspend(struct twl4030_usb *twl, int controller_off)
 	dev_dbg(twl->dev, "%s\n", __func__);
 }
 
+static int twl4030_phy_power_off(struct phy *phy)
+{
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
+
+	twl4030_phy_suspend(twl, 0);
+	return 0;
+}
+
 static void __twl4030_phy_resume(struct twl4030_usb *twl)
 {
 	twl4030_phy_power(twl, 1);
@@ -459,6 +468,14 @@ static void twl4030_phy_resume(struct twl4030_usb *twl)
 	}
 }
 
+static int twl4030_phy_power_on(struct phy *phy)
+{
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
+
+	twl4030_phy_resume(twl);
+	return 0;
+}
+
 static int twl4030_usb_ldo_init(struct twl4030_usb *twl)
 {
 	/* Enable writing to power configuration registers */
@@ -602,13 +619,22 @@ static int twl4030_usb_phy_init(struct usb_phy *phy)
 	status = twl4030_usb_linkstat(twl);
 	twl->linkstat = status;
 
-	if (status == OMAP_MUSB_ID_GROUND || status == OMAP_MUSB_VBUS_VALID)
+	if (status == OMAP_MUSB_ID_GROUND || status == OMAP_MUSB_VBUS_VALID) {
 		omap_musb_mailbox(twl->linkstat);
+		twl4030_phy_resume(twl);
+	}
 
 	sysfs_notify(&twl->dev->kobj, NULL, "vbus");
 	return 0;
 }
 
+static int twl4030_phy_init(struct phy *phy)
+{
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
+
+	return twl4030_usb_phy_init(&twl->phy);
+}
+
 static int twl4030_set_suspend(struct usb_phy *x, int suspend)
 {
 	struct twl4030_usb *twl = phy_to_twl(x);
@@ -646,13 +672,22 @@ static int twl4030_set_host(struct usb_otg *otg, struct usb_bus *host)
 	return 0;
 }
 
+static const struct phy_ops ops = {
+	.init		= twl4030_phy_init,
+	.power_on	= twl4030_phy_power_on,
+	.power_off	= twl4030_phy_power_off,
+	.owner		= THIS_MODULE,
+};
+
 static int twl4030_usb_probe(struct platform_device *pdev)
 {
 	struct twl4030_usb_data *pdata = pdev->dev.platform_data;
 	struct twl4030_usb	*twl;
+	struct phy		*phy;
 	int			status, err;
 	struct usb_otg		*otg;
 	struct device_node	*np = pdev->dev.of_node;
+	struct phy_provider	*phy_provider;
 
 	twl = devm_kzalloc(&pdev->dev, sizeof *twl, GFP_KERNEL);
 	if (!twl)
@@ -689,6 +724,19 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 	otg->set_host		= twl4030_set_host;
 	otg->set_peripheral	= twl4030_set_peripheral;
 
+	phy_provider = devm_of_phy_provider_register(twl->dev,
+		of_phy_simple_xlate);
+	if (IS_ERR(phy_provider))
+		return PTR_ERR(phy_provider);
+
+	phy = devm_phy_create(twl->dev, 0, &ops, "twl4030");
+	if (IS_ERR(phy)) {
+		dev_dbg(&pdev->dev, "Failed to create PHY\n");
+		return PTR_ERR(phy);
+	}
+
+	phy_set_drvdata(phy, twl);
+
 	/* init spinlock for workqueue */
 	spin_lock_init(&twl->lock);
 
Signature · 1 line
1.7.10.4
#11 lore raw

PATCH v9 4/8 ARM: OMAP: USB: Add phy binding information

In reply to Kishon Vijay Abraham I

In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller.

---
 arch/arm/mach-omap2/usb-musb.c |    6 +++++-
 include/linux/usb/musb.h       |    3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)
arch/arm/mach-omap2/usb-musb.c +5 -1
index 3242a55..284ba51 100644
@@ -85,8 +85,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
 	musb_plat.mode = board_data->mode;
 	musb_plat.extvbus = board_data->extvbus;
 
-	if (cpu_is_omap44xx())
+	if (cpu_is_omap44xx()) {
 		musb_plat.has_mailbox = true;
+		musb_plat.phy_label = "omap-usb2";
+	} else if (cpu_is_omap34xx()) {
+		musb_plat.phy_label = "twl4030";
+	}
 
 	if (soc_is_am35xx()) {
 		oh_name = "am35x_otg_hs";
include/linux/usb/musb.h +3 -0
index 053c268..596f8c8 100644
@@ -104,6 +104,9 @@ struct musb_hdrc_platform_data {
 	/* for clk_get() */
 	const char	*clock;
 
+	/* phy label */
+	const char	*phy_label;
+
 	/* (HOST or OTG) switch VBUS on/off */
 	int		(*set_vbus)(struct device *dev, int is_on);
 
Signature · 1 line
1.7.10.4
#12 lore raw

PATCH v9 5/8 ARM: dts: omap: update usb_otg_hs data

In reply to Kishon Vijay Abraham I

Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. The PHY binding information can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt

---
 Documentation/devicetree/bindings/usb/omap-usb.txt |    5 +++++
 Documentation/devicetree/bindings/usb/usb-phy.txt  |    6 ++++++
 arch/arm/boot/dts/omap3-beagle-xm.dts              |    2 ++
 arch/arm/boot/dts/omap3-evm.dts                    |    2 ++
 arch/arm/boot/dts/omap3-overo.dtsi                 |    2 ++
 arch/arm/boot/dts/omap4.dtsi                       |    3 +++
 arch/arm/boot/dts/twl4030.dtsi                     |    1 +
 7 files changed, 21 insertions(+)
Documentation/devicetree/bindings/usb/omap-usb.txt +5 -0
index d4769f3..c0871a7 100644
@@ -19,6 +19,9 @@ OMAP MUSB GLUE
  - power : Should be "50". This signifies the controller can supply upto
    100mA when operating in host mode.
  - usb-phy : the phandle for the PHY device
+ - phys : the phandle for the PHY device (used by generic PHY framework)
+ - phy-names : the names of the PHY corresponding to the PHYs present in the
+   *phy* phandle.
 
 Optional properties:
  - ctrl-module : phandle of the control module this glue uses to write to
@@ -33,6 +36,8 @@ usb_otg_hs: usb_otg_hs at 4a0ab000 {
 	num-eps = <16>;
 	ram-bits = <12>;
 	ctrl-module = <&omap_control_usb>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 };
 
 Board specific device node entry
Documentation/devicetree/bindings/usb/usb-phy.txt +6 -0
index 61496f5..c0245c8 100644
@@ -5,6 +5,8 @@ OMAP USB2 PHY
 Required properties:
  - compatible: Should be "ti,omap-usb2"
  - reg : Address and length of the register set for the device.
+ - #phy-cells: determine the number of cells that should be given in the
+   phandle while referencing this phy.
 
 Optional properties:
  - ctrl-module : phandle of the control module used by PHY driver to power on
@@ -16,6 +18,7 @@ usb2phy at 4a0ad080 {
 	compatible = "ti,omap-usb2";
 	reg = <0x4a0ad080 0x58>;
 	ctrl-module = <&omap_control_usb>;
+	#phy-cells = <0>;
 };
 
 OMAP USB3 PHY
@@ -25,6 +28,8 @@ Required properties:
  - reg : Address and length of the register set for the device.
  - reg-names: The names of the register addresses corresponding to the registers
    filled in "reg".
+ - #phy-cells: determine the number of cells that should be given in the
+   phandle while referencing this phy.
 
 Optional properties:
  - ctrl-module : phandle of the control module used by PHY driver to power on
@@ -39,4 +44,5 @@ usb3phy at 4a084400 {
 	      <0x4a084c00 0x40>;
 	reg-names = "phy_rx", "phy_tx", "pll_ctrl";
 	ctrl-module = <&omap_control_usb>;
+	#phy-cells = <0>;
 };
arch/arm/boot/dts/omap3-beagle-xm.dts +2 -0
index 3046d1f..023596e 100644
@@ -123,6 +123,8 @@
 &usb_otg_hs {
 	interface-type = <0>;
 	usb-phy = <&usb2_phy>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 	mode = <3>;
 	power = <50>;
 };
arch/arm/boot/dts/omap3-evm.dts +2 -0
index 96d1c20..f2b8314 100644
@@ -69,6 +69,8 @@
 &usb_otg_hs {
 	interface-type = <0>;
 	usb-phy = <&usb2_phy>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 	mode = <3>;
 	power = <50>;
 };
arch/arm/boot/dts/omap3-overo.dtsi +2 -0
index a626c50..b65916e 100644
@@ -74,6 +74,8 @@
 &usb_otg_hs {
 	interface-type = <0>;
 	usb-phy = <&usb2_phy>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 	mode = <3>;
 	power = <50>;
 };
arch/arm/boot/dts/omap4.dtsi +3 -0
index 2a56428..dae620b 100644
@@ -517,6 +517,7 @@
 				compatible = "ti,omap-usb2";
 				reg = <0x4a0ad080 0x58>;
 				ctrl-module = <&omap_control_usb>;
+				#phy-cells = <0>;
 			};
 		};
 
@@ -655,6 +656,8 @@
 			interrupt-names = "mc", "dma";
 			ti,hwmods = "usb_otg_hs";
 			usb-phy = <&usb2_phy>;
+			phys = <&usb2_phy>;
+			phy-names = "usb2-phy";
 			multipoint = <1>;
 			num-eps = <16>;
 			ram-bits = <12>;
arch/arm/boot/dts/twl4030.dtsi +1 -0
index b3034da..ce4cd6f 100644
@@ -80,6 +80,7 @@
 		usb1v8-supply = <&vusb1v8>;
 		usb3v1-supply = <&vusb3v1>;
 		usb_mode = <1>;
+		#phy-cells = <0>;
 	};
 
 	twl_pwm: pwm {
Signature · 1 line
1.7.10.4
#13 lore raw

PATCH v9 6/8 usb: musb: omap2430: use the new generic PHY framework

In reply to Kishon Vijay Abraham I

Use the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on and power_off to align with the new PHY framework.

musb->xceiv can't be removed as of now because musb core uses xceiv.state and xceiv.otg. Once there is a separate state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework.

---
 drivers/usb/musb/Kconfig     |    1 +
 drivers/usb/musb/musb_core.c |    1 +
 drivers/usb/musb/musb_core.h |    3 +++
 drivers/usb/musb/omap2430.c  |   26 ++++++++++++++++++++------
 4 files changed, 25 insertions(+), 6 deletions(-)
drivers/usb/musb/Kconfig +1 -0
index 06f8d29..6ef595a 100644
@@ -47,6 +47,7 @@ config USB_MUSB_TUSB6010
 config USB_MUSB_OMAP2PLUS
 	tristate "OMAP2430 and onwards"
 	depends on ARCH_OMAP2PLUS
+	depends on GENERIC_PHY
 
 config USB_MUSB_AM35X
 	tristate "AM35x"
drivers/usb/musb/musb_core.c +1 -0
index 37a261a..f732bcc 100644
@@ -1864,6 +1864,7 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 	musb->board_set_power = plat->set_power;
 	musb->min_power = plat->min_power;
 	musb->ops = plat->platform_ops;
+	musb->phy_label = plat->phy_label;
 
 	/* The musb_platform_init() call:
 	 *   - adjusts musb->mregs
drivers/usb/musb/musb_core.h +3 -0
index 7fb4819..498ae21 100644
@@ -46,6 +46,7 @@
 #include <linux/usb.h>
 #include <linux/usb/otg.h>
 #include <linux/usb/musb.h>
+#include <linux/phy/phy.h>
 
 struct musb;
 struct musb_hw_ep;
@@ -357,6 +358,7 @@ struct musb {
 	u16			int_tx;
 
 	struct usb_phy		*xceiv;
+	struct phy		*phy;
 
 	int nIrq;
 	unsigned		irq_wake:1;
@@ -434,6 +436,7 @@ struct musb {
 	unsigned                double_buffer_not_ok:1;
 
 	struct musb_hdrc_config	*config;
+	const char		*phy_label;
 
 #ifdef MUSB_CONFIG_PROC_FS
 	struct proc_dir_entry *proc_entry;
drivers/usb/musb/omap2430.c +20 -6
index 628b93f..12b94da 100644
@@ -348,11 +348,21 @@ static int omap2430_musb_init(struct musb *musb)
 	 * up through ULPI.  TWL4030-family PMICs include one,
 	 * which needs a driver, drivers aren't always needed.
 	 */
-	if (dev->parent->of_node)
+	if (dev->parent->of_node) {
+		musb->phy = devm_phy_get(dev->parent, "usb2-phy");
+
+		/* We can't totally remove musb->xceiv as of now because
+		 * musb core uses xceiv.state and xceiv.otg. Once we have
+		 * a separate state machine to handle otg, these can be moved
+		 * out of xceiv and then we can start using the generic PHY
+		 * framework
+		 */
 		musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
 		    "usb-phy", 0);
-	else
+	} else {
 		musb->xceiv = devm_usb_get_phy_dev(dev, 0);
+		musb->phy = devm_phy_get(dev, musb->phy_label);
+	}
 
 	if (IS_ERR(musb->xceiv)) {
 		status = PTR_ERR(musb->xceiv);
@@ -364,6 +374,10 @@ static int omap2430_musb_init(struct musb *musb)
 		return -EPROBE_DEFER;
 	}
 
+	if (IS_ERR(musb->phy)) {
+		pr_err("HS USB OTG: no PHY configured\n");
+		return PTR_ERR(musb->phy);
+	}
 	musb->isr = omap2430_musb_interrupt;
 
 	status = pm_runtime_get_sync(dev);
@@ -397,7 +411,7 @@ static int omap2430_musb_init(struct musb *musb)
 	if (glue->status != OMAP_MUSB_UNKNOWN)
 		omap_musb_set_mailbox(glue);
 
-	usb_phy_init(musb->xceiv);
+	phy_init(musb->phy);
 
 	pm_runtime_put_noidle(musb->controller);
 	return 0;
@@ -460,6 +474,7 @@ static int omap2430_musb_exit(struct musb *musb)
 	del_timer_sync(&musb_idle_timer);
 
 	omap2430_low_level_exit(musb);
+	phy_exit(musb->phy);
 
 	return 0;
 }
@@ -619,7 +634,7 @@ static int omap2430_runtime_suspend(struct device *dev)
 				OTG_INTERFSEL);
 
 		omap2430_low_level_exit(musb);
-		usb_phy_set_suspend(musb->xceiv, 1);
+		phy_power_off(musb->phy);
 	}
 
 	return 0;
@@ -634,8 +649,7 @@ static int omap2430_runtime_resume(struct device *dev)
 		omap2430_low_level_init(musb);
 		musb_writel(musb->mregs, OTG_INTERFSEL,
 				musb->context.otg_interfsel);
-
-		usb_phy_set_suspend(musb->xceiv, 0);
+		phy_power_on(musb->phy);
 	}
 
 	return 0;
Signature · 1 line
1.7.10.4
#14 lore raw

PATCH v9 7/8 usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

In reply to Kishon Vijay Abraham I

Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver.

---
 drivers/usb/phy/phy-omap-usb2.c |   25 -------------------------
 1 file changed, 25 deletions(-)
drivers/usb/phy/phy-omap-usb2.c +0 -25
index 751b30f..3f2b125 100644
@@ -97,29 +97,6 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,
 	return 0;
 }
 
-static int omap_usb2_suspend(struct usb_phy *x, int suspend)
-{
-	u32 ret;
-	struct omap_usb *phy = phy_to_omapusb(x);
-
-	if (suspend && !phy->is_suspended) {
-		omap_control_usb_phy_power(phy->control_dev, 0);
-		pm_runtime_put_sync(phy->dev);
-		phy->is_suspended = 1;
-	} else if (!suspend && phy->is_suspended) {
-		ret = pm_runtime_get_sync(phy->dev);
-		if (ret < 0) {
-			dev_err(phy->dev, "get_sync failed with err %d\n",
-									ret);
-			return ret;
-		}
-		omap_control_usb_phy_power(phy->control_dev, 1);
-		phy->is_suspended = 0;
-	}
-
-	return 0;
-}
-
 static int omap_usb_power_off(struct phy *x)
 {
 	struct omap_usb *phy = phy_get_drvdata(x);
@@ -167,7 +144,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 
 	phy->phy.dev		= phy->dev;
 	phy->phy.label		= "omap-usb2";
-	phy->phy.set_suspend	= omap_usb2_suspend;
 	phy->phy.otg		= otg;
 	phy->phy.type		= USB_PHY_TYPE_USB2;
 
@@ -182,7 +158,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	phy->is_suspended	= 1;
 	omap_control_usb_phy_power(phy->control_dev, 0);
 
 	otg->set_host		= omap_usb_set_host;
Signature · 1 line
1.7.10.4
#15 lore raw

PATCH v9 8/8 usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

In reply to Kishon Vijay Abraham I

Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver.

---
 drivers/usb/phy/phy-twl4030-usb.c |   57 +++++++++----------------------------
 1 file changed, 13 insertions(+), 44 deletions(-)
drivers/usb/phy/phy-twl4030-usb.c +13 -44
index 437ba30..2148e2b 100644
@@ -422,25 +422,20 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on)
 	}
 }
 
-static void twl4030_phy_suspend(struct twl4030_usb *twl, int controller_off)
+static int twl4030_phy_power_off(struct phy *phy)
 {
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
+
 	if (twl->asleep)
-		return;
+		return 0;
 
 	twl4030_phy_power(twl, 0);
 	twl->asleep = 1;
 	dev_dbg(twl->dev, "%s\n", __func__);
-}
-
-static int twl4030_phy_power_off(struct phy *phy)
-{
-	struct twl4030_usb *twl = phy_get_drvdata(phy);
-
-	twl4030_phy_suspend(twl, 0);
 	return 0;
 }
 
-static void __twl4030_phy_resume(struct twl4030_usb *twl)
+static void __twl4030_phy_power_on(struct twl4030_usb *twl)
 {
 	twl4030_phy_power(twl, 1);
 	twl4030_i2c_access(twl, 1);
@@ -449,11 +444,13 @@ static void __twl4030_phy_resume(struct twl4030_usb *twl)
 		twl4030_i2c_access(twl, 0);
 }
 
-static void twl4030_phy_resume(struct twl4030_usb *twl)
+static int twl4030_phy_power_on(struct phy *phy)
 {
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
+
 	if (!twl->asleep)
-		return;
-	__twl4030_phy_resume(twl);
+		return 0;
+	__twl4030_phy_power_on(twl);
 	twl->asleep = 0;
 	dev_dbg(twl->dev, "%s\n", __func__);
 
@@ -466,13 +463,6 @@ static void twl4030_phy_resume(struct twl4030_usb *twl)
 		cancel_delayed_work(&twl->id_workaround_work);
 		schedule_delayed_work(&twl->id_workaround_work, HZ);
 	}
-}
-
-static int twl4030_phy_power_on(struct phy *phy)
-{
-	struct twl4030_usb *twl = phy_get_drvdata(phy);
-
-	twl4030_phy_resume(twl);
 	return 0;
 }
 
@@ -604,9 +594,9 @@ static void twl4030_id_workaround_work(struct work_struct *work)
 	}
 }
 
-static int twl4030_usb_phy_init(struct usb_phy *phy)
+static int twl4030_phy_init(struct phy *phy)
 {
-	struct twl4030_usb *twl = phy_to_twl(phy);
+	struct twl4030_usb *twl = phy_get_drvdata(phy);
 	enum omap_musb_vbus_id_status status;
 
 	/*
@@ -621,32 +611,13 @@ static int twl4030_usb_phy_init(struct usb_phy *phy)
 
 	if (status == OMAP_MUSB_ID_GROUND || status == OMAP_MUSB_VBUS_VALID) {
 		omap_musb_mailbox(twl->linkstat);
-		twl4030_phy_resume(twl);
+		twl4030_phy_power_on(phy);
 	}
 
 	sysfs_notify(&twl->dev->kobj, NULL, "vbus");
 	return 0;
 }
 
-static int twl4030_phy_init(struct phy *phy)
-{
-	struct twl4030_usb *twl = phy_get_drvdata(phy);
-
-	return twl4030_usb_phy_init(&twl->phy);
-}
-
-static int twl4030_set_suspend(struct usb_phy *x, int suspend)
-{
-	struct twl4030_usb *twl = phy_to_twl(x);
-
-	if (suspend)
-		twl4030_phy_suspend(twl, 1);
-	else
-		twl4030_phy_resume(twl);
-
-	return 0;
-}
-
 static int twl4030_set_peripheral(struct usb_otg *otg,
 					struct usb_gadget *gadget)
 {
@@ -717,8 +688,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 	twl->phy.label		= "twl4030";
 	twl->phy.otg		= otg;
 	twl->phy.type		= USB_PHY_TYPE_USB2;
-	twl->phy.set_suspend	= twl4030_set_suspend;
-	twl->phy.init		= twl4030_usb_phy_init;
 
 	otg->phy		= &twl->phy;
 	otg->set_host		= twl4030_set_host;
Signature · 1 line
1.7.10.4
#16 lore raw
In reply to Kishon Vijay Abraham I

Hi Kishon,

Quoted 27 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; ABRAHAM, KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external PHY (PHY
functionality is not embedded within the controller).

Quoted 5 lines

The intention of creating this framework is to bring the phy drivers spread
all over the Linux kernel to drivers/phy to increase code re-use and to
increase code maintainability.

I would like to use this framework for a smart-card controller connected to a smart-card phy. I have some questions and would like to get feedback on the same.

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for datasheet and app note for the same. The smart card controller is inside the TI SoC I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to you offline.

Brief about operation:
- The controller can work with and without a PHY
- When not using PHY, it is limited to talking to a single
smart card. There is also a need to put external de-activation logic on card removal for this case.
- With a PHY you can use more than one smart card.
- Phy has 5 slots : 1 for smart card (credit/debit/other card with chip)
and others for SAM ? SIM like modules
- Once the PHY is initialized, there are some operations that the controller
can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)
- In the mode when smartcard controller talks directly to the card without the need
for a PHY, all the above operations will be carried out by the controller itself

My current thought process is to make the controller driver provide the user interface and talk to the PHY using the generic PHY framework you proposed. In the case where there is no PHY, my idea is to create a "dummy" PHY which uses the controller functionality itself.

What I seem to be missing from the PHY framework is support for event detection and generic read/write API which will enable the controller to talk to the PHY for the operations listed above and also react to events from the PHY.

Is there a reason why such functionality has not been included. If it was only a case of lack of use case, then do you think it will be useful to extend the framework to add such functionality? I can help with the development.

Thanks,
Satish

#17 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 29 lines · Satish

Hi Kishon,

Quoted 27 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; ABRAHAM, KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external PHY (PHY
functionality is not embedded within the controller).

Quoted 8 lines
Quoted 5 lines

The intention of creating this framework is to bring the phy drivers spread
all over the Linux kernel to drivers/phy to increase code re-use and to
increase code maintainability.

I would like to use this framework for a smart-card controller connected to a smart-card phy. I have some questions and would like to get feedback on the same.

glad to know that :-)

Quoted 22 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for datasheet and app note for the same. The smart card controller is inside the TI SoC I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to you offline.

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation logic on card removal for this case.

(quoted diff) +0 -3
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card with chip)
       and others for SAM ? SIM like modules
- 	Once the PHY is initialized, there are some operations that the controller
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

Quoted 6 lines
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the card without the need

for a PHY, all the above operations will be carried out by the controller itself

My current thought process is to make the controller driver provide the user interface and talk to the PHY using the generic PHY framework you proposed. In the case where there is no PHY, my idea is to create a "dummy" PHY which uses the controller functionality itself.

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the PHY framework.

Quoted 4 lines

What I seem to be missing from the PHY framework is support for event detection and generic read/write API which will enable the controller to talk to the PHY for the operations listed above and also react to events from the PHY.

IMO the event detection should be handled in the PHY driver. And I dint feel the need for a read/write API as phy_xxxx_ops should be doing that precisely.

Thanks
Kishon

#18 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 65 lines · Kishon Vijay Abraham I
Quoted 29 lines · Satish

Hi Kishon,

Quoted 27 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; ABRAHAM, KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external PHY (PHY
functionality is not embedded within the controller).

Quoted 8 lines
Quoted 5 lines

The intention of creating this framework is to bring the phy drivers spread
all over the Linux kernel to drivers/phy to increase code re-use and to
increase code maintainability.

I would like to use this framework for a smart-card controller connected to a smart-card phy. I have some questions and would like to get feedback on the same.

glad to know that :-)

Quoted 25 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for datasheet and app note for the same. The smart card controller is inside the TI SoC I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to you offline.

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation logic on card removal for this case.

(quoted diff) +0 -3
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card with chip)
      and others for SAM ? SIM like modules
- 	Once the PHY is initialized, there are some operations that the controller

can request of the PHY like:
- Card configurations - set voltage
- Activation of card

Quoted 8 lines
Quoted 4 lines

- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like a regulator thing, but the regulator is controlled through the PHY. I guess it makes sense to have a generic phy_set_voltage() call since even USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that could, easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 10 lines
Quoted 6 lines
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the card without the need

for a PHY, all the above operations will be carried out by the controller itself

My current thought process is to make the controller driver provide the user interface and talk to the PHY using the generic PHY framework you proposed. In the case where there is no PHY, my idea is to create a "dummy" PHY which uses the controller functionality itself.

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the PHY framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily blow up.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130703/9388d732/attachment.sig>
#19 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 99 lines · Felipe Balbi

Hi,

Quoted 65 lines · Kishon Vijay Abraham I
Quoted 29 lines · Satish

Hi Kishon,

Quoted 27 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; ABRAHAM, KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external PHY (PHY
functionality is not embedded within the controller).

Quoted 8 lines
Quoted 5 lines

The intention of creating this framework is to bring the phy drivers spread
all over the Linux kernel to drivers/phy to increase code re-use and to
increase code maintainability.

I would like to use this framework for a smart-card controller connected to a smart-card phy. I have some questions and would like to get feedback on the same.

glad to know that :-)

Quoted 25 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for datasheet and app note for the same. The smart card controller is inside the TI SoC I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to you offline.

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation logic on card removal for this case.

(quoted diff) +0 -3
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card with chip)
       and others for SAM ? SIM like modules
- 	Once the PHY is initialized, there are some operations that the controller

can request of the PHY like:
- Card configurations - set voltage
- Activation of card

Quoted 8 lines
Quoted 4 lines

- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like a regulator thing, but the regulator is controlled through the PHY. I guess it makes sense to have a generic phy_set_voltage() call since even USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that could, easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 7 lines
Quoted 6 lines
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the card without the need

for a PHY, all the above operations will be carried out by the controller itself

My current thought process is to make the controller driver provide the user interface and talk to the PHY using the generic PHY framework you proposed. In the case where there is no PHY, my idea is to create a "dummy" PHY which uses the controller functionality itself.

Quoted 7 lines
Quoted 3 lines

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the PHY framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily blow up.

true. But it's certainly going to be difficult to map certain function specific ops to the generic ops (just like ATR and ADPU in smart card case or set pixel for hdmi).

Thanks
Kishon

#20 lore raw

v9 cover Generic PHY Framework

In reply to Felipe Balbi

Hi,

Quoted 142 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 7 lines · Kishon Vijay Abraham I
Quoted 6 lines · Satish

Hi Kishon,

Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-use

and

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

to
increase code maintainability.

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside the

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card

with chip)

Quoted 2 lines

Review

Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations that the

controller

Quoted 11 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the PHY. I guess it makes sense to have a generic phy_set_voltage() call since even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that could, easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver provide

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you proposed.

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 3 lines

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the

Quoted 8 lines

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};

- Also, can have similar interface phy_getconfig to know current phy state.

Quoted 2 lines

--
balbi

#21 lore raw

v9 cover Generic PHY Framework

Quoted 163 lines · Satish

Hi,

Quoted 142 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 7 lines · Kishon Vijay Abraham I
Quoted 6 lines · Satish

Hi Kishon,

Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-use

and

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

to
increase code maintainability.

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside the

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card

with chip)

Quoted 2 lines

Review

Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations that the

controller

Quoted 11 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the PHY. I guess it makes sense to have a generic phy_set_voltage() call since even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that could, easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver provide

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you proposed.

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 3 lines

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the

Quoted 8 lines

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};

hmm.. this looks similar to ioctl and can be abused easily IMO :s

-Kishon

#22 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 202 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Thursday, July 04, 2013 3:26 PM
To: Patel, Satish
Cc: Balbi, Felipe; grant.likely at linaro.org; tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux-omap at vger.kernel.org; linux-arm- kernel at lists.infradead.org; linux-usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux-foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Quoted 7 lines · Satish

Hi,

Quoted 5 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com;

Balbi,

Quoted 6 lines
Quoted 6 lines

Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 13 lines
Quoted 13 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi Kishon,

Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 1 line
Quoted 1 line
Quoted 1 line

benoit.cousson at linaro.org; mchehab at redhat.com;

cesarb at cesarb.net;

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for

the

Quoted 21 lines
Quoted 21 lines

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-use

and

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

to
increase code maintainability.

I would like to use this framework for a smart-card controller

connected to a

Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside

the

Quoted 17 lines
Quoted 17 lines

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card

with chip)

Quoted 2 lines
Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations

that the

Quoted 9 lines
Quoted 9 lines

controller

Quoted 8 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the PHY.

I

Quoted 8 lines
Quoted 8 lines

guess it makes sense to have a generic phy_set_voltage() call since even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that

could,

Quoted 7 lines
Quoted 7 lines

easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line
Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to

the

Quoted 5 lines
Quoted 5 lines

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver

provide

Quoted 27 lines
Quoted 8 lines

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you proposed.

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 3 lines

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the

Quoted 8 lines

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 2 lines

hmm.. this looks similar to ioctl and can be abused easily IMO :s

what are your inputs to adapt multiple phys into generic phy f/w ?

Quoted 1 line

-Kishon

#23 lore raw

v9 cover Generic PHY Framework

In reply to Kishon Vijay Abraham I
Quoted 173 lines · Kishon Vijay Abraham I
Quoted 163 lines · Satish

Hi,

Quoted 142 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 7 lines · Kishon Vijay Abraham I
Quoted 6 lines · Satish

Hi Kishon,

Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for the

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses external

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-use

and

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

to
increase code maintainability.

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link for

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside the

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details to

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other card

with chip)

Quoted 2 lines

Review

Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations that the

controller

Quoted 11 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include these operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the PHY. I guess it makes sense to have a generic phy_set_voltage() call since even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown() would cover it.

For warm reset perhaps a phy_reset() callback ? Although that could, easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to the

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver provide

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you proposed.

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 3 lines

right. And in the case where you actually have a PHY, create a PHY driver and implement the phy_smart_card_ops and register with the

Quoted 8 lines

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 1 line

hmm.. this looks similar to ioctl and can be abused easily IMO :s

+1

What we need is to come up with generic ways to model those, if we need set voltage, then add a phy_set_voltage() kinda thing, perhaps add capability flags to enable/disable support fort those (just like mmc does).

But adding something which can handle "anything" like phy_set_config(), it's the same as adding use-case specific ops.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130704/5ba55a88/attachment-0001.sig>
#24 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 216 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, July 04, 2013 3:42 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; Balbi, Felipe; grant.likely at linaro.org;
tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Quoted 8 lines · Kishon Vijay Abraham I
Quoted 7 lines · Satish

Hi,

Quoted 5 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com;

Balbi,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi Kishon,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 1 line
Quoted 1 line
Quoted 1 line

benoit.cousson at linaro.org; mchehab at redhat.com;

cesarb at cesarb.net;

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for

the

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses

external

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-

use

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

and

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

to
increase code maintainability.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link

for

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside

the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details

to

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other

card

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

with chip)

Quoted 2 lines
Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations

that the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

controller

Quoted 9 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include

these

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the

PHY. I

Quoted 1 line
Quoted 1 line
Quoted 1 line

guess it makes sense to have a generic phy_set_voltage() call

since

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown()

would

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

cover it.

For warm reset perhaps a phy_reset() callback ? Although that

could,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line
Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to

the

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver

provide

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you

proposed.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 2 lines

right. And in the case where you actually have a PHY, create a

PHY

Quoted 29 lines
Quoted 20 lines
Quoted 9 lines
Quoted 1 line

driver and implement the phy_smart_card_ops and register with the

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 1 line

hmm.. this looks similar to ioctl and can be abused easily IMO :s

Quoted 8 lines

+1

What we need is to come up with generic ways to model those, if we need
set voltage, then add a phy_set_voltage() kinda thing, perhaps add capability flags to enable/disable support fort those (just like mmc does).

This will required study of capabilities of available phys.
Only point of consideration is - list should not gets exhausted to cover all phy capabilities

Quoted 6 lines

But adding something which can handle "anything" like phy_set_config(),
it's the same as adding use-case specific ops.

--
balbi

#25 lore raw

v9 cover Generic PHY Framework

In reply to Felipe Balbi

Hi,

Quoted 224 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, July 04, 2013 3:42 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; Balbi, Felipe; grant.likely at linaro.org;
tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Quoted 8 lines · Kishon Vijay Abraham I
Quoted 7 lines · Satish

Hi,

Quoted 5 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com;

Balbi,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi Kishon,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 1 line
Quoted 1 line
Quoted 1 line

benoit.cousson at linaro.org; mchehab at redhat.com;

cesarb at cesarb.net;

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for

the

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses

external

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-

use

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

and

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

to
increase code maintainability.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link

for

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside

the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details

to

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other

card

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

with chip)

Quoted 2 lines
Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations

that the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

controller

Quoted 9 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include

these

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the

PHY. I

Quoted 1 line
Quoted 1 line
Quoted 1 line

guess it makes sense to have a generic phy_set_voltage() call

since

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown()

would

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

cover it.

For warm reset perhaps a phy_reset() callback ? Although that

could,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line
Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to

the

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver

provide

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you

proposed.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 2 lines

right. And in the case where you actually have a PHY, create a

PHY

Quoted 29 lines
Quoted 20 lines
Quoted 9 lines
Quoted 1 line

driver and implement the phy_smart_card_ops and register with the

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 1 line

hmm.. this looks similar to ioctl and can be abused easily IMO :s

+1

What we need is to come up with generic ways to model those, if we need
set voltage, then add a phy_set_voltage() kinda thing, perhaps add capability flags to enable/disable support fort those (just like mmc does).

Quoted 4 lines

But adding something which can handle "anything" like phy_set_config(),
it's the same as adding use-case specific ops.

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with new generic apis as suggested.

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage
Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot
Smartcard_set_c4/c8/rst/io -> phy_set_pin
Smartcard_warm_reset -> phy_warmreset
Smartcard_set_clkdiv -> phy_set_clock
Smartcard_get_clkdiv -> phy_get_clock
Smartcard_set_atr_mute_timeout -> ??
Smartcard_set_atr_early_timeout -> ??
Smartcard_get_isr_status -> phy_get_status
Smartcard_get_version -> phy_get_version

- Pros:
- smartcard phy can make use of generic phy f/w
- cons:
- does not confirm whether above APIs will capable of including requirements of other available phys
- list might gets extended for other phys like ethernet, sensor phy etc.
- any change in single api needs to validated for all existing phy which has bind to generic f/w

Option 2:
We can have set/get config or generic ops kind of implementation

- pros:
- all phy can be pluged-in to this f/w. The word "generic phy" will be justified
- no cost of maintaining or defining apis for unknown phy capabilities at present

- cons:
- factor of getting abused by community.

My recommendation is to see the problem as generic logical level rather than thinking what already exits and what cannot be repeated - because interface looks like user space or kernel space communication.

Where we should make our call ??

-
satish

Quoted 2 lines

--
balbi

#26 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 240 lines · Satish

Hi,

Quoted 224 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, July 04, 2013 3:42 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; Balbi, Felipe; grant.likely at linaro.org;
tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Quoted 8 lines · Kishon Vijay Abraham I
Quoted 7 lines · Satish

Hi,

Quoted 5 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com;

Balbi,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi Kishon,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 1 line
Quoted 1 line
Quoted 1 line

benoit.cousson at linaro.org; mchehab at redhat.com;

cesarb at cesarb.net;

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for

the

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

PHY

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses

external

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-

use

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

and

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

to
increase code maintainability.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link

for

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside

the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

TI SoC

Quoted 9 lines
Quoted 9 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

The TI SoC details are not public (yet). I can provide details

to

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-activation

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other

card

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

with chip)

Quoted 2 lines
Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations

that the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

controller

Quoted 9 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

hmm.. We should think about extending the phy_ops to include

these

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage sounds like
a regulator thing, but the regulator is controlled through the

PHY. I

Quoted 1 line
Quoted 1 line
Quoted 1 line

guess it makes sense to have a generic phy_set_voltage() call

since

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown()

would

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

cover it.

For warm reset perhaps a phy_reset() callback ? Although that

could,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

easily, get abused.

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line
Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to

the

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out by the

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver

provide

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you

proposed.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 2 lines

right. And in the case where you actually have a PHY, create a

PHY

Quoted 29 lines
Quoted 20 lines
Quoted 9 lines
Quoted 1 line

driver and implement the phy_smart_card_ops and register with the

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It would easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up whole concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

Quoted 8 lines
	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 1 line

hmm.. this looks similar to ioctl and can be abused easily IMO :s

+1

What we need is to come up with generic ways to model those, if we need
set voltage, then add a phy_set_voltage() kinda thing, perhaps add capability flags to enable/disable support fort those (just like mmc does).

Quoted 4 lines

But adding something which can handle "anything" like phy_set_config(),
it's the same as adding use-case specific ops.

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with new generic apis as suggested.

Quoted 5 lines

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage
Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot

how is activate/deactivate different from poweron/poweroff in this use case?

Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed dynamically?

Quoted 1 line

Smartcard_warm_reset -> phy_warmreset

Again looks to me like it should be part of init.

Quoted 2 lines

Smartcard_set_clkdiv -> phy_set_clock
Smartcard_get_clkdiv -> phy_get_clock

Why would the smartcard give clock to the PHY? Shouldn't the driver of the PHY driver be doing that by itself?

Quoted 3 lines

Smartcard_set_atr_mute_timeout -> ??
Smartcard_set_atr_early_timeout -> ??
Smartcard_get_isr_status -> phy_get_status

Why? Is it like the detection of an external event? Then the PHY driver should use *extcon* for event detection and passing.

Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Thanks
Kishon

#27 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 273 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Monday, July 08, 2013 5:47 PM
To: Patel, Satish
Cc: Balbi, Felipe; grant.likely at linaro.org; tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux-omap at vger.kernel.org; linux-arm- kernel at lists.infradead.org; linux-usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux-foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-discuss at lists.ozlabs.org; linux-
doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas; Srinivasan, Nageswari; Sundareson, Prabindh
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 14 lines · Satish

Hi,

Quoted 11 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, July 04, 2013 3:42 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; Balbi, Felipe; grant.likely at linaro.org; tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 11 lines
Quoted 11 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi,

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, July 03, 2013 6:51 PM
To: ABRAHAM, KISHON VIJAY
Cc: Patel, Satish; grant.likely at linaro.org; tony at atomide.com;

Balbi,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Felipe; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org;

mchehab at redhat.com;

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree- discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori,

Sekhar;

Quoted 31 lines
Quoted 31 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Krishnamoorthy, Balaji T; Cherian, George
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 3 lines · Kishon Vijay Abraham I
Quoted 2 lines · Satish

Hi Kishon,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-----Original Message-----
From: ABRAHAM, KISHON VIJAY
Sent: Wednesday, June 26, 2013 5:17 PM
To: grant.likely at linaro.org; tony at atomide.com; Balbi, Felipe;

ABRAHAM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

KISHON VIJAY; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org;

linux-

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org;

linux-

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org
Cc: rob.herring at calxeda.com; rob at landley.net;

linux at arm.linux.org.uk;

Quoted 1 line
Quoted 1 line
Quoted 1 line

benoit.cousson at linaro.org; mchehab at redhat.com;

cesarb at cesarb.net;

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org;

Shilimkar,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Santosh; devicetree-discuss at lists.ozlabs.org; linux- doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T;

Cherian,

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

George
Subject: [PATCH v9 0/8] Generic PHY Framework

Added a generic PHY framework that provides a set of APIs for

the

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

PHY

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers
to create/destroy a PHY and APIs for the PHY users to obtain

a

Quoted 39 lines
Quoted 39 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

reference to
the PHY with or without using phandle.

This framework will be of use only to devices that uses

external

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PHY

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(PHY
functionality is not embedded within the controller).

The intention of creating this framework is to bring the phy

drivers

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

spread
all over the Linux kernel to drivers/phy to increase code re-

use

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

and

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

to
increase code maintainability.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line

I would like to use this framework for a smart-card controller

connected to a

Quoted 1 line
Quoted 1 line

smart-card phy. I have some questions and would like to get

feedback on the same.

Quoted 4 lines

glad to know that :-)

Quoted 2 lines

I am using ?TDA8026" Smartcard PHY from NXP. Here is the link

for

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

datasheet

Quoted 1 line
Quoted 1 line

and app note for the same. The smart card controller is inside

the

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

TI SoC

Quoted 8 lines
Quoted 8 lines

I am working with.

Datasheet :
www.nxp.com/documents/data_sheet/TDA8026.pdf?

Appnote :
http://www.nxp.com/documents/application_note/AN10724.pdf

Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

The TI SoC details are not public (yet). I can provide details

to

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

you offline.

Quoted 5 lines
Quoted 5 lines

Brief about operation:

(quoted diff) +0 -2
-	The controller can work with and without a PHY
-	When not using PHY, it is limited to talking to a single

smart card. There is also a need to put external de-

activation

Quoted 18 lines
Quoted 18 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

logic

Quoted 3 lines

Review

Quoted 3 lines

on card removal for this case.

(quoted diff) +0 -2
-	With a PHY you can use more than one smart card.
-	Phy has 5 slots :  1 for smart card (credit/debit/other

card

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

with chip)

Quoted 2 lines
Quoted 2 lines

and others for SAM ? SIM like modules

(quoted diff) +0 -1
- 	Once the PHY is initialized, there are some operations

that the

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

controller

Quoted 8 lines
Quoted 7 lines

can request of the PHY like:
- Card configurations - set voltage
- Activation of card
- ATR ? Answer to reset
- Warm reset
- ADPU exchange
- Deactivation ( Normal/Emergency)

Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

hmm.. We should think about extending the phy_ops to include

these

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

operations (something like phy_smart_card_ops so that other smart_card PHYs will also be able to use it).

let's try to avoid use-case specific additions. set_voltage

sounds

Quoted 16 lines
Quoted 16 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

like
a regulator thing, but the regulator is controlled through the

PHY. I

Quoted 1 line
Quoted 1 line
Quoted 1 line

guess it makes sense to have a generic phy_set_voltage() call

since

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

even
USB can make use of that.

For card activation, it sounds like phy_init()/phy_shutdown()

would

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

cover it.

For warm reset perhaps a phy_reset() callback ? Although that

could,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

easily, get abused.

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

For deactivation, that's phy_shutdown().

ATR and ADPU needs more thought, I guess.

Quoted 1 line
Quoted 1 line
(quoted diff) +0 -1
- 	In the mode when smartcard controller talks directly to

the

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

card without the need

Quoted 1 line
Quoted 1 line

for a PHY, all the above operations will be carried out

by the

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

controller itself

Quoted 2 lines
Quoted 2 lines

My current thought process is to make the controller driver

provide

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

the user interface

Quoted 1 line
Quoted 1 line

and talk to the PHY using the generic PHY framework you

Quoted 8 lines
Quoted 8 lines

proposed.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

In the case where there

Quoted 1 line
Quoted 1 line

is no PHY, my idea is to create a "dummy" PHY which uses the

controller functionality itself.

Quoted 2 lines

right. And in the case where you actually have a PHY, create a

PHY

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

driver and implement the phy_smart_card_ops and register with

the

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

PHY

Quoted 1 line

framework.

I would try to avoid that. Otherwise we will have phy_usb_ops, phy_sata_ops, phy_network_ops, phy_pci_ops, etc etc etc. It

would

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

easily
blow up.

- I do agree with you. Creating Phy specific ops will blow up

whole

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines

concept of generic phy f/w.
- Can we have interface like phy_setconfig - with parameter like phy_setconfig(int param, void *value)
- Here param can be enum of available config parameters for specific phy.
Phy can perform different operation/set internal state based on param selection and value passed by.

e.x in case of smartcard

	enum set_config {
		SET_VOLATAGE,
		SET_ACTIVATE,
		SET_WARMRESET,
		SET_ATR,
		SET_DEACTIVE,
		....
	};
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

hmm.. this looks similar to ioctl and can be abused easily IMO :s

+1

What we need is to come up with generic ways to model those, if we need
set voltage, then add a phy_set_voltage() kinda thing, perhaps add capability flags to enable/disable support fort those (just like

mmc

Quoted 15 lines
Quoted 6 lines

does).

But adding something which can handle "anything" like phy_set_config(),
it's the same as adding use-case specific ops.

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with new generic apis as suggested.

Quoted 8 lines
Quoted 5 lines

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage
Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot

how is activate/deactivate different from poweron/poweroff in this use case?

power on/off normal power sequence. While activate/de-activate will be called during card transaction.

Brief on how it works:
- when system start, execute power on for phy
- smartcard controller and phy is connected through i2c, clock lines and i/o lines
- clock will be supplied by controller to phy to get data sync on i/o lines

Operation:

Once the card gets inserted into the slot, user application can initiate activate sequence anytime, it is not mandatory that activation has to be called Immediately. It all depends whether other connections ( network, printer) are proper. User application can do some checks and then dynamically activate the card

There are 2 sequence of activation - normal activation and warm reset. If first fails then warm reset should be executed, if card does not response to both then deactivation will be carried out

- For activation there are some timing parameters ( called ATR - Answer to reset timings) Has to be set to the phy

- on activation card will respond with some initial characters (ATR), which will be verified by application, in case of error user application will de-activate the card not the phy module

- After activation, use application initiate normal tx/rx

- Once tx/rx is done, it will initiate deactivation of card not the phy module.

Quoted 4 lines
Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed dynamically?

These are all phy pins which will be physically come in contact with smart card When inserted. In case of synchronous card, these pins will be toggled manually by s/w bit bang algorithm

Quoted 2 lines
Quoted 1 line

Smartcard_warm_reset -> phy_warmreset

Explained above.

Quoted 7 lines

Again looks to me like it should be part of init.

Quoted 2 lines

Smartcard_set_clkdiv -> phy_set_clock
Smartcard_get_clkdiv -> phy_get_clock

Why would the smartcard give clock to the PHY? Shouldn't the driver of the PHY driver be doing that by itself?

Source of clock to the phy is from smart card controller

Quoted 4 lines
Quoted 3 lines

Smartcard_set_atr_mute_timeout -> ??
Smartcard_set_atr_early_timeout -> ??
Smartcard_get_isr_status -> phy_get_status

ATR timeout parameter has to be configured for activation. This will differ for various smart card segments.

Quoted 3 lines

Why? Is it like the detection of an external event? Then the PHY driver should use *extcon* for event detection and passing.

Smartcard controller need a way to ready isr status ( like card presence, Card inserted in to which slot, removed from which slot ) to maintain its Internal state machine.

Quoted 4 lines
Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Can be omitted. This is for the test suite reference.

Quoted 2 lines

Thanks
Kishon

#28 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 14 lines · Satish
Quoted 14 lines
Quoted 13 lines

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with new generic apis as suggested.

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage
Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot

Quoted 5 lines
Quoted 2 lines

how is activate/deactivate different from poweron/poweroff in this use case?

power on/off normal power sequence. While activate/de-activate will be called during card transaction.

why can't you implement activate/deactivate with suspend/resume ?

Quoted 5 lines

Brief on how it works:
- when system start, execute power on for phy
- smartcard controller and phy is connected through i2c, clock lines and i/o lines
- clock will be supplied by controller to phy to get data sync on i/o lines

fair enough.

Quoted 7 lines

Operation:

Once the card gets inserted into the slot, user application can initiate activate sequence anytime, it is not mandatory that activation has to be called Immediately. It all depends whether other connections ( network, printer) are proper. User application can do some checks and then dynamically activate the card

The card or the phy ? Who actually activates ? Is the activation handling part of the PHY or part of the smartcard controller ?

Quoted 3 lines

There are 2 sequence of activation - normal activation and warm reset. If first fails then warm reset should be executed, if card does not response to both then deactivation will be carried out

ret = phy_resume(phy);
if (ret == -EINVAL) { /* perhaps there's a better error code */

	ret = phy_reset(phy);
	if (ret)
		phy_suspend(phy);
}

????

Quoted 2 lines

- For activation there are some timing parameters ( called ATR - Answer to reset timings) Has to be set to the phy

does that change in runtime or is it something which is set during probe and never touched again ?

Quoted 8 lines

- on activation card will respond with some initial characters (ATR), which will be verified by application, in case of error user application will de-activate the card not the phy module

- After activation, use application initiate normal tx/rx

- Once tx/rx is done, it will initiate deactivation of card not the phy module.

then that has nothing to do with the PHY framework, right ?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed dynamically?

These are all phy pins which will be physically come in contact with smart card When inserted. In case of synchronous card, these pins will be toggled manually by s/w bit bang algorithm

is that a requirement or just something that everybody does ?

In any case, you can hide that under some gpio calls, or something similar.

Quoted 7 lines
Quoted 3 lines

Why? Is it like the detection of an external event? Then the PHY driver should use *extcon* for event detection and passing.

Smartcard controller need a way to ready isr status ( like card presence, Card inserted in to which slot, removed from which slot ) to maintain its Internal state machine.

register an interrupt handler with devm_request_threaded_irq(), what's the problem ?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Can be omitted. This is for the test suite reference.

if it's for testsuite, it sounds like something that should be done through userland and, as such, should be implemented by a set of debugfs files which expose the necessary information. That has nothing to do with the PHY framework.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130709/b8472db6/attachment-0001.sig>
#29 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 60 lines

-----Original Message-----
From: Balbi, Felipe
Sent: Tuesday, July 09, 2013 5:14 PM
To: Patel, Satish
Cc: ABRAHAM, KISHON VIJAY; Balbi, Felipe; grant.likely at linaro.org; tony at atomide.com; arnd at arndb.de; swarren at nvidia.com; sylvester.nawrocki at gmail.com; linux-kernel at vger.kernel.org; linux- omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- usb at vger.kernel.org; gregkh at linuxfoundation.org; akpm at linux- foundation.org; rob.herring at calxeda.com; rob at landley.net; linux at arm.linux.org.uk; benoit.cousson at linaro.org; mchehab at redhat.com; cesarb at cesarb.net; davem at davemloft.net; Nayak, Rajendra; shawn.guo at linaro.org; Shilimkar, Santosh; devicetree-
discuss at lists.ozlabs.org; linux-doc at vger.kernel.org; Nori, Sekhar; Krishnamoorthy, Balaji T; Cherian, George; Mankad, Maulik Ojas; Srinivasan, Nageswari; Sundareson, Prabindh
Subject: Re: [PATCH v9 0/8] Generic PHY Framework

Hi,

Quoted 6 lines · Satish
Quoted 6 lines
Quoted 6 lines

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with

new

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

generic apis as suggested.

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage
Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot

Quoted 4 lines
Quoted 2 lines

how is activate/deactivate different from poweron/poweroff in this use case?

power on/off normal power sequence. While activate/de-activate will

be

Quoted 1 line

called during card transaction.

why can't you implement activate/deactivate with suspend/resume ?

Quoted 3 lines

Brief on how it works:
- when system start, execute power on for phy
- smartcard controller and phy is connected through i2c, clock lines

and

Quoted 2 lines

i/o lines
- clock will be supplied by controller to phy to get data sync on

i/o lines

fair enough.

Quoted 5 lines

Operation:

Once the card gets inserted into the slot, user application can initiate activate sequence anytime, it is not mandatory that activation has to be called Immediately. It all depends whether

Quoted 7 lines

other

Quoted 2 lines

connections ( network, printer) are proper. User application can do some checks and then dynamically activate the card

The card or the phy ? Who actually activates ? Is the activation handling part of the PHY or part of the smartcard controller ?

It?s a activation of smart card which is inserted into the phy slot. Smart card activation will by done phy but initiated by user application Handling of activation should be done at both the side - controller as well As phy. Phy will raise certain signals and check timeout while activation , while controller will store data coming from smart card to FIFO. Its Controller which will give command to phy to initiate activation sequence when it is ready.

Which means, both controller and phy has role to play while activation. Also it is applicable while deactivation.

Quoted 5 lines
Quoted 1 line

There are 2 sequence of activation - normal activation and warm

reset.

Quoted 2 lines

If first fails then warm reset should be executed, if card does not response to both then deactivation will be carried out

Quoted 7 lines

ret = phy_resume(phy);
if (ret == -EINVAL) { /* perhaps there's a better error code */

	ret = phy_reset(phy);
	if (ret)
		phy_suspend(phy);
}

Its not like this. There are the cases, when during normal activation card respond With some characters, but they might not be valid or error prone - This check will be done by user application as only application knows how to decode characters as per protocol.

It there is any error in characters/timeout paratmeters, user application will ask to initiate Warm reset.

Quoted 14 lines

????

Quoted 2 lines

- For activation there are some timing parameters ( called ATR - Answer to reset timings) Has to be set to the phy

does that change in runtime or is it something which is set during probe
and never touched again ?

Quoted 1 line

- on activation card will respond with some initial characters

(ATR),

Quoted 3 lines

which will be verified by application, in case of error user application will de-activate the card not the phy module

Quoted 6 lines
Quoted 4 lines

- After activation, use application initiate normal tx/rx

- Once tx/rx is done, it will initiate deactivation of card not the phy module.

then that has nothing to do with the PHY framework, right ?

But all such sequence will be initiated by PHY by raising certain signals and only controller can give the push when to start.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed

Quoted 9 lines

dynamically?

Quoted 3 lines

These are all phy pins which will be physically come in contact with smart card When inserted. In case of synchronous card, these pins

will

Quoted 1 line

be toggled manually by s/w bit bang algorithm

is that a requirement or just something that everybody does ?

Its requirement for synchronous card. At present there is no open driver Which does this thing.

Quoted 2 lines

In any case, you can hide that under some gpio calls, or something similar.

Can't be done using GPIO as pin can be toggled only which i2c read/write to the phy.

Quoted 19 lines
Quoted 6 lines
Quoted 4 lines

Why? Is it like the detection of an external event? Then the PHY driver should use *extcon* for event detection and passing.

Smartcard controller need a way to ready isr status ( like card

presence,

Quoted 1 line

Card inserted in to which slot, removed from which slot ) to

maintain its

Quoted 1 line

Internal state machine.

register an interrupt handler with devm_request_threaded_irq(), what's the problem ?

Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Quoted 8 lines
Quoted 1 line

Can be omitted. This is for the test suite reference.

if it's for testsuite, it sounds like something that should be done through userland and, as such, should be implemented by a set of debugfs
files which expose the necessary information. That has nothing to do with the PHY framework.

Agree.. can be omitted.

I am ok to give internal webex presentation (TI team) to brief on phy and smart card controller interface.

Quoted 2 lines

--
balbi

#30 lore raw

v9 cover Generic PHY Framework

Hi,

Quoted 21 lines · Satish
Quoted 5 lines
Quoted 5 lines

Operation:

Once the card gets inserted into the slot, user application can initiate activate sequence anytime, it is not mandatory that activation has to be called Immediately. It all depends whether

Quoted 7 lines

other

Quoted 2 lines

connections ( network, printer) are proper. User application can do some checks and then dynamically activate the card

The card or the phy ? Who actually activates ? Is the activation handling part of the PHY or part of the smartcard controller ?

It?s a activation of smart card which is inserted into the phy slot. Smart card activation will by done phy but initiated by user application Handling of activation should be done at both the side - controller as well As phy. Phy will raise certain signals and check timeout while activation , while controller will store data coming from smart card to FIFO. Its Controller which will give command to phy to initiate activation sequence when it is ready.

Quoted 2 lines

Which means, both controller and phy has role to play while activation. Also it is applicable while deactivation.

right, so when the smartcard device is opened, you want to powerup the PHY, powerup the smartcard controller and get things going, which means that all your activation logic can, and should, be hidden by phy_power_on() and phy_power_off()

Perhaps you also want to delay phy_init() and phy_shutdown() to that very time, which would mean that we wouldn't even need phy_power_{on,off}() calls whatsoever.

Quoted 13 lines
Quoted 5 lines
Quoted 1 line

There are 2 sequence of activation - normal activation and warm

reset.

Quoted 2 lines

If first fails then warm reset should be executed, if card does not response to both then deactivation will be carried out

Quoted 7 lines

ret = phy_resume(phy);
if (ret == -EINVAL) { /* perhaps there's a better error code */

	ret = phy_reset(phy);
	if (ret)
		phy_suspend(phy);
}
Quoted 4 lines

Its not like this. There are the cases, when during normal activation card respond With some characters, but they might not be valid or error prone - This check will be done by user application as only application knows how to decode characters as per protocol.

sure, and if the characters are invalid, the application needs to tell the kernel, perhaps it would be enough to send and IOCTL or, even easier, close the device and reopen it.

Quoted 2 lines

It there is any error in characters/timeout paratmeters, user application will ask to initiate Warm reset.

and for that we can use an IOCTL which is implemented by smart card layer. I mean, I'm assuming the smartcard would be seen as a char dev by userland so it would be something like this:

ret = read(fd, buf, SIZE);
if (ret < 0)

	boom();

ret = process_buffer(buf, ret);
if (ret == -EINVAL) { /* we have received invalid characters */

	ret = ioctl(fd, IOCTL_SMARTCARD_WARM_RESET);
	if (ret < 0)
		handle_error();
}

in kernel space we would have an ioctl handler like so:

static int smart_card_ioctl(struct file *fd, unsigned code, usigned long v)

{
	struct smart_card *sc = fd->private_data;
	unsigned long flags;
	int ret;

	spin_lock_irqsave(&sc->lock, flags);
	switch (v)
	case SMART_CARD_WARM_RESET:
		ret = phy_shutdown(sc->phy);
		if (ret < 0)
			boom();

		ret = smart_card_reset(sc);
		if (ret < 0)
			boom();

		ret = phy_init(sc->phy);
		if (ret < 0)
			boom();
		break;
	[ ... ]
	}

	spin_unlock_irqrestore(&sc->lock, flags);

	return ret;
}

see, we don't need to add a bunch of stuff in the PHY framework, because you shouldn't expose the PHY directly to userland. You *must* have an abstraction to userland with an in-kernel usage of the PHY layer.

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

- on activation card will respond with some initial characters

(ATR),

Quoted 5 lines

which will be verified by application, in case of error user application will de-activate the card not the phy module

- After activation, use application initiate normal tx/rx

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

- Once tx/rx is done, it will initiate deactivation of card not the phy module.

then that has nothing to do with the PHY framework, right ?

But all such sequence will be initiated by PHY by raising certain signals and only controller can give the push when to start.

sure, that's fair. But you don't need to expose every single detail of the PHY. You need to use abstractions to make accesses to the PHY easy to maintain. See the example above.

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed

dynamically?

Quoted 3 lines

These are all phy pins which will be physically come in contact with smart card When inserted. In case of synchronous card, these pins

Quoted 8 lines
Quoted 5 lines

will

Quoted 1 line

be toggled manually by s/w bit bang algorithm

is that a requirement or just something that everybody does ?

Its requirement for synchronous card. At present there is no open driver Which does this thing.

alright, so you need to tell the PHY in which mode it should work and the PHY driver needs to be smart enough to choose proper callbacks depending on the mode.

Quoted 5 lines
Quoted 2 lines

In any case, you can hide that under some gpio calls, or something similar.

Can't be done using GPIO as pin can be toggled only which i2c read/write to the phy.

so ? look at the numerous I2C GPIO expanders we have in the kernel ;-)

Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Quoted 8 lines
Quoted 1 line

Can be omitted. This is for the test suite reference.

if it's for testsuite, it sounds like something that should be done through userland and, as such, should be implemented by a set of debugfs
files which expose the necessary information. That has nothing to do with the PHY framework.

Quoted 5 lines

Agree.. can be omitted.

I am ok to give internal webex presentation (TI team) to brief on phy and smart card controller interface.

let's try to cut down on internal agreements and let the community help defining a proper way to handle the PHY :-)

Still, if you want to point me and Kishon (privately) to some internal documentation, we can certainly read through it :-)

cheers

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130709/9c264c9a/attachment.sig>
#31 lore raw

v9 cover Generic PHY Framework

Hi Balbi, Kishon,

I have similar requirements for exynos hdmi phy. hdmi driver (controller) need to set the operating clock to hdmi phy which depends on the pixel clock.

Phy has an internal pll to be configured as per changing resolution. It can be done by writing into phy registers. CCF callbacks (set/get_rate) can not be used unless I register phy as a clock controller. But that way hdmi driver loses finer power control for the phy. Phy should be ON, only when hdmi hotplugged.

Callback: set_phy_operating_freq in phy framework, seems generic and addressing similar requirements for other phys. What you say on this?

regards,
Rahul Sharma.

Quoted 195 lines · Felipe Balbi

Hi,

Quoted 21 lines · Satish
Quoted 5 lines
Quoted 5 lines

Operation:

Once the card gets inserted into the slot, user application can initiate activate sequence anytime, it is not mandatory that activation has to be called Immediately. It all depends whether

Quoted 7 lines

other

Quoted 2 lines

connections ( network, printer) are proper. User application can do some checks and then dynamically activate the card

The card or the phy ? Who actually activates ? Is the activation handling part of the PHY or part of the smartcard controller ?

It?s a activation of smart card which is inserted into the phy slot. Smart card activation will by done phy but initiated by user application Handling of activation should be done at both the side - controller as well As phy. Phy will raise certain signals and check timeout while activation , while controller will store data coming from smart card to FIFO. Its Controller which will give command to phy to initiate activation sequence when it is ready.

Quoted 2 lines

Which means, both controller and phy has role to play while activation. Also it is applicable while deactivation.

right, so when the smartcard device is opened, you want to powerup the PHY, powerup the smartcard controller and get things going, which means that all your activation logic can, and should, be hidden by phy_power_on() and phy_power_off()

Perhaps you also want to delay phy_init() and phy_shutdown() to that very time, which would mean that we wouldn't even need phy_power_{on,off}() calls whatsoever.

Quoted 13 lines
Quoted 5 lines
Quoted 1 line

There are 2 sequence of activation - normal activation and warm

reset.

Quoted 2 lines

If first fails then warm reset should be executed, if card does not response to both then deactivation will be carried out

Quoted 7 lines

ret = phy_resume(phy);
if (ret == -EINVAL) { /* perhaps there's a better error code */

    ret = phy_reset(phy);
    if (ret)
            phy_suspend(phy);
}
Quoted 4 lines

Its not like this. There are the cases, when during normal activation card respond With some characters, but they might not be valid or error prone - This check will be done by user application as only application knows how to decode characters as per protocol.

sure, and if the characters are invalid, the application needs to tell the kernel, perhaps it would be enough to send and IOCTL or, even easier, close the device and reopen it.

Quoted 2 lines

It there is any error in characters/timeout paratmeters, user application will ask to initiate Warm reset.

and for that we can use an IOCTL which is implemented by smart card layer. I mean, I'm assuming the smartcard would be seen as a char dev by userland so it would be something like this:

ret = read(fd, buf, SIZE);
if (ret < 0)

        boom();

ret = process_buffer(buf, ret);
if (ret == -EINVAL) { /* we have received invalid characters */

        ret = ioctl(fd, IOCTL_SMARTCARD_WARM_RESET);
        if (ret < 0)
                handle_error();
}

in kernel space we would have an ioctl handler like so:

static int smart_card_ioctl(struct file *fd, unsigned code, usigned long v)

{
        struct smart_card *sc = fd->private_data;
        unsigned long flags;
        int ret;

        spin_lock_irqsave(&sc->lock, flags);
        switch (v)
        case SMART_CARD_WARM_RESET:
                ret = phy_shutdown(sc->phy);
                if (ret < 0)
                        boom();

                ret = smart_card_reset(sc);
                if (ret < 0)
                        boom();

                ret = phy_init(sc->phy);
                if (ret < 0)
                        boom();
                break;
        [ ... ]
        }

        spin_unlock_irqrestore(&sc->lock, flags);

        return ret;
}

see, we don't need to add a bunch of stuff in the PHY framework, because you shouldn't expose the PHY directly to userland. You *must* have an abstraction to userland with an in-kernel usage of the PHY layer.

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

- on activation card will respond with some initial characters

(ATR),

Quoted 5 lines

which will be verified by application, in case of error user application will de-activate the card not the phy module

- After activation, use application initiate normal tx/rx

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

- Once tx/rx is done, it will initiate deactivation of card not the phy module.

then that has nothing to do with the PHY framework, right ?

But all such sequence will be initiated by PHY by raising certain signals and only controller can give the push when to start.

sure, that's fair. But you don't need to expose every single detail of the PHY. You need to use abstractions to make accesses to the PHY easy to maintain. See the example above.

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

Whats should be exactly done here? Looks to me like it should be part of init. Does these pin settings need to be changed

dynamically?

Quoted 3 lines

These are all phy pins which will be physically come in contact with smart card When inserted. In case of synchronous card, these pins

Quoted 8 lines
Quoted 5 lines

will

Quoted 1 line

be toggled manually by s/w bit bang algorithm

is that a requirement or just something that everybody does ?

Its requirement for synchronous card. At present there is no open driver Which does this thing.

alright, so you need to tell the PHY in which mode it should work and the PHY driver needs to be smart enough to choose proper callbacks depending on the mode.

Quoted 5 lines
Quoted 2 lines

In any case, you can hide that under some gpio calls, or something similar.

Can't be done using GPIO as pin can be toggled only which i2c read/write to the phy.

so ? look at the numerous I2C GPIO expanders we have in the kernel ;-)

Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Smartcard_get_version -> phy_get_version

Again why? Why would the smartcard need the version of the PHY?

Quoted 8 lines
Quoted 1 line

Can be omitted. This is for the test suite reference.

if it's for testsuite, it sounds like something that should be done through userland and, as such, should be implemented by a set of debugfs
files which expose the necessary information. That has nothing to do with the PHY framework.

Quoted 5 lines

Agree.. can be omitted.

I am ok to give internal webex presentation (TI team) to brief on phy and smart card controller interface.

let's try to cut down on internal agreements and let the community help defining a proper way to handle the PHY :-)

Still, if you want to point me and Kishon (privately) to some internal documentation, we can certainly read through it :-)

cheers

--
balbi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#32 lore raw

v9 cover Generic PHY Framework

In reply to Patel, Satish

Hi,

On Mon, Jul 08, 2013 at 01:24:49PM +0200, Patel, Satish wrote:

[ big snip ]

Quoted 11 lines

We have two options over here

Option 1:

Defining generic api to which can be mapped over multiple phys For smartcard case, I have can thought of following mapping with new generic apis as suggested.

Smartcard_poweron -> power_on
Smartcard_powerdown -> power_off
Smartcard_set_voltage -> phy_set_voltage

these three are generic enough

Quoted 2 lines

Smartcard_activate_card -> phy_activate_slot
Smartcard_deactivate_card -> phy_deactivate_slot

this looks unnecessary, why can't you always activate the card when you phy_poweron ?

Quoted 1 line

Smartcard_set_c4/c8/rst/io -> phy_set_pin

why do you want to control each pin separately ? looks like something we don't want to allow, in order to prevent users fiddling with the HW directly.

Quoted 1 line

Smartcard_warm_reset -> phy_warmreset

phy_reset()

Quoted 2 lines

Smartcard_set_clkdiv -> phy_set_clock
Smartcard_get_clkdiv -> phy_get_clock

why do you need to control the clock like that ? That should be something in the clock framework and, hey, it already exists:

clk_set_rate()
clk_get_rate()

Quoted 4 lines

Smartcard_set_atr_mute_timeout -> ??
Smartcard_set_atr_early_timeout -> ??
Smartcard_get_isr_status -> phy_get_status
Smartcard_get_version -> phy_get_version

these look unnecessary. Why does any other entity need to know about the PHY version and Interrupt status ?

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130708/f80e2ded/attachment.sig>